Re: Pavel steping up for ARC glibc maintenance
On 1/30/23 22:07, Vineet Gupta wrote: > Hi Carlos, > > I'd like to introduce Pavel who intends to step up to maintain ARC glibc port > and do periodic wiki updates and such. > I've pointed him to links [1] and [2]. Sounds great! Welcome Pavel! > To begin with can he be granted wiki edit access and subsequently also > approve his write access to glibc sourceware repo. We can absolutely help with the next steps. Please follow [2] and if you get stuck anywhere just reach out on IRC or by email. > Thx, > -Vineet > > > [1] > https://sourceware.org/glibc/wiki/MAINTAINERS#Becoming_a_maintainer_.28developer.29 > [2] https://sourceware.org/glibc/wiki/MAINTAINERS#AccountsOnSourceware > -- Cheers, Carlos. ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Re: sourceware account access
On 3/10/20 2:08 PM, Vineet Gupta wrote: > On 3/10/20 10:57 AM, Carlos O'Donell via Libc-alpha wrote: >> Please take a look at the following page: >> >> "Becoming a maintainer (developer)": >> https://sourceware.org/glibc/wiki/MAINTAINERS#Becoming_a_maintainer_.28developer.29 >> ~~~ >> 5. Ask for commit access. >> >> * Ask one of the project stewards to authorize your commit access. >> >> * If the project steward authorizes you for commit access follow these >> instructions to create a sourceware account with commit access to the >> glibc repository. >> ~~~ >> >> Joseph and I are both stewards. >> "Project stewards (GNU package maintainers)" >> https://sourceware.org/glibc/wiki/MAINTAINERS#Project_stewards_.28GNU_package_maintainers.29 >> >> I would be happy to authorize your commit access. >> >> I assume your intent is to be one of the machine maintainers for ARC? > > Yeah, this email was my indirect way of asking for commit access :-) > Indeed this is for ARC glibc machine maintainer. Please submit the request then and include my email. -- Cheers, Carlos. ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Re: sourceware account access (was Re: [PATCH v3 01/17] gcc PR 88409: miscompilation due to missing cc clobber in longlong.h macros)
On 3/10/20 1:23 PM, Vineet Gupta wrote: > On 3/6/20 4:21 PM, Vineet Gupta wrote: >> >> BTW, I don't think I asked for commit access before. I just rechecked >> MAINTAINERS >> wiki page and seems like someone needs to grant me that. > > Hi Joseph, Carlos > > I'm trying to setup my sourceware account etc and the form below [1] needs > "email > address of person who approved request". Whats the typical procedure for > getting > that ? Please take a look at the following page: "Becoming a maintainer (developer)": https://sourceware.org/glibc/wiki/MAINTAINERS#Becoming_a_maintainer_.28developer.29 ~~~ 5. Ask for commit access. * Ask one of the project stewards to authorize your commit access. * If the project steward authorizes you for commit access follow these instructions to create a sourceware account with commit access to the glibc repository. ~~~ Joseph and I are both stewards. "Project stewards (GNU package maintainers)" https://sourceware.org/glibc/wiki/MAINTAINERS#Project_stewards_.28GNU_package_maintainers.29 I would be happy to authorize your commit access. I assume your intent is to be one of the machine maintainers for ARC? > Thx, > -Vineet > > [1] https://sourceware.org/cgi-bin/pdw/ps_form.cgi > -- Cheers, Carlos. ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Re: [PATCH] make-syscalls.sh: fix comment referencing syscall-template
On 1/31/19 8:48 PM, Vineet Gupta wrote: > On 1/31/19 5:45 PM, Carlos O'Donell wrote: >> On 1/31/19 7:16 PM, Vineet Gupta wrote: >>> spotted when started working on ARC port to glibc >>> >>> --- >>> ChangeLog | 5 + >>> sysdeps/unix/make-syscalls.sh | 2 +- >>> 2 files changed, 6 insertions(+), 1 deletion(-) >>> >> Obviously correct :-) > > Changelog is bigger than the fix ;-) > >> Please commit to master which is open for development. >> >> Reviewed-by: Carlos O'Donell > > > I'm not sure if I have access credentials to commit to *the* glibc repo ? > Pushed. Thank you :-) commit d5627550ae99d10dfad216910ffa774f60460123 (HEAD -> master, origin/master, origin/HEAD) Author: Vineet Gupta Date: Thu Jan 31 22:45:10 2019 -0500 make-syscalls.sh: fix comment referencing syscall-template -- Cheers, Carlos. ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Re: [PATCH] make-syscalls.sh: fix comment referencing syscall-template
On 1/31/19 7:16 PM, Vineet Gupta wrote: > spotted when started working on ARC port to glibc > > --- > ChangeLog | 5 + > sysdeps/unix/make-syscalls.sh | 2 +- > 2 files changed, 6 insertions(+), 1 deletion(-) > Obviously correct :-) Please commit to master which is open for development. Reviewed-by: Carlos O'Donell > diff --git a/ChangeLog b/ChangeLog > index 93201b76a26b..8438f93e13a2 100644 > --- a/ChangeLog > +++ b/ChangeLog > @@ -1,3 +1,8 @@ > +2019-01-31 Vineet Gupta > + > + * sysdeps/unix/make-syscalls.sh: Fix comment referencing > + syscall-template file. > + > 2019-01-31 Paul Pluzhnikov > > [BZ #24051] > diff --git a/sysdeps/unix/make-syscalls.sh b/sysdeps/unix/make-syscalls.sh > index e39b2d6d5214..6a5c10d54e87 100644 > --- a/sysdeps/unix/make-syscalls.sh > +++ b/sysdeps/unix/make-syscalls.sh > @@ -7,7 +7,7 @@ > # > # This script is used to process the syscall data encoded in the various > # syscalls.list files to produce thin assembly syscall wrappers around the > -# appropriate OS syscall. See syscall-template.s for more details on the > +# appropriate OS syscall. See syscall-template.S for more details on the > # actual wrapper. > # > # Syscall Signature Prefixes: > -- Cheers, Carlos. ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Re: misc/check-installed-headers-c failing due to upstream kernel change
On 1/23/19 12:13 PM, Vineet Gupta wrote:
> On 1/23/19 8:51 AM, Carlos O'Donell wrote:
>> On 1/23/19 10:57 AM, Ben Hutchings wrote:
>>> On Mon, 2019-01-21 at 14:56 -0800, Vineet Gupta wrote:
>>>> Hi,
>>>>
>>>> It seems a recent upstream kernel change (went in 5.0-rcX) 81c9d43f9487
>>>> ("kernel/sysctl: add panic_print into sysctl") trips one of the glibc
>>>> tests.
>>>>
>>>>FAIL: misc/check-installed-headers-c
>>>>
>>>>> :: sys/sysctl.h
>>>>>
>>>>> *** Obsolete types detected:
>>>>> ~/install/compilers/arc-linux-gnu/sysroot/usr/include/linux /sysctl.h:
>>>>> KERN_PANIC_PRINT=78, /* ulong: bitmask to print system info on panic */
>>>>
>>>> It doesn't seem to like ulong (inside a comment). I don't have enough foo
>>>> to fix
>>>> it, but wanted to bring it to notice anyways.
>>>
>>> This additions looks like a mistake, anyway - Linux's binary sysctl
>>> interface is only there for ancient compatibility and no new sysctls
>>> should be added to this enumeration.
>>
>> Just to be clear, this glibc test failure is a false positive [1], and
>> we're working to correct this [2]. However, if this is also not needed on
>> the kernel side, then that's also OK with us :-)
>>
>
> [1] https://www.sourceware.org/ml/libc-alpha/2019-01/msg00413.html
> [2] https://www.sourceware.org/ml/libc-alpha/2019-01/msg00513.html
>
> Great, I didn't skim thru the mailing list before posting this. So this is
> already
> known and being worked on !
>
> Does it make sense to add the minimal fix for 2.29 ? It is likely in near
> future,
> people using the released glibc with newer kernel will run into this, unless
> kernel folks zap this quickly, within the current release.
I don't think there is any rush. Review [2] and give Zack any feedback
on correctness? We commit to master, and backport to the release branch
for 2.29 when ready. Developers should be using the release branches.
Distributions already use the release branches to get continued security
fixes and bug fixes.
--
Cheers,
Carlos.
___
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
