Need for arch pthread-offsets.h (was Re: [PATCH v2 05/15] ARC: Atomics and Locking primitives)

2019-01-31 Thread Vineet Gupta 
On 1/30/19 9:40 AM, Vineet Gupta wrote:
> On 1/30/19 12:28 AM, Andreas Schwab wrote:
>> On Jan 29 2019, Vineet Gupta  wrote:
>>
>>> +#define __PTHREAD_MUTEX_NUSERS_AFTER_KIND  1
>>> +#define __PTHREAD_MUTEX_USE_UNION  1
>> New ports should use the preferred values for these macros.
> 
> OK, changed to 0 and 0 per commit 06be6368da16104 ("nptl: Define
> __PTHREAD_MUTEX_{NUSERS_AFTER_KIND,USE_UNION}")

So this required a bunch of tricking changes to _SIZEOF_PTHREAD_*.

However what was not obvious is adjustment to
sysdeps//nptl/pthread-offsets.h to __PTHREAD_MUTEX_*_OFFSET. But these 
don't
seem to be *actually* used anywhere. Sure there are assert checks in
pthread_mutext_init.c but what's the point: the struct is generic anyways. IOW 
I'm
not sure what port specific errors/inconsistency they are catching, other than 
the
fact that they need to be hand calculating when starting a new port.

Am I missing something ?

___
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc

Re: Need for arch pthread-offsets.h (was Re: [PATCH v2 05/15] ARC: Atomics and Locking primitives)

2019-02-04 Thread Andreas Schwab 
On Jan 31 2019, Vineet Gupta  wrote:

> However what was not obvious is adjustment to
> sysdeps//nptl/pthread-offsets.h to __PTHREAD_MUTEX_*_OFFSET. But these 
> don't
> seem to be *actually* used anywhere. Sure there are assert checks in
> pthread_mutext_init.c but what's the point: the struct is generic anyways. 
> IOW I'm
> not sure what port specific errors/inconsistency they are catching, other 
> than the
> fact that they need to be hand calculating when starting a new port.
>
> Am I missing something ?

The _OFFSET macros are for ensuring binary compatibility.

Andreas.

-- 
Andreas Schwab, SUSE Labs, sch...@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

___
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc