RE: [U-Boot] [RFC PATCH] net: designware: drop compatible altr, socfpga-stmmac
From: Alexey Brodkin Date: Sep/04/2019, 06:59:01 (UTC+00:00) > Hi Joe, > > > -Original Message- > > From: Joe Hershberger > > Sent: Wednesday, September 4, 2019 1:10 AM > > To: Alexey Brodkin > > Cc: Ralph Siemsen ; Joseph Hershberger > > ; u- > > b...@lists.denx.de; linux-snps-arc@lists.infradead.org; Eugeniy Paltsev > > > > Subject: Re: [U-Boot] [RFC PATCH] net: designware: drop compatible altr, > > socfpga-stmmac > > > > On Tue, Aug 20, 2019 at 3:07 AM Alexey Brodkin > > wrote: > > > > > > Hi Ralph, > > > > > > > -Original Message- > > > > From: Ralph Siemsen > > > > Sent: Monday, August 19, 2019 9:43 PM > > > > To: u-b...@lists.denx.de; Joe Hershberger ; > > > > Alexey Brodkin > > > > ; Vlad Zakharov > > > > Cc: Ralph Siemsen > > > > Subject: [RFC PATCH] net: designware: drop compatible > > > > altr,socfpga-stmmac > > > > > > > > The same compatible = "altr,socfpga-stmmac" appears in both > > > > drivers/net/designware.c and drivers/net/dwmac_socfgpa.c, > > > > creating ambiguity in which driver will be bound. > > > > > > > > For Intel/Altera SoC devices, dwmac_socfpga.c is the correct driver. > > > > So drop the compatible string from designware.c. > > > > > > > > Signed-off-by: Ralph Siemsen > > > > --- > > > > This compatible string also appears in: axs10x_mb.dtsi and hsdk.dts. > > > > Maintainers of those boards have been copied, kindly review. > > > > > > Thanks for this clean-up. > > > > > > Speaking about AXS10x board where we do have DW GMAC > > > I cannot recall the reason I chose to use "altr,socfpga-stmmac" > > > for the board here [1] 3 years ago. > > > > > > But given we don't have any special quirks implemented whatever > > > is the most generic DW GMAC compatible string is should be good for us. > > > > > > Joe, could you please suggest if we need to use just "st,stm32-dwmac" > > > or add our own compatible as the ASIC is not from ST obviously but > > > an FPGA with Synopsys ARC SoC? > > > > I think we should only be using what Linux does, so I'm afraid I have > > to defer to what exists in the DTs there. > > In the Linux kernel we use "snps,dwmac", see [1]. > But maybe we need to switch to "snps,dwmac-3.70a" even as what we really have > is 3.73a. > > While in U-Boot we don't have either one, the most generic is > "st,stm32-dwmac", see [2]. > So maybe we want to add at least "snps,dwmac". > > @Jose Abreu could you please confirm if "snps,dwmac-3.70a" is OK for GMAC IP > v3.73a? Yes it should be okay. > > [1] > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arc/boot/dts/axs10x_mb.dtsi#n74 > [2] > https://gitlab.denx.de/u-boot/u-boot/blob/master/drivers/net/designware.c#L855 > > -Alexey --- Thanks, Jose Miguel Abreu ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
RE: [U-Boot] [RFC PATCH] net: designware: drop compatible altr, socfpga-stmmac
Hi Joe, > -Original Message- > From: Joe Hershberger > Sent: Wednesday, September 4, 2019 1:10 AM > To: Alexey Brodkin > Cc: Ralph Siemsen ; Joseph Hershberger > ; u- > b...@lists.denx.de; linux-snps-arc@lists.infradead.org; Eugeniy Paltsev > > Subject: Re: [U-Boot] [RFC PATCH] net: designware: drop compatible altr, > socfpga-stmmac > > On Tue, Aug 20, 2019 at 3:07 AM Alexey Brodkin > wrote: > > > > Hi Ralph, > > > > > -Original Message- > > > From: Ralph Siemsen > > > Sent: Monday, August 19, 2019 9:43 PM > > > To: u-b...@lists.denx.de; Joe Hershberger ; > > > Alexey Brodkin > > > ; Vlad Zakharov > > > Cc: Ralph Siemsen > > > Subject: [RFC PATCH] net: designware: drop compatible altr,socfpga-stmmac > > > > > > The same compatible = "altr,socfpga-stmmac" appears in both > > > drivers/net/designware.c and drivers/net/dwmac_socfgpa.c, > > > creating ambiguity in which driver will be bound. > > > > > > For Intel/Altera SoC devices, dwmac_socfpga.c is the correct driver. > > > So drop the compatible string from designware.c. > > > > > > Signed-off-by: Ralph Siemsen > > > --- > > > This compatible string also appears in: axs10x_mb.dtsi and hsdk.dts. > > > Maintainers of those boards have been copied, kindly review. > > > > Thanks for this clean-up. > > > > Speaking about AXS10x board where we do have DW GMAC > > I cannot recall the reason I chose to use "altr,socfpga-stmmac" > > for the board here [1] 3 years ago. > > > > But given we don't have any special quirks implemented whatever > > is the most generic DW GMAC compatible string is should be good for us. > > > > Joe, could you please suggest if we need to use just "st,stm32-dwmac" > > or add our own compatible as the ASIC is not from ST obviously but > > an FPGA with Synopsys ARC SoC? > > I think we should only be using what Linux does, so I'm afraid I have > to defer to what exists in the DTs there. In the Linux kernel we use "snps,dwmac", see [1]. But maybe we need to switch to "snps,dwmac-3.70a" even as what we really have is 3.73a. While in U-Boot we don't have either one, the most generic is "st,stm32-dwmac", see [2]. So maybe we want to add at least "snps,dwmac". @Jose Abreu could you please confirm if "snps,dwmac-3.70a" is OK for GMAC IP v3.73a? [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arc/boot/dts/axs10x_mb.dtsi#n74 [2] https://gitlab.denx.de/u-boot/u-boot/blob/master/drivers/net/designware.c#L855 -Alexey ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
Re: [U-Boot] [RFC PATCH] net: designware: drop compatible altr, socfpga-stmmac
On Tue, Aug 20, 2019 at 3:07 AM Alexey Brodkin wrote: > > Hi Ralph, > > > -Original Message- > > From: Ralph Siemsen > > Sent: Monday, August 19, 2019 9:43 PM > > To: u-b...@lists.denx.de; Joe Hershberger ; Alexey > > Brodkin > > ; Vlad Zakharov > > Cc: Ralph Siemsen > > Subject: [RFC PATCH] net: designware: drop compatible altr,socfpga-stmmac > > > > The same compatible = "altr,socfpga-stmmac" appears in both > > drivers/net/designware.c and drivers/net/dwmac_socfgpa.c, > > creating ambiguity in which driver will be bound. > > > > For Intel/Altera SoC devices, dwmac_socfpga.c is the correct driver. > > So drop the compatible string from designware.c. > > > > Signed-off-by: Ralph Siemsen > > --- > > This compatible string also appears in: axs10x_mb.dtsi and hsdk.dts. > > Maintainers of those boards have been copied, kindly review. > > Thanks for this clean-up. > > Speaking about AXS10x board where we do have DW GMAC > I cannot recall the reason I chose to use "altr,socfpga-stmmac" > for the board here [1] 3 years ago. > > But given we don't have any special quirks implemented whatever > is the most generic DW GMAC compatible string is should be good for us. > > Joe, could you please suggest if we need to use just "st,stm32-dwmac" > or add our own compatible as the ASIC is not from ST obviously but > an FPGA with Synopsys ARC SoC? I think we should only be using what Linux does, so I'm afraid I have to defer to what exists in the DTs there. -Joe > [1] > https://gitlab.denx.de/u-boot/u-boot/commit/fb2dea60e8f355ae00d427db09112a90839c96ec > > -Alexey > ___ > U-Boot mailing list > u-b...@lists.denx.de > https://lists.denx.de/listinfo/u-boot ___ linux-snps-arc mailing list linux-snps-arc@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-snps-arc
