Re: static inline math functions (was Re: [PATCH v6 06/13] ARC: hardware floating point support)

2020-06-02 Thread Adhemerval Zanella



On 02/06/2020 15:13, Joseph Myers wrote:
> On Tue, 2 Jun 2020, Vineet Gupta via Libc-alpha wrote:
> 
>> Thi s approach seems to trip math/check-installed-headers.out
>>
>>
>>  -std=c89
>> In file included from ../include/fpu_control.h:2,
>> from /tmp/cih_test_Nknxdp.c:8:
>> ../sysdeps/arc/fpu_control.h:82:14: error: expected ';' before 'unsigned'
>> 82 | static inline unsigned int arc_fpu_getcw(void)
>>
>>
>> Any tips ?
> 
> Installed headers have to use __inline instead of inline to work in C90 
> mode.
> 

Do we need to export _FPU_{GET,SET}CW macros? Otherwise we remove it and
move the fp hardware control register to an internal definition?

___
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc


Re: static inline math functions (was Re: [PATCH v6 06/13] ARC: hardware floating point support)

2020-06-02 Thread Joseph Myers
On Tue, 2 Jun 2020, Vineet Gupta via Libc-alpha wrote:

> Thi s approach seems to trip math/check-installed-headers.out
> 
> 
>  -std=c89
> In file included from ../include/fpu_control.h:2,
> from /tmp/cih_test_Nknxdp.c:8:
> ../sysdeps/arc/fpu_control.h:82:14: error: expected ';' before 'unsigned'
> 82 | static inline unsigned int arc_fpu_getcw(void)
> 
> 
> Any tips ?

Installed headers have to use __inline instead of inline to work in C90 
mode.

-- 
Joseph S. Myers
jos...@codesourcery.com

___
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc