[linux-sunxi] [PATCH v2] ARM: dts: sun8i: h3: Fix Pincrtl bindings on Bananapi M2 Plus

2017-09-05 Thread Philipp Rossak 
From: Philipp Rossak 

There is no need for pincontrol nodes when the pin is set to a GPIO

Signed-off-by: Philipp Rossak 
---
This is Patch is a new version of the following patch:
https://patchwork.kernel.org/patch/9934835/


changes since version 1:
* vqmmc-supply was added again
* The pincontrolers for the leds and gpio_keys were removed

 arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts | 20 
 1 file changed, 20 deletions(-)

diff --git a/arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts 
b/arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts
index d756ff8..cc20d67 100644
--- a/arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts
+++ b/arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts
@@ -64,7 +64,6 @@
leds {
compatible = "gpio-leds";
pinctrl-names = "default";
-   pinctrl-0 = <_led_bpi_m2p>;
 
pwr_led {
label = "bananapi-m2-plus:red:pwr";
@@ -76,7 +75,6 @@
gpio_keys {
compatible = "gpio-keys";
pinctrl-names = "default";
-   pinctrl-0 = <_r_bpi_m2p>;
 
sw4 {
label = "power";
@@ -98,7 +96,6 @@
wifi_pwrseq: wifi_pwrseq {
compatible = "mmc-pwrseq-simple";
pinctrl-names = "default";
-   pinctrl-0 = <_en_bpi_m2p>;
reset-gpios = <_pio 0 7 GPIO_ACTIVE_LOW>; /* PL7 */
};
 };
@@ -190,23 +187,6 @@
status = "okay";
 };
 
-_pio {
-   pwr_led_bpi_m2p: led_pins@0 {
-   pins = "PL10";
-   function = "gpio_out";
-   };
-
-   sw_r_bpi_m2p: key_pins@0 {
-   pins = "PL3";
-   function = "gpio_in";
-   };
-
-   wifi_en_bpi_m2p: wifi_en_pin {
-   pins = "PL7";
-   function = "gpio_out";
-   };
-};
-
 _usb0_vbus {
gpio = < 3 11 GPIO_ACTIVE_HIGH>; /* PD11 */
status = "okay";
-- 
2.7.4

-- 
You received this message because you are subscribed to the Google Groups 
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to linux-sunxi+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[linux-sunxi] Re: [PATCH v8] arm64: allwinner: h5: add NanoPi NEO Plus2 DT support

2017-09-05 Thread Maxime Ripard 
Hi Antony,

Almost good, I'm sorry I missed a few things before.

On Mon, Sep 04, 2017 at 04:30:14PM +0200, Antony Antony wrote:
> + {
> + pinctrl-names = "default";
> + pinctrl-0 = <_pins_a>;
> + vmmc-supply = <_vcc3v3>;
> + vqmmc-supply = <_vcc3v3>;
> + mmc-pwrseq = <_pwrseq>;
> + bus-width = <4>;
> + non-removable;
> + status = "okay";

Please add a new line here.

> + brcmf: wifi@1 {
> + reg = <1>;
> + compatible = "brcm";

This should be the actual compatible, not just the vendor.

> + };
> +};
> +
> + {
> + pinctrl-names = "default";
> + pinctrl-0 = <_8bit_pins>;
> + vmmc-supply = <_vcc3v3>;
> + bus-width = <8>;
> + non-removable;
> + cap-mmc-hw-reset;
> + boot_device = <0>;

that property should still be removed.

> +_pio {
> + leds_r_npi: led_pins@0 {
> + pins = "PL10";
> + function = "gpio_out";
> + };
> +
> + vdd_cpux_r_npi: regulator_pins@0 {
> + allwinner,pins = "PL6";
> + allwinner,function = "gpio_out";
> + allwinner,drive = ;
> + allwinner,pull = ;
> + };
> +};

And these must be left out.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

-- 
You received this message because you are subscribed to the Google Groups 
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to linux-sunxi+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


signature.asc
Description: PGP signature

[linux-sunxi] Re: [PATCH v5] arm64: allwinner: h5: add support for NanoPi NEO Plus2

2017-09-05 Thread Maxime Ripard 
Hi Antony,

On Mon, Sep 04, 2017 at 04:26:19PM +0200, Antony Antony wrote:
> On Mon, Sep 04, 2017 at 10:27:32AM +0200, Maxime Ripard wrote:
> > On Fri, Sep 01, 2017 at 12:53:13PM +0200, Antony Antony wrote:
> > > > > + {
> > > > > + pinctrl-names = "default";
> > > > > + pinctrl-0 = <_rgmii_pins>;
> > > > > + phy-supply = <_gmac_3v3>;
> > > > > + phy-handle = <_rgmii_phy>;
> > > > > + phy-mode = "rgmii";
> > > > > + status = "okay";
> > > > > +};
> > > > > +
> > > > > + {
> > > > > + ext_rgmii_phy: ethernet-phy@7 {
> > > > > + compatible = "ethernet-phy-ieee802.3-c22";
> > > > > + reg = <7>;
> > > > > + };
> > > > > +};
> > > > 
> > > > This will not compile.
> > > 
> > > I don't understand you, because, v5 file compiled for me. Here is output 
> > > from running system, just the relevant part.  using dtc -I fs 
> > > /proc/device-tree
> > > 
> > > ext_rgmii_phy = "/soc/ethernet@1c3/mdio/ethernet-phy@7";
> > > 
> > > ethernet@1c3 {
> > >   mdio {
> > >   ..
> > >   ethernet-phy@7 {
> > >   compatible = "ethernet-phy-ieee802.3-c22";
> > >   phandle = <0x1c>;
> > >   reg = <0x7>;
> > >   linux,phandle = <0x1c>;
> > >   };
> > > };
> > > 
> > > Is this what you expect?
> > 
> > The bindings have been reverted recently, so if you based your work on
> > a version between 4.13-rc1 and 4.13-rc6 it will work, but anything
> > more recent will not compile anymore.
> 
> I deleted emc and related node.
> I see. I hope stmmac: sun8i come back soon. It works well well on this 
> board, running 4.13-rc6

Yeah, I hope too. Unfortunately, the DT bindings were still under
discussion after it's been merged, so we couldn't guarantee their
stability in the future.

> > > > > +_otg {
> > > > > + dr_mode = "host";
> > > > > + status = "okay";
> > > > > +};
> > > > > +
> > > > > + {
> > > > > + /* USB Type-A ports' VBUS is always on */
> > > > > + usb0_id_det-gpios = < 6 12 GPIO_ACTIVE_HIGH>; /* PG12 */
> > > > 
> > > > If it has an ID-detect pin, then it's not a host-only USB OTG
> > > > controller. dr_mode should be set to otga 
> > > 
> > > good point. I don't see an ID-detect connected in the schematic. The 
> > > previous generation had. 
> > > 
> > > I will leave 
> > > _otg {
> > >   dr_mode = "host";
> > >   status = "okay";
> > > };
> > > 
> > >  {
> > >   /* USB Type-A ports' VBUS is always on */
> > >   status = "okay";
> > > };
> > 
> > Looking at the schematics, it seems that the micro USB isn't even
> > wired to a bus but is only used to power the board. If so, you can
> > even remove the usb_otg node.
> 
> Yes, the Micro USB data pins are not connected. However, it there is a 
> second USB A port connected to the processor. If I remove _otg node, in 
> 4.13-rc6, the second port goes to disabled.

Ok, someone got creative :)

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

-- 
You received this message because you are subscribed to the Google Groups 
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to linux-sunxi+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


signature.asc
Description: PGP signature

Re: [linux-sunxi][PATCH v2] ARM: dts: sunxi: h3/h5 :Add DAI nodes

2017-09-05 Thread Maxime Ripard 
On Mon, Sep 04, 2017 at 07:47:21PM +0200, codekip...@gmail.com wrote:
> From: Marcus Cooper 
> 
> Add the new DAI blocks to the device tree. I2S0 and I2S1 are for
> connecting to an external codec.
> 
> Signed-off-by: Marcus Cooper 

Applied, thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

-- 
You received this message because you are subscribed to the Google Groups 
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to linux-sunxi+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


signature.asc
Description: PGP signature