Re: [linux-sunxi] [PATCH u-boot-sunxi] sunxi: axp152: dcdc3 scale is 50mV / step not 25mV / step
Hi,
On 11/23/2014 07:23 PM, Siarhei Siamashka wrote:
On Mon, 13 Oct 2014 14:54:45 +0200
Hans de Goede wrote:
Currently uboot wrongly uses 25mV / step for dcdc3, this is a copy and paste
error introduced when adding the axp152_mvolt_to_target during review of the
axp152.c driver. This results in u-boot setting Vddr to 2.3V instead of 1.5V.
This commit fixes this.
Signed-off-by: Hans de Goede
---
drivers/power/axp152.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/axp152.c b/drivers/power/axp152.c
index fa4ea05..27c2c4c 100644
--- a/drivers/power/axp152.c
+++ b/drivers/power/axp152.c
@@ -62,7 +62,7 @@ int axp152_set_dcdc2(int mvolt)
int axp152_set_dcdc3(int mvolt)
{
- u8 target = axp152_mvolt_to_target(mvolt, 700, 3500, 25);
+ u8 target = axp152_mvolt_to_target(mvolt, 700, 3500, 50);
return axp152_write(AXP152_DCDC3_VOLTAGE, target);
}
I have no hardware with AXP152 PMIC myself, but based on
http://irclog.whitequark.org/linux-sunxi/2014-10-20#10571381
we got Tested-by: Michal Suchanek
This patch fixes a regression introduced by the axp code cleanups did a
while back. The regression causes the DRAM voltage to be set to 2.3V
instead of 1.5V, this patch fixes this.
Please apply this to linux-sunxi/u-boot-sunxi ASAP.
You seem to have commit access to https://github.com/linux-sunxi/u-boot-sunxi
Is there any reason why this regression fix has not been pushed
there yet?
When I posted it I was traveling, and I only had upstream u-boot sources on
my laptop, since I knew that u-boot-sunxi has the same issue, I simply did
a git-send-email with the upstream patch to the linux-sunxi list, assuming
someone would quickly pick this important fix up...
Anyways I've pushed it now.
Regards,
Hans
--
You received this message because you are subscribed to the Google Groups
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to linux-sunxi+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Re: [linux-sunxi] [PATCH u-boot-sunxi] sunxi: axp152: dcdc3 scale is 50mV / step not 25mV / step
On Mon, 13 Oct 2014 14:54:45 +0200
Hans de Goede wrote:
> Currently uboot wrongly uses 25mV / step for dcdc3, this is a copy and paste
> error introduced when adding the axp152_mvolt_to_target during review of the
> axp152.c driver. This results in u-boot setting Vddr to 2.3V instead of 1.5V.
>
> This commit fixes this.
>
> Signed-off-by: Hans de Goede
> ---
> drivers/power/axp152.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/axp152.c b/drivers/power/axp152.c
> index fa4ea05..27c2c4c 100644
> --- a/drivers/power/axp152.c
> +++ b/drivers/power/axp152.c
> @@ -62,7 +62,7 @@ int axp152_set_dcdc2(int mvolt)
>
> int axp152_set_dcdc3(int mvolt)
> {
> - u8 target = axp152_mvolt_to_target(mvolt, 700, 3500, 25);
> + u8 target = axp152_mvolt_to_target(mvolt, 700, 3500, 50);
>
> return axp152_write(AXP152_DCDC3_VOLTAGE, target);
> }
I have no hardware with AXP152 PMIC myself, but based on
http://irclog.whitequark.org/linux-sunxi/2014-10-20#10571381
we got Tested-by: Michal Suchanek
> This patch fixes a regression introduced by the axp code cleanups did a
> while back. The regression causes the DRAM voltage to be set to 2.3V
> instead of 1.5V, this patch fixes this.
>
> Please apply this to linux-sunxi/u-boot-sunxi ASAP.
You seem to have commit access to https://github.com/linux-sunxi/u-boot-sunxi
Is there any reason why this regression fix has not been pushed
there yet?
--
Best regards,
Siarhei Siamashka
--
You received this message because you are subscribed to the Google Groups
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to linux-sunxi+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[linux-sunxi] [PATCH u-boot-sunxi] sunxi: axp152: dcdc3 scale is 50mV / step not 25mV / step
Currently uboot wrongly uses 25mV / step for dcdc3, this is a copy and paste
error introduced when adding the axp152_mvolt_to_target during review of the
axp152.c driver. This results in u-boot setting Vddr to 2.3V instead of 1.5V.
This commit fixes this.
Signed-off-by: Hans de Goede
---
drivers/power/axp152.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/axp152.c b/drivers/power/axp152.c
index fa4ea05..27c2c4c 100644
--- a/drivers/power/axp152.c
+++ b/drivers/power/axp152.c
@@ -62,7 +62,7 @@ int axp152_set_dcdc2(int mvolt)
int axp152_set_dcdc3(int mvolt)
{
- u8 target = axp152_mvolt_to_target(mvolt, 700, 3500, 25);
+ u8 target = axp152_mvolt_to_target(mvolt, 700, 3500, 50);
return axp152_write(AXP152_DCDC3_VOLTAGE, target);
}
--
2.1.0
--
You received this message because you are subscribed to the Google Groups
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to linux-sunxi+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
