[linux-sunxi] Re: [PATCH 1/2] ARM: sunxi: Split the various SoCs support in Kconfig

2014-04-28 Thread Arnd Bergmann
On Saturday 26 April 2014 18:16:53 Maxime Ripard wrote:
 This will allow to better isolate various options, and reduce the overall
 kernel size if we're interested in only one of the SoCs.
 
 Signed-off-by: Maxime Ripard maxime.rip...@free-electrons.com

Looks good, just one small request:


 diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig
 index b57d7d53b9d3..23575010ff49 100644
 --- a/arch/arm/mach-sunxi/Kconfig
 +++ b/arch/arm/mach-sunxi/Kconfig
 @@ -1,14 +1,37 @@
  config ARCH_SUNXI
 -   bool Allwinner A1X SOCs if ARCH_MULTI_V7
 -   select ARCH_HAS_RESET_CONTROLLER
 +   bool Allwinner SoCs if ARCH_MULTI_V7
 select ARCH_REQUIRE_GPIOLIB
 -   select ARM_GIC
 -   select ARM_PSCI
 select CLKSRC_MMIO
 select GENERIC_IRQ_CHIP
 -   select HAVE_ARM_ARCH_TIMER
 select PINCTRL
 select PINCTRL_SUNXI
 -   select RESET_CONTROLLER
 select SUN4I_TIMER

Please make this 'menuconfig' instead of 'config', so it shows up as
only one line in the main menu. I would like to do this for all platforms
that have sub-options eventually.

Arnd

-- 
You received this message because you are subscribed to the Google Groups 
linux-sunxi group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to linux-sunxi+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[linux-sunxi] Re: [PATCH 1/2] ARM: sunxi: Split the various SoCs support in Kconfig

2014-04-28 Thread Maxime Ripard
On Mon, Apr 28, 2014 at 08:07:38PM +0200, Arnd Bergmann wrote:
 On Saturday 26 April 2014 18:16:53 Maxime Ripard wrote:
  This will allow to better isolate various options, and reduce the overall
  kernel size if we're interested in only one of the SoCs.
  
  Signed-off-by: Maxime Ripard maxime.rip...@free-electrons.com
 
 Looks good, just one small request:
 
 
  diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig
  index b57d7d53b9d3..23575010ff49 100644
  --- a/arch/arm/mach-sunxi/Kconfig
  +++ b/arch/arm/mach-sunxi/Kconfig
  @@ -1,14 +1,37 @@
   config ARCH_SUNXI
  -   bool Allwinner A1X SOCs if ARCH_MULTI_V7
  -   select ARCH_HAS_RESET_CONTROLLER
  +   bool Allwinner SoCs if ARCH_MULTI_V7
  select ARCH_REQUIRE_GPIOLIB
  -   select ARM_GIC
  -   select ARM_PSCI
  select CLKSRC_MMIO
  select GENERIC_IRQ_CHIP
  -   select HAVE_ARM_ARCH_TIMER
  select PINCTRL
  select PINCTRL_SUNXI
  -   select RESET_CONTROLLER
  select SUN4I_TIMER
 
 Please make this 'menuconfig' instead of 'config', so it shows up as
 only one line in the main menu. I would like to do this for all platforms
 that have sub-options eventually.

Ok, sure, I'll send a v2 with Olof comments as well.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


signature.asc
Description: Digital signature