Re: [linux-sunxi] Re: [PATCH 4/7] sunxi: Add CONFIG_MACPWR option
Hi, On 07/28/2014 09:48 AM, Ian Campbell wrote: > On Sun, 2014-07-27 at 23:25 +0200, Hans de Goede wrote: >> On some boards the phy needs to be powered up through a gpio, add support for >> this. > > I assume from the context that this is the Ethernet PHY? Yes, I'll amend the commit msg before pushing. > > I'm a bit surprised there isn't some sort of de facto existing naming > etc for something like this, but if there is my grep's aren't finding it > so: >> Signed-off-by: Hans de Goede > > Acked-by: Ian Campbell Regards, Hans -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [linux-sunxi] Re: [PATCH 4/7] sunxi: Add CONFIG_MACPWR option
On Mon, 2014-07-28 at 15:51 +0800, Chen-Yu Tsai wrote: > On Mon, Jul 28, 2014 at 3:48 PM, Ian Campbell wrote: > > On Sun, 2014-07-27 at 23:25 +0200, Hans de Goede wrote: > >> On some boards the phy needs to be powered up through a gpio, add support > >> for > >> this. > > > > I assume from the context that this is the Ethernet PHY? > > > > I'm a bit surprised there isn't some sort of de facto existing naming > > etc for something like this, but if there is my grep's aren't finding it > > so: > > My guess would be most other platforms have separate board files > for each board they support, instead of our mixed approach. > > They can just put whatever GPIO poking stuff in them under one of the > standard weak symbols. Yes, that sounds very plausible. > > >> Signed-off-by: Hans de Goede > > > > Acked-by: Ian Campbell > -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [linux-sunxi] Re: [PATCH 4/7] sunxi: Add CONFIG_MACPWR option
On Mon, Jul 28, 2014 at 3:48 PM, Ian Campbell wrote: > On Sun, 2014-07-27 at 23:25 +0200, Hans de Goede wrote: >> On some boards the phy needs to be powered up through a gpio, add support for >> this. > > I assume from the context that this is the Ethernet PHY? > > I'm a bit surprised there isn't some sort of de facto existing naming > etc for something like this, but if there is my grep's aren't finding it > so: My guess would be most other platforms have separate board files for each board they support, instead of our mixed approach. They can just put whatever GPIO poking stuff in them under one of the standard weak symbols. >> Signed-off-by: Hans de Goede > > Acked-by: Ian Campbell -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[linux-sunxi] Re: [PATCH 4/7] sunxi: Add CONFIG_MACPWR option
On Sun, 2014-07-27 at 23:25 +0200, Hans de Goede wrote: > On some boards the phy needs to be powered up through a gpio, add support for > this. I assume from the context that this is the Ethernet PHY? I'm a bit surprised there isn't some sort of de facto existing naming etc for something like this, but if there is my grep's aren't finding it so: > Signed-off-by: Hans de Goede Acked-by: Ian Campbell -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.