[linux-sunxi] Re: [PATCH v4 2/2] ohci-platform: Add support for controllers with multiple reset lines
Hi Hans, [auto build test ERROR on robh/for-next] [also build test ERROR on v4.5-rc6 next-20160304] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Hans-de-Goede/hci-platform-Add-support-for-controllers-with-more-then-one-reset-line/20160228-010130 base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux for-next config: x86_64-randconfig-s5-03060621 (attached as .config) reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): drivers/usb/host/ohci-platform.c: In function 'ohci_platform_probe': >> drivers/usb/host/ohci-platform.c:201:5: error: implicit declaration of >> function 'devm_reset_control_get_shared_by_index' >> [-Werror=implicit-function-declaration] devm_reset_control_get_shared_by_index( ^ drivers/usb/host/ohci-platform.c:200:22: warning: assignment makes pointer from integer without a cast [-Wint-conversion] priv->resets[rst] = ^ cc1: some warnings being treated as errors vim +/devm_reset_control_get_shared_by_index +201 drivers/usb/host/ohci-platform.c 195 priv->clks[clk] = NULL; 196 break; 197 } 198 } 199 for (rst = 0; rst < OHCI_MAX_RESETS; rst++) { 200 priv->resets[rst] = > 201 devm_reset_control_get_shared_by_index( 202 &dev->dev, rst); 203 if (IS_ERR(priv->resets[rst])) { 204 err = PTR_ERR(priv->resets[rst]); --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. .config.gz Description: Binary data
[linux-sunxi] Re: [PATCH v4 2/2] ohci-platform: Add support for controllers with multiple reset lines
On Sat, Feb 27, 2016 at 05:58:59PM +0100, Hans de Goede wrote: > At least the EHCI/OHCI found on the Allwinnner H3 SoC needs multiple > reset lines, the controller will not initialize while the reset for > its companion is still asserted, which means we need to de-assert > 2 resets for the controller to work. > > Signed-off-by: Hans de Goede > Acked-by: Alan Stern > --- > Changes in v2: > -New patch in v2 of this patch-set, to complement the identical patch for > the ehci-platform code > Changes in v3: > -Adjust for changes to shared-reset reset-controller functions > Changes in v4: > -Fix Ugly continuation line > --- > Documentation/devicetree/bindings/usb/usb-ohci.txt | 2 +- Acked-by: Rob Herring > drivers/usb/host/ohci-platform.c | 43 > -- > 2 files changed, 24 insertions(+), 21 deletions(-) -- You received this message because you are subscribed to the Google Groups "linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.