[linux-sunxi] Re: [PATCH v9 05/17] ARM: dts: sun4i: Add pin-muxing info for the mmc0 controller
Hi Hans,
On Sat, Apr 26, 2014 at 12:16:09PM +0200, Hans de Goede wrote:
> mmc0 is the only controller actually being used on boards, so limit the
> pin-muxing options to that.
>
> Signed-off-by: Hans de Goede
> ---
> arch/arm/boot/dts/sun4i-a10.dtsi | 14 ++
> 1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi
> b/arch/arm/boot/dts/sun4i-a10.dtsi
> index dce074b..29fd4f5 100644
> --- a/arch/arm/boot/dts/sun4i-a10.dtsi
> +++ b/arch/arm/boot/dts/sun4i-a10.dtsi
> @@ -565,6 +565,20 @@
> allwinner,drive = <0>;
> allwinner,pull = <0>;
> };
> +
> + mmc0_pins_a: mmc0@0 {
> + allwinner,pins =
> "PF0","PF1","PF2","PF3","PF4","PF5";
> + allwinner,function = "mmc0";
> + allwinner,drive = <2>;
> + allwinner,pull = <0>;
> + };
> +
> + mmc0_cd_pin_a: mmc0_cd_pin@0 {
> + allwinner,pins = "PH1";
> + allwinner,function = "gpio_in";
> + allwinner,drive = <0>;
> + allwinner,pull = <1>;
> + };
Actually, I like very much the reference_pin mention you had in your
bindings documentation. Could you use it for this and the other
patches?
Thanks,
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
signature.asc
Description: Digital signature
[linux-sunxi] Re: [PATCH v9 05/17] ARM: dts: sun4i: Add pin-muxing info for the mmc0 controller
Hi,
On 04/28/2014 09:32 PM, Maxime Ripard wrote:
> Hi Hans,
>
> On Sat, Apr 26, 2014 at 12:16:09PM +0200, Hans de Goede wrote:
>> mmc0 is the only controller actually being used on boards, so limit the
>> pin-muxing options to that.
>>
>> Signed-off-by: Hans de Goede
>> ---
>> arch/arm/boot/dts/sun4i-a10.dtsi | 14 ++
>> 1 file changed, 14 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi
>> b/arch/arm/boot/dts/sun4i-a10.dtsi
>> index dce074b..29fd4f5 100644
>> --- a/arch/arm/boot/dts/sun4i-a10.dtsi
>> +++ b/arch/arm/boot/dts/sun4i-a10.dtsi
>> @@ -565,6 +565,20 @@
>> allwinner,drive = <0>;
>> allwinner,pull = <0>;
>> };
>> +
>> +mmc0_pins_a: mmc0@0 {
>> +allwinner,pins =
>> "PF0","PF1","PF2","PF3","PF4","PF5";
>> +allwinner,function = "mmc0";
>> +allwinner,drive = <2>;
>> +allwinner,pull = <0>;
>> +};
>> +
>> +mmc0_cd_pin_a: mmc0_cd_pin@0 {
>> +allwinner,pins = "PH1";
>> +allwinner,function = "gpio_in";
>> +allwinner,drive = <0>;
>> +allwinner,pull = <1>;
>> +};
>
> Actually, I like very much the reference_pin mention you had in your
> bindings documentation. Could you use it for this and the other
> patches?
Ok will fix this up for the next version.
Regards,
Hans
--
You received this message because you are subscribed to the Google Groups
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to linux-sunxi+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
[linux-sunxi] Re: [PATCH v9 05/17] ARM: dts: sun4i: Add pin-muxing info for the mmc0 controller
Hi > Ok will fix this up for the next version. Be carefull! I removed redundancies on all the boards I've seen so far, which all had the same pin assignment, based on the reference design of Allwinners. Please make sure the boards pin muxing fits onto your board. Certain boards differ within their muxing. br -- David Lanzendörfer OpenSourceSupport GmbH System engineer and supporter http://www.o2s.ch/ signature.asc Description: This is a digitally signed message part.
