Re: [linux-sunxi] Re: BUG - Bananapi USB not working on Mainline

2015-12-27 Thread Maxime Ripard
Hi,

On Tue, Dec 22, 2015 at 06:42:07AM -0800, m.silentcr...@gmail.com wrote:
> Am Sonntag, 20. Dezember 2015 08:38:52 UTC+1 schrieb David Tulloh:
> > On 20 December 2015 at 08:39,   wrote:
> > 
> > I found the solution! The problem is CONFIG_AXP20X_POWER which was
> > introduced in 4.4-rc1 but defaults to no and not set in
> > sunxi_defconfig. Adding CONFIG_AXP20X_POWER=y to sunxi_defconfig
> > solves that and get's my USB devices working again on linux
> > 4.4-rc5. I actually brought that up on IRC once, but at that time
> > nobody seemed to know so I forgot it again.
> > 
> > Thanks Timo,
> > 
> > I can confirm that adding CONFIG_AXP20X_POWER=y to sunxi_defconfig
> > works for me as well.
> 
> Is this considered an issue worthwhile to be addressed before the
> release of 4.4?
> 
> The way I see it is that USB support is broken on A10/20 in mainline
> for anybody who builds on sunxi_defconfig or multi_v7_defconfig at
> the moment.

I don't consider it a "release blocker". The defconfig is just what it
says: a default configuration. It's not a one-size-fits-all
configuration.

> I think we should either have CONFIG_PHY_SUN4I_USB select
> CONFIG_AXP20X_POWER automatically (my preferred solution)

It actually depends on the board, so no.

> or at least add it to sunxi_defconfig and multi_v7_defconfig.

Feel free to send a patch for it to a...@kernel.org in addition to the
usual recipients (Chen-Yu, LAKML and myself), and make it clear that
you want them to apply it.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

-- 
You received this message because you are subscribed to the Google Groups 
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to linux-sunxi+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


signature.asc
Description: Digital signature


Re: [linux-sunxi] Re: BUG - Bananapi USB not working on Mainline

2015-12-22 Thread m . silentcreek
Hi Hans,
Hi Maxime,

Am Sonntag, 20. Dezember 2015 08:38:52 UTC+1 schrieb David Tulloh:
> On 20 December 2015 at 08:39,   wrote:
> 
> I found the solution! The problem is CONFIG_AXP20X_POWER which was introduced 
> in 4.4-rc1 but defaults to no and not set in sunxi_defconfig. Adding 
> CONFIG_AXP20X_POWER=y to sunxi_defconfig solves that and get's my USB devices 
> working again on linux 4.4-rc5. I actually brought that up on IRC once, but 
> at that time nobody seemed to know so I forgot it again.
> 
> Thanks Timo,
> 
> I can confirm that adding CONFIG_AXP20X_POWER=y to sunxi_defconfig works for 
> me as well.

Is this considered an issue worthwhile to be addressed before the release of 
4.4?

The way I see it is that USB support is broken on A10/20 in mainline for 
anybody who builds on sunxi_defconfig or multi_v7_defconfig at the moment.

I think we should either have CONFIG_PHY_SUN4I_USB select CONFIG_AXP20X_POWER 
automatically (my preferred solution) or at least add it to sunxi_defconfig and 
multi_v7_defconfig.

I'd be glad to submit a short patch for it depending on your viewpoint.

Best wishes and happy holidays,

Timo

-- 
You received this message because you are subscribed to the Google Groups 
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to linux-sunxi+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Re: [linux-sunxi] Re: BUG - Bananapi USB not working on Mainline

2015-12-19 Thread David Tulloh
On 20 December 2015 at 08:39,  wrote:

> I found the solution! The problem is CONFIG_AXP20X_POWER which was
> introduced in 4.4-rc1 but defaults to no and not set in sunxi_defconfig.
> Adding CONFIG_AXP20X_POWER=y to sunxi_defconfig solves that and get's my
> USB devices working again on linux 4.4-rc5. I actually brought that up on
> IRC once, but at that time nobody seemed to know so I forgot it again.
>
>
Thanks Timo,

I can confirm that adding CONFIG_AXP20X_POWER=y to sunxi_defconfig works
for me as well.

I need to check my emails more often, I just spent several hours narrowing
this down but not quite reaching the solution.

Karsten's working config posted earlier defines CONFIG_AXP20X_POWER=m.


David

-- 
You received this message because you are subscribed to the Google Groups 
"linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to linux-sunxi+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.