Re: [PATCH 13/14] tracefs: Convert to new uid/gid option parsing helpers

[Steven Rostedt]

On Thu, 27 Jun 2024 19:40:44 -0500
Eric Sandeen  wrote:

> Convert to new uid/gid option parsing helpers
> 
> Signed-off-by: Eric Sandeen 

Acked-by: Steven Rostedt (Google) 

-- Steve

[PATCH 13/14] tracefs: Convert to new uid/gid option parsing helpers

[Eric Sandeen]

Convert to new uid/gid option parsing helpers

Signed-off-by: Eric Sandeen 
---
 fs/tracefs/inode.c | 16 
 1 file changed, 4 insertions(+), 12 deletions(-)

diff --git a/fs/tracefs/inode.c b/fs/tracefs/inode.c
index 7c29f4afc23d..1028ab6d9a74 100644
--- a/fs/tracefs/inode.c
+++ b/fs/tracefs/inode.c
@@ -296,9 +296,9 @@ enum {
 };
 
 static const struct fs_parameter_spec tracefs_param_specs[] = {
-   fsparam_u32 ("gid", Opt_gid),
+   fsparam_gid ("gid", Opt_gid),
fsparam_u32oct  ("mode",Opt_mode),
-   fsparam_u32 ("uid", Opt_uid),
+   fsparam_uid ("uid", Opt_uid),
{}
 };
 
@@ -306,8 +306,6 @@ static int tracefs_parse_param(struct fs_context *fc, 
struct fs_parameter *param
 {
struct tracefs_fs_info *opts = fc->s_fs_info;
struct fs_parse_result result;
-   kuid_t uid;
-   kgid_t gid;
int opt;
 
opt = fs_parse(fc, tracefs_param_specs, param, &result);
@@ -316,16 +314,10 @@ static int tracefs_parse_param(struct fs_context *fc, 
struct fs_parameter *param
 
switch (opt) {
case Opt_uid:
-   uid = make_kuid(current_user_ns(), result.uint_32);
-   if (!uid_valid(uid))
-   return invalf(fc, "Unknown uid");
-   opts->uid = uid;
+   opts->uid = result.uid;
break;
case Opt_gid:
-   gid = make_kgid(current_user_ns(), result.uint_32);
-   if (!gid_valid(gid))
-   return invalf(fc, "Unknown gid");
-   opts->gid = gid;
+   opts->gid = result.gid;
break;
case Opt_mode:
opts->mode = result.uint_32 & S_IALLUGO;
-- 
2.45.2