Re: [Patch v5 08/13] ARM: imx6q: add config-on-boot gpios
On 13.06.2012 14:34, Richard Zhao wrote:
Sometimes, boards have gpios that don't own by any driver or owner
by a generic driver that don't like hacks. Such gpios is normally
output and need setup once on boot. So I introduce the config-on-boot
gpios.
Signed-off-by: Richard Zhao
Cc: Shawn Guo
Cc: Rob Herring
Cc: Grant Likely
---
.../devicetree/bindings/arm/config-on-boot.txt | 12 +++
arch/arm/boot/dts/imx6q-sabrelite.dts |7
arch/arm/mach-imx/mach-imx6q.c | 35
3 files changed, 54 insertions(+)
create mode 100644 Documentation/devicetree/bindings/arm/config-on-boot.txt
diff --git a/Documentation/devicetree/bindings/arm/config-on-boot.txt
b/Documentation/devicetree/bindings/arm/config-on-boot.txt
new file mode 100644
index 000..f98ed74
--- /dev/null
+++ b/Documentation/devicetree/bindings/arm/config-on-boot.txt
@@ -0,0 +1,12 @@
+* Configure on Boot
+
+Node name: config-on-boot
+ It must be in root node. config-on-boot means to describe settings that needs
+ to be set one time on boot but aren't owned by any driver, or the owned
driver
+ is too generic to handle such settings. For example, usb hub uses generic
+ driver in usb core code, a on-board usb may need deassert reset pin.
+
+Optional properties:
+- output-gpios: Output gpio array that needs to set.
+- output-gpio-values: This property is required if output-gpios is set.
+ The value is a array of 0 or 1. Total count eaquals the number of gpios.
diff --git a/arch/arm/boot/dts/imx6q-sabrelite.dts
b/arch/arm/boot/dts/imx6q-sabrelite.dts
index e0ec929..1dd2261 100644
--- a/arch/arm/boot/dts/imx6q-sabrelite.dts
+++ b/arch/arm/boot/dts/imx6q-sabrelite.dts
@@ -17,6 +17,13 @@
model = "Freescale i.MX6 Quad SABRE Lite Board";
compatible = "fsl,imx6q-sabrelite", "fsl,imx6q";
+ config-on-boot {
+ output-gpios = <
+ &gpio3 22 0>;/* vbus reset */
+ output-gpio-values = <
+ 1>; /* vbus reset */
+ };
+
memory {
reg = <0x1000 0x4000>;
};
diff --git a/arch/arm/mach-imx/mach-imx6q.c b/arch/arm/mach-imx/mach-imx6q.c
index b47e98b..577cf19 100644
--- a/arch/arm/mach-imx/mach-imx6q.c
+++ b/arch/arm/mach-imx/mach-imx6q.c
@@ -19,6 +19,7 @@
#include
#include
#include
+#include
#include
#include
#include
@@ -113,6 +114,38 @@ static void __init imx6q_sabrelite_init(void)
imx6q_sabrelite_cko1_setup();
}
+static void __init imx6q_config_on_boot(void)
+{
+ struct device_node *np;
+ struct property *pp;
+ int cnt, len, i;
+ int gpio;
+
+ np = of_find_node_by_path("/config-on-boot");
+ if (!np)
+ return;
+ cnt = of_gpio_named_count(np, "output-gpios");
+ pp = of_find_property(np, "output-gpio-values", &len);
+ if (!pp || cnt != len / sizeof(u32)) {
+ pr_err("Invalid config-on-boot gpios!\n");
+ of_node_put(np);
+ return;
+ }
+ for (i = 0; i < cnt; i++) {
+ gpio = of_get_named_gpio(np, "output-gpios", i);
+ if (gpio_is_valid(gpio))
+ gpio_request_one(gpio, GPIOF_OUT_INIT_HIGH,
+ "config-on-boot");
While trying to use this code: Is there a special reason why all pins
are set to HIGH here? The contents of 'output-gpio-values' seem to be
ignored?
Best regards
Dirk
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] USB: sierra: add 1199:68AB device ID
Add support for USB descriptor 0x1199, 0x68AB.
Signed-off-by: Dirk Behme
---
drivers/usb/serial/sierra.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/serial/sierra.c b/drivers/usb/serial/sierra.c
index 46179a0..4122e4f 100644
--- a/drivers/usb/serial/sierra.c
+++ b/drivers/usb/serial/sierra.c
@@ -289,6 +289,9 @@ static const struct usb_device_id id_table[] = {
{ USB_DEVICE_AND_INTERFACE_INFO(0x1199, 0x68AA, 0xFF, 0xFF, 0xFF),
.driver_info = (kernel_ulong_t)&direct_ip_interface_blacklist
},
+ { USB_DEVICE(0x1199, 0x68AB), /* Sierra Wireless Direct IP modems */
+ .driver_info = (kernel_ulong_t)&direct_ip_interface_blacklist
+ },
/* AT&T Direct IP LTE modems */
{ USB_DEVICE_AND_INTERFACE_INFO(0x0F3D, 0x68AA, 0xFF, 0xFF, 0xFF),
.driver_info = (kernel_ulong_t)&direct_ip_interface_blacklist
--
2.3.4
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] USB: sierra: add 1199:68AB device ID
On 13.07.2015 09:39, Lars Melin wrote:
On 2015-07-13 12:44, Dirk Behme wrote:
Add support for USB descriptor 0x1199, 0x68AB.
Signed-off-by: Dirk Behme
---
drivers/usb/serial/sierra.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/serial/sierra.c b/drivers/usb/serial/sierra.c
index 46179a0..4122e4f 100644
--- a/drivers/usb/serial/sierra.c
+++ b/drivers/usb/serial/sierra.c
@@ -289,6 +289,9 @@ static const struct usb_device_id id_table[] = {
{ USB_DEVICE_AND_INTERFACE_INFO(0x1199, 0x68AA, 0xFF, 0xFF, 0xFF),
.driver_info = (kernel_ulong_t)&direct_ip_interface_blacklist
},
+{ USB_DEVICE(0x1199, 0x68AB), /* Sierra Wireless Direct IP
modems */
+ .driver_info = (kernel_ulong_t)&direct_ip_interface_blacklist
+},
/* AT&T Direct IP LTE modems */
{ USB_DEVICE_AND_INTERFACE_INFO(0x0F3D, 0x68AA, 0xFF, 0xFF, 0xFF),
.driver_info = (kernel_ulong_t)&direct_ip_interface_blacklist
1199:68ab is a usb id which I have not seen before and there is no
information available about it on the net, no google results.
I'm sure I am not the only one here who want to have more specific
information about this device, what is the Sierra product name?
What interfaces does it present on the usb bus, lsusb -v -d 1199:68ab
will show that.
It's a Sierra Wireless AR8550 device. See below [1] for the lsusb output.
Do you like me to add the whole lsusb output to the commit message?
Best regards
Dirk
[1]
Bus 001 Device 004: ID 1199:68ab Sierra Wireless, Inc.
Device Descriptor:
bLength18
bDescriptorType 1
bcdUSB 2.00
bDeviceClass0 (Defined at Interface level)
bDeviceSubClass 0
bDeviceProtocol 0
bMaxPacketSize064
idVendor 0x1199 Sierra Wireless, Inc.
idProduct 0x68ab
bcdDevice0.06
iManufacturer 3 Sierra Wireless, Incorporated
iProduct2 AR8550
iSerial 0
bNumConfigurations 1
Configuration Descriptor:
bLength 9
bDescriptorType 2
wTotalLength 198
bNumInterfaces 7
bConfigurationValue 1
iConfiguration 1 Sierra Configuration
bmAttributes 0xe0
Self Powered
Remote Wakeup
MaxPower0mA
Interface Descriptor:
bLength 9
bDescriptorType 4
bInterfaceNumber0
bAlternateSetting 0
bNumEndpoints 2
bInterfaceClass 255 Vendor Specific Class
bInterfaceSubClass255 Vendor Specific Subclass
bInterfaceProtocol255 Vendor Specific Protocol
iInterface 0
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x81 EP 1 IN
bmAttributes2
Transfer TypeBulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0200 1x 512 bytes
bInterval 32
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x01 EP 1 OUT
bmAttributes2
Transfer TypeBulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0200 1x 512 bytes
bInterval 32
Interface Descriptor:
bLength 9
bDescriptorType 4
bInterfaceNumber1
bAlternateSetting 0
bNumEndpoints 2
bInterfaceClass 255 Vendor Specific Class
bInterfaceSubClass255 Vendor Specific Subclass
bInterfaceProtocol255 Vendor Specific Protocol
iInterface 0
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x82 EP 2 IN
bmAttributes2
Transfer TypeBulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0200 1x 512 bytes
bInterval 32
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x02 EP 2 OUT
bmAttributes2
Transfer TypeBulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0200 1x 512 bytes
bInterval 32
Interface Descriptor:
bLength 9
bDescriptorType 4
bInterfaceNumber2
bAlternateSetting 0
bNumEndpoints 2
bInterfaceClass 255 Vendor Specific Class
bInterfaceSubClass255 Vendor Specific Subclass
bInterfaceProtocol25
[PATCH v2] USB: sierra: add 1199:68AB device ID
1x 512 bytes
bInterval 32
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x07 EP 7 OUT
bmAttributes2
Transfer TypeBulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0200 1x 512 bytes
bInterval 32
Device Qualifier (for other device speed):
bLength10
bDescriptorType 6
bcdUSB 2.00
bDeviceClass0 (Defined at Interface level)
bDeviceSubClass 0
bDeviceProtocol 0
bMaxPacketSize064
bNumConfigurations 1
Device Status: 0x0001
Self Powered
Signed-off-by: Dirk Behme
---
Changes in v2: Improve the commit message.
drivers/usb/serial/sierra.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/serial/sierra.c b/drivers/usb/serial/sierra.c
index 46179a0..4122e4f 100644
--- a/drivers/usb/serial/sierra.c
+++ b/drivers/usb/serial/sierra.c
@@ -289,6 +289,9 @@ static const struct usb_device_id id_table[] = {
{ USB_DEVICE_AND_INTERFACE_INFO(0x1199, 0x68AA, 0xFF, 0xFF, 0xFF),
.driver_info = (kernel_ulong_t)&direct_ip_interface_blacklist
},
+ { USB_DEVICE(0x1199, 0x68AB), /* Sierra Wireless Direct IP modems */
+ .driver_info = (kernel_ulong_t)&direct_ip_interface_blacklist
+ },
/* AT&T Direct IP LTE modems */
{ USB_DEVICE_AND_INTERFACE_INFO(0x0F3D, 0x68AA, 0xFF, 0xFF, 0xFF),
.driver_info = (kernel_ulong_t)&direct_ip_interface_blacklist
--
2.3.4
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2] USB: sierra: add 1199:68AB device ID
Hi Johan,
On 20.07.2015 11:24, Johan Hovold wrote:
[ +CC: Bjørn and Dan ]
On Mon, Jul 20, 2015 at 08:14:19AM +0200, Dirk Behme wrote:
Add support for the Sierra Wireless AR8550 device with
USB descriptor 0x1199, 0x68AB. For this, lsusb reports:
Thanks for the patch. This modem business is a bit of a mess and it's
not always apparent what driver a device id belongs to.
Bus 001 Device 004: ID 1199:68ab Sierra Wireless, Inc.
Device Descriptor:
bLength18
bDescriptorType 1
bcdUSB 2.00
bDeviceClass0 (Defined at Interface level)
bDeviceSubClass 0
bDeviceProtocol 0
bMaxPacketSize064
idVendor 0x1199 Sierra Wireless, Inc.
idProduct 0x68ab
bcdDevice0.06
iManufacturer 3 Sierra Wireless, Incorporated
iProduct2 AR8550
iSerial 0
bNumConfigurations 1
Configuration Descriptor:
bLength 9
bDescriptorType 2
wTotalLength 198
bNumInterfaces 7
[...]
Signed-off-by: Dirk Behme
---
Changes in v2: Improve the commit message.
drivers/usb/serial/sierra.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/serial/sierra.c b/drivers/usb/serial/sierra.c
index 46179a0..4122e4f 100644
--- a/drivers/usb/serial/sierra.c
+++ b/drivers/usb/serial/sierra.c
@@ -289,6 +289,9 @@ static const struct usb_device_id id_table[] = {
{ USB_DEVICE_AND_INTERFACE_INFO(0x1199, 0x68AA, 0xFF, 0xFF, 0xFF),
.driver_info = (kernel_ulong_t)&direct_ip_interface_blacklist
},
+ { USB_DEVICE(0x1199, 0x68AB), /* Sierra Wireless Direct IP modems */
+ .driver_info = (kernel_ulong_t)&direct_ip_interface_blacklist
+ },
This device has seven interfaces (0..6) so why do you use the direct-ip
interface blacklisting, which only blacklists interfaces >= 7?
Using it the same way like the quite similar ID 0x1199, 0x68AA above
'just works for us'. Not being the experts on this, do you like to
propose anything else you like us to try?
Also do you notice any delays when connecting the device (which could
indicate that sierra is not the right driver)?
As above, do you like us to try anything else?
Best regards
Dirk
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2] USB: sierra: add 1199:68AB device ID
On 23.07.2015 12:36, Johan Hovold wrote:
On Thu, Jul 23, 2015 at 12:31:55PM +0200, Dirk Behme wrote:
Hi Johan,
On 20.07.2015 11:24, Johan Hovold wrote:
[ +CC: Bjørn and Dan ]
On Mon, Jul 20, 2015 at 08:14:19AM +0200, Dirk Behme wrote:
Add support for the Sierra Wireless AR8550 device with
USB descriptor 0x1199, 0x68AB. For this, lsusb reports:
Thanks for the patch. This modem business is a bit of a mess and it's
not always apparent what driver a device id belongs to.
Bus 001 Device 004: ID 1199:68ab Sierra Wireless, Inc.
Device Descriptor:
bLength18
bDescriptorType 1
bcdUSB 2.00
bDeviceClass0 (Defined at Interface level)
bDeviceSubClass 0
bDeviceProtocol 0
bMaxPacketSize064
idVendor 0x1199 Sierra Wireless, Inc.
idProduct 0x68ab
bcdDevice0.06
iManufacturer 3 Sierra Wireless, Incorporated
iProduct2 AR8550
iSerial 0
bNumConfigurations 1
Configuration Descriptor:
bLength 9
bDescriptorType 2
wTotalLength 198
bNumInterfaces 7
[...]
Signed-off-by: Dirk Behme
---
Changes in v2: Improve the commit message.
drivers/usb/serial/sierra.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/serial/sierra.c b/drivers/usb/serial/sierra.c
index 46179a0..4122e4f 100644
--- a/drivers/usb/serial/sierra.c
+++ b/drivers/usb/serial/sierra.c
@@ -289,6 +289,9 @@ static const struct usb_device_id id_table[] = {
{ USB_DEVICE_AND_INTERFACE_INFO(0x1199, 0x68AA, 0xFF, 0xFF, 0xFF),
.driver_info = (kernel_ulong_t)&direct_ip_interface_blacklist
},
+ { USB_DEVICE(0x1199, 0x68AB), /* Sierra Wireless Direct IP modems */
+ .driver_info = (kernel_ulong_t)&direct_ip_interface_blacklist
+ },
This device has seven interfaces (0..6) so why do you use the direct-ip
interface blacklisting, which only blacklists interfaces >= 7?
Using it the same way like the quite similar ID 0x1199, 0x68AA above
'just works for us'. Not being the experts on this, do you like to
propose anything else you like us to try?
Also do you notice any delays when connecting the device (which could
indicate that sierra is not the right driver)?
As above, do you like us to try anything else?
Could you post a log from when connecting the device with you patch
applied?
Are you looking for something like this?
[ 102.948830] usb 1-1: new high-speed USB device number 4 using ci_hdrc
[ 103.101172] usb 1-1: New USB device found, idVendor=1199, idProduct=68ab
[ 103.101239] usb 1-1: New USB device strings: Mfr=3, Product=2,
SerialNumber=0
[ 103.101270] usb 1-1: Product: AR8550
[ 103.101297] usb 1-1: Manufacturer: Sierra Wireless, Incorporated
[ 103.195766] usbcore: registered new interface driver usbserial
[ 103.204471] usbcore: registered new interface driver sierra
[ 103.204692] usbserial: USB Serial support registered for Sierra USB modem
[ 103.204861] sierra 1-1:1.0: Sierra USB modem converter detected
[ 103.218385] usb 1-1: Sierra USB modem converter now attached to ttyUSB0
[ 103.220304] sierra 1-1:1.1: Sierra USB modem converter detected
[ 103.227186] usb 1-1: Sierra USB modem converter now attached to ttyUSB1
[ 103.227721] sierra 1-1:1.2: Sierra USB modem converter detected
[ 103.234287] usb 1-1: Sierra USB modem converter now attached to ttyUSB2
[ 103.234533] sierra 1-1:1.3: Sierra USB modem converter detected
[ 103.236469] usb 1-1: Sierra USB modem converter now attached to ttyUSB3
[ 103.236663] sierra 1-1:1.4: Sierra USB modem converter detected
[ 103.237712] usb 1-1: Sierra USB modem converter now attached to ttyUSB4
[ 103.237873] sierra 1-1:1.5: Sierra USB modem converter detected
[ 103.247026] usb 1-1: Sierra USB modem converter now attached to ttyUSB5
[ 103.247327] sierra 1-1:1.6: Sierra USB modem converter detected
[ 103.251378] usb 1-1: Sierra USB modem converter now attached to ttyUSB6
Best regards
Dirk
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2] USB: sierra: add 1199:68AB device ID
On 23.07.2015 19:26, Johan Hovold wrote:
On Thu, Jul 23, 2015 at 02:58:03PM +0200, Dirk Behme wrote:
On 23.07.2015 12:36, Johan Hovold wrote:
On Thu, Jul 23, 2015 at 12:31:55PM +0200, Dirk Behme wrote:
Hi Johan,
On 20.07.2015 11:24, Johan Hovold wrote:
[ +CC: Bjørn and Dan ]
On Mon, Jul 20, 2015 at 08:14:19AM +0200, Dirk Behme wrote:
Add support for the Sierra Wireless AR8550 device with
USB descriptor 0x1199, 0x68AB. For this, lsusb reports:
Thanks for the patch. This modem business is a bit of a mess and it's
not always apparent what driver a device id belongs to.
Bus 001 Device 004: ID 1199:68ab Sierra Wireless, Inc.
Device Descriptor:
bLength18
bDescriptorType 1
bcdUSB 2.00
bDeviceClass0 (Defined at Interface level)
bDeviceSubClass 0
bDeviceProtocol 0
bMaxPacketSize064
idVendor 0x1199 Sierra Wireless, Inc.
idProduct 0x68ab
bcdDevice0.06
iManufacturer 3 Sierra Wireless, Incorporated
iProduct2 AR8550
iSerial 0
bNumConfigurations 1
Configuration Descriptor:
bLength 9
bDescriptorType 2
wTotalLength 198
bNumInterfaces 7
[...]
Signed-off-by: Dirk Behme
---
Changes in v2: Improve the commit message.
drivers/usb/serial/sierra.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/serial/sierra.c b/drivers/usb/serial/sierra.c
index 46179a0..4122e4f 100644
--- a/drivers/usb/serial/sierra.c
+++ b/drivers/usb/serial/sierra.c
@@ -289,6 +289,9 @@ static const struct usb_device_id id_table[] = {
{ USB_DEVICE_AND_INTERFACE_INFO(0x1199, 0x68AA, 0xFF, 0xFF, 0xFF),
.driver_info = (kernel_ulong_t)&direct_ip_interface_blacklist
},
+ { USB_DEVICE(0x1199, 0x68AB), /* Sierra Wireless Direct IP modems */
+ .driver_info = (kernel_ulong_t)&direct_ip_interface_blacklist
+ },
This device has seven interfaces (0..6) so why do you use the direct-ip
interface blacklisting, which only blacklists interfaces >= 7?
Using it the same way like the quite similar ID 0x1199, 0x68AA above
'just works for us'. Not being the experts on this, do you like to
propose anything else you like us to try?
Also do you notice any delays when connecting the device (which could
indicate that sierra is not the right driver)?
As above, do you like us to try anything else?
Could you post a log from when connecting the device with you patch
applied?
Are you looking for something like this?
[ 102.948830] usb 1-1: new high-speed USB device number 4 using ci_hdrc
[ 103.101172] usb 1-1: New USB device found, idVendor=1199, idProduct=68ab
[ 103.101239] usb 1-1: New USB device strings: Mfr=3, Product=2,
SerialNumber=0
[ 103.101270] usb 1-1: Product: AR8550
[ 103.101297] usb 1-1: Manufacturer: Sierra Wireless, Incorporated
[ 103.195766] usbcore: registered new interface driver usbserial
[ 103.204471] usbcore: registered new interface driver sierra
[ 103.204692] usbserial: USB Serial support registered for Sierra USB modem
[ 103.204861] sierra 1-1:1.0: Sierra USB modem converter detected
[ 103.218385] usb 1-1: Sierra USB modem converter now attached to ttyUSB0
[ 103.220304] sierra 1-1:1.1: Sierra USB modem converter detected
[ 103.227186] usb 1-1: Sierra USB modem converter now attached to ttyUSB1
[ 103.227721] sierra 1-1:1.2: Sierra USB modem converter detected
[ 103.234287] usb 1-1: Sierra USB modem converter now attached to ttyUSB2
[ 103.234533] sierra 1-1:1.3: Sierra USB modem converter detected
[ 103.236469] usb 1-1: Sierra USB modem converter now attached to ttyUSB3
[ 103.236663] sierra 1-1:1.4: Sierra USB modem converter detected
[ 103.237712] usb 1-1: Sierra USB modem converter now attached to ttyUSB4
[ 103.237873] sierra 1-1:1.5: Sierra USB modem converter detected
[ 103.247026] usb 1-1: Sierra USB modem converter now attached to ttyUSB5
[ 103.247327] sierra 1-1:1.6: Sierra USB modem converter detected
[ 103.251378] usb 1-1: Sierra USB modem converter now attached to ttyUSB6
Yes, we've seen lengthy timeouts during probe for some Sierra devices
when incorrectly driven by the sierra driver, but that's not the case
here.
This is probably the right driver, but I'm confused over the DirectIP
bits. Those interfaces are lacking AFAICT and still your comment claims
it's a DirectIP modem (that would also require it to be added not the
network driver).
As we just use this device as ttyUSBx, it seems the "Direct IP modems"
comment might be wrong and a copy & paste error. I'll remove it in v3.
Ok?
Best regards
Dirk
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2] USB: sierra: add 1199:68AB device ID
On 24.07.2015 10:45, Johan Hovold wrote:
On Fri, Jul 24, 2015 at 10:17:24AM +0200, Dirk Behme wrote:
On 23.07.2015 19:26, Johan Hovold wrote:
This is probably the right driver, but I'm confused over the DirectIP
bits. Those interfaces are lacking AFAICT and still your comment claims
it's a DirectIP modem (that would also require it to be added not the
network driver).
As we just use this device as ttyUSBx, it seems the "Direct IP modems"
comment might be wrong and a copy & paste error. I'll remove it in v3.
Ok?
Sounds good. And drop the blacklisting too.
Just for better understanding:
We took the existing 0x68AA device
{ USB_DEVICE_AND_INTERFACE_INFO(0x1199, 0x68AA, 0xFF, 0xFF, 0xFF),
.driver_info = (kernel_ulong_t)&direct_ip_interface_blacklist
as an example for our 0x68AB.
Do we have a lsusb from the 0x68AA to get an idea what's different
between the existing 0x68AA and the new 0x68AB? I.e. why 0x68AA needs
the blacklisting, but 0x68AB not?
Best regards
Dirk
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2] USB: sierra: add 1199:68AB device ID
On 24.07.2015 14:37, Johan Hovold wrote: On Fri, Jul 24, 2015 at 07:22:45PM +0700, Lars Melin wrote: The interface layout of 1199:68ab does not look like 1199:68aa does, it has instead more in common with MC879x modules 1199:683c/683d which also are composite devices with 7 interfaces (0..6) and also MDM62xx based as the AR8550. The major difference is from what I can see only the interface attributes 02/02/01 on interfaces 3 and 4 on the AR8550, they are vendor specific ff/ff/ff on MC879x modules. So the Sierra driver seems to be the right driver for the AR8550, I only find it strange that Sierra hasn't added it. Somehow I would also expect them to tell their customers (which I assume Dirkäs employer is) which driver to use.. Thanks for the input, Lars. Dirk, care to respin the patch and drop the blacklisting and direct-ip comment as already discussed? Sure, I'll do that. Thanks for the discussion! Best regards Dirk -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v3] USB: sierra: add 1199:68AB device ID
:
bLength 7
bDescriptorType 5
bEndpointAddress 0x8b EP 11 IN
bmAttributes2
Transfer TypeBulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0200 1x 512 bytes
bInterval 32
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x07 EP 7 OUT
bmAttributes2
Transfer TypeBulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0200 1x 512 bytes
bInterval 32
Device Qualifier (for other device speed):
bLength10
bDescriptorType 6
bcdUSB 2.00
bDeviceClass0 (Defined at Interface level)
bDeviceSubClass 0
bDeviceProtocol 0
bMaxPacketSize064
bNumConfigurations 1
Device Status: 0x0001
Self Powered
Signed-off-by: Dirk Behme
---
Changes in v3: Remove all direct IP references
drivers/usb/serial/sierra.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/serial/sierra.c b/drivers/usb/serial/sierra.c
index 46179a0..07d1ecd 100644
--- a/drivers/usb/serial/sierra.c
+++ b/drivers/usb/serial/sierra.c
@@ -289,6 +289,7 @@ static const struct usb_device_id id_table[] = {
{ USB_DEVICE_AND_INTERFACE_INFO(0x1199, 0x68AA, 0xFF, 0xFF, 0xFF),
.driver_info = (kernel_ulong_t)&direct_ip_interface_blacklist
},
+ { USB_DEVICE(0x1199, 0x68AB) }, /* Sierra Wireless AR8550 */
/* AT&T Direct IP LTE modems */
{ USB_DEVICE_AND_INTERFACE_INFO(0x0F3D, 0x68AA, 0xFF, 0xFF, 0xFF),
.driver_info = (kernel_ulong_t)&direct_ip_interface_blacklist
--
2.3.4
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
