[PATCH v3] Add support for GPIOs for SMSC LAN95xx chips.
There might be 11 GPIOs in total.
Last three GPIOs (offsets 8-10, 0-based) are shared with FDX, LNKA, SPD
LEDs respectively. The LEDs are driven by chip by default at startup time.
Once the corresponding GPIO is requested, the chip LED drive logic is disabled.
The numbering scheme according to datasheets differs a bit between LAN9500
and LAN951x.
For LAN951x:
GPIOs with offsets 0-7 are named GPIO3 - GPIO7,
offsets 8-10 are for GPIO0 - GPIO2 (these three are multiplexed with
nFDX_LED,
nLNKA_LED, nSPD_LED).
For LAN9500:
The datasheet name is the same as the corresponding offset, i.e. offsets 0-10
are
for GPIO0-GPIO10.
Signed-off-by: Evgeny Boger bo...@contactless.ru
---
Changes:
v3: Remove more unnecessary newlines and return statement.
Fix typo in commit message (max offset 10, was: 11)
Add note on GPIO numbering scheme
v2: Remove unnecessary newlines.
Store cached gpio register values in order to
1) speed-up gpio_set by avoiding reading gpio
register prior to writing
2) restore gpio register settings after chip reset
which is triggered for instance on link up
drivers/net/usb/smsc95xx.c | 295 +++--
drivers/net/usb/smsc95xx.h | 1 +
2 files changed, 287 insertions(+), 9 deletions(-)
diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c
index f3cef7c..d5d8735 100644
--- a/drivers/net/usb/smsc95xx.c
+++ b/drivers/net/usb/smsc95xx.c
@@ -31,6 +31,7 @@
#include linux/crc32.h
#include linux/usb/usbnet.h
#include linux/slab.h
+#include linux/gpio.h
#include smsc95xx.h
#define SMSC_CHIPNAME smsc95xx
@@ -70,6 +71,14 @@ struct smsc95xx_priv {
spinlock_t mac_cr_lock;
u8 features;
u8 suspend_flags;
+ struct usbnet *dev;
+#ifdef CONFIG_GPIOLIB
+ struct gpio_chip gpio;
+ struct mutex gpio_lock; /* lock for GPIO functions */
+#endif
+
+ u32 reg_gpio_cfg;
+ u32 reg_led_gpio_cfg;
};
static bool turbo_mode = true;
@@ -877,7 +886,7 @@ static int smsc95xx_phy_initialize(struct usbnet *dev)
static int smsc95xx_reset(struct usbnet *dev)
{
struct smsc95xx_priv *pdata = (struct smsc95xx_priv *)(dev-data[0]);
- u32 read_buf, write_buf, burst_cap;
+ u32 read_buf, burst_cap;
int ret = 0, timeout;
netif_dbg(dev, ifup, dev-net, entering smsc95xx_reset\n);
@@ -886,6 +895,24 @@ static int smsc95xx_reset(struct usbnet *dev)
if (ret 0)
return ret;
+ /* restore and re-read GPIO registers immediately after requesting Lite
Reset */
+
+ ret = smsc95xx_write_reg(dev, GPIO_CFG, pdata-reg_gpio_cfg);
+ if (ret 0)
+ return ret;
+
+ ret = smsc95xx_write_reg(dev, LED_GPIO_CFG, pdata-reg_led_gpio_cfg);
+ if (ret 0)
+ return ret;
+
+ ret = smsc95xx_read_reg(dev, GPIO_CFG, pdata-reg_gpio_cfg);
+ if (ret 0)
+ return ret;
+
+ ret = smsc95xx_read_reg(dev, LED_GPIO_CFG, pdata-reg_led_gpio_cfg);
+ if (ret 0)
+ return ret;
+
timeout = 0;
do {
msleep(10);
@@ -1019,13 +1046,6 @@ static int smsc95xx_reset(struct usbnet *dev)
return ret;
netif_dbg(dev, ifup, dev-net, ID_REV = 0x%08x\n, read_buf);
- /* Configure GPIO pins as LED outputs */
- write_buf = LED_GPIO_CFG_SPD_LED | LED_GPIO_CFG_LNK_LED |
- LED_GPIO_CFG_FDX_LED;
- ret = smsc95xx_write_reg(dev, LED_GPIO_CFG, write_buf);
- if (ret 0)
- return ret;
-
/* Init Tx */
ret = smsc95xx_write_reg(dev, FLOW, 0);
if (ret 0)
@@ -1101,6 +1121,237 @@ static const struct net_device_ops smsc95xx_netdev_ops
= {
.ndo_set_features = smsc95xx_set_features,
};
+/* GPIO * */
+/* Note: the numbering scheme according to datasheets differs a bit
+ * between LAN9500 and LAN951x.
+ *
+ * For LAN951x:
+ * GPIOs with offsets 0-7 are named GPIO3 - GPIO7, offsets 8-10 are
+ * for GPIO0 - GPIO2 (these three are multiplexed with nFDX_LED,
+ * nLNKA_LED, nSPD_LED).
+ *
+ * For LAN9500:
+ * the datasheet name is the same as the corresponding offset, i.e.
+ * offsets 0-10 are for GPIO0-GPIO10.
+*/
+
+#ifdef CONFIG_GPIOLIB
+
+static inline u32 smsc95xx_gpio_get_register(unsigned gpio)
+{
+ if (gpio 8)
+ return GPIO_CFG;
+ else
+ return LED_GPIO_CFG;
+}
+
+static inline u8 smsc95xx_gpio_get_enable_offset(unsigned gpio)
+{
+ return (gpio 8) ? (24 + gpio) : (gpio * 4 - 16);
+}
+
+static inline u8 smsc95xx_gpio_get_type_offset(unsigned gpio)
+{
+ return (gpio 8) ? (16 + gpio) : gpio;
+}
+
+static inline u8 smsc95xx_gpio_get_dir_offset(unsigned gpio)
+{
+ return (gpio 8) ? (8 + gpio) : (gpio - 4);
+}
+
+static inline u8
Re: [PATCH v2] Add support for GPIOs for SMSC LAN95xx chips.
06/25/2014 02:34 PM, Daniele Forsi пишет:
2014-06-25 6:46 GMT+02:00 Evgeny Boger:
There might be 11 GPIOs in total.
do you mean 12 GPIOs? You say later they are 0-based and the last one is 11
Last three GPIOs (offsets 8-11, 0-based) are shared with FDX, LNKA, SPD
LEDs respectively.
so you mean the last four?
and you may want to remove the extra space before the open parenthesis
My mistake. 11 GPIOs in total, eight of them (0-7) are normal GPIOs,
while three other are multiplexed with link activity LEDs.
So it should read like offset 8-10, 0-based.
Actually, the numbering scheme according to datasheets differs a bit
between LAN9500 and LAN951x:
For LAN951x:
GPIOs with offsets 0-7 are named GPIO3 - GPIO7, offsets 8-10 are for
GPIO0 - GPIO2 (these three are multiplexed with nFDX_LED, nLNKA_LED,
nSPD_LED).
For LAN9500:
The datasheet name is the same as the corresponding offset, i.e. offsets
0-10 are for GPIO0-GPIO10.
What do you think, shoud I write some note about this numbering scheme?
If so, where it would be better to place such a note?
also there are still several unneeded newlines
diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c
@@ -68,6 +70,15 @@ struct smsc95xx_priv {
spinlock_t mac_cr_lock;
u8 features;
u8 suspend_flags;
+
+ struct usbnet *dev;
+static int smsc95xx_gpio_request(struct gpio_chip *gpio, unsigned offset)
+ mutex_unlock(pdata-gpio_lock);
+
+
+ return (ret 0) ? ret : 0;
+}
+
+static void smsc95xx_gpio_free(struct gpio_chip *gpio, unsigned offset)
+ if (ret 0)
+ netif_err(pdata-dev, ifdown, pdata-dev-net,
+ error freeing gpio %d\n, offset);
+
+}
and in other places
+static void smsc95xx_gpio_set(struct gpio_chip *gpio, unsigned offset,
+ int value)
+{
+ if (ret 0) {
+ netif_err(pdata-dev, ifdown, pdata-dev-net,
+ error writing gpio %d=%d\n, offset, value);
+ return;
+ }
+}
no need to put a return there at he end of the function (if it's
defensive programming then you didn't put return in similar code in a
previous function)
--
С уважением,
Евгений Богер
ООО Бесконтактные устройства
http://contactless.ru
+7 (919) 965 88 36
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v2] Add support for GPIOs for SMSC LAN95xx chips.
There might be 11 GPIOs in total.
Last three GPIOs (offsets 8-11, 0-based) are shared with FDX, LNKA, SPD
LEDs respectively. The LEDs are driven by chip by default at startup time.
Once the corresponding GPIO is requested, the chip LED drive logic is disabled.
Signed-off-by: Evgeny Boger bo...@contactless.ru
---
Changes:
v2: Remove unnecessary newlines.
Store cached gpio register values in order to
1) speed-up gpio_set by avoiding reading gpio
register prior to writing
2) restore gpio register settings after chip reset
which is triggered for instance on link up
drivers/net/usb/smsc95xx.c | 290 +++--
drivers/net/usb/smsc95xx.h | 1 +
2 files changed, 282 insertions(+), 9 deletions(-)
diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c
index 424db65e..8f236de 100644
--- a/drivers/net/usb/smsc95xx.c
+++ b/drivers/net/usb/smsc95xx.c
@@ -29,6 +29,8 @@
#include linux/crc32.h
#include linux/usb/usbnet.h
#include linux/slab.h
+#include linux/gpio.h
+
#include smsc95xx.h
#define SMSC_CHIPNAME smsc95xx
@@ -68,6 +70,15 @@ struct smsc95xx_priv {
spinlock_t mac_cr_lock;
u8 features;
u8 suspend_flags;
+
+ struct usbnet *dev;
+#ifdef CONFIG_GPIOLIB
+ struct gpio_chip gpio;
+ struct mutex gpio_lock; /* lock for GPIO functions */
+#endif
+
+ u32 reg_gpio_cfg;
+ u32 reg_led_gpio_cfg;
};
static bool turbo_mode = true;
@@ -875,7 +886,7 @@ static int smsc95xx_phy_initialize(struct usbnet *dev)
static int smsc95xx_reset(struct usbnet *dev)
{
struct smsc95xx_priv *pdata = (struct smsc95xx_priv *)(dev-data[0]);
- u32 read_buf, write_buf, burst_cap;
+ u32 read_buf, burst_cap;
int ret = 0, timeout;
netif_dbg(dev, ifup, dev-net, entering smsc95xx_reset\n);
@@ -884,6 +895,24 @@ static int smsc95xx_reset(struct usbnet *dev)
if (ret 0)
return ret;
+ /* restore and re-read GPIO registers immediately after requesting Lite
Reset */
+
+ ret = smsc95xx_write_reg(dev, GPIO_CFG, pdata-reg_gpio_cfg);
+ if (ret 0)
+ return ret;
+
+ ret = smsc95xx_write_reg(dev, LED_GPIO_CFG, pdata-reg_led_gpio_cfg);
+ if (ret 0)
+ return ret;
+
+ ret = smsc95xx_read_reg(dev, GPIO_CFG, pdata-reg_gpio_cfg);
+ if (ret 0)
+ return ret;
+
+ ret = smsc95xx_read_reg(dev, LED_GPIO_CFG, pdata-reg_led_gpio_cfg);
+ if (ret 0)
+ return ret;
+
timeout = 0;
do {
msleep(10);
@@ -1017,13 +1046,6 @@ static int smsc95xx_reset(struct usbnet *dev)
return ret;
netif_dbg(dev, ifup, dev-net, ID_REV = 0x%08x\n, read_buf);
- /* Configure GPIO pins as LED outputs */
- write_buf = LED_GPIO_CFG_SPD_LED | LED_GPIO_CFG_LNK_LED |
- LED_GPIO_CFG_FDX_LED;
- ret = smsc95xx_write_reg(dev, LED_GPIO_CFG, write_buf);
- if (ret 0)
- return ret;
-
/* Init Tx */
ret = smsc95xx_write_reg(dev, FLOW, 0);
if (ret 0)
@@ -1099,6 +1121,228 @@ static const struct net_device_ops smsc95xx_netdev_ops
= {
.ndo_set_features = smsc95xx_set_features,
};
+/* GPIO * */
+
+#ifdef CONFIG_GPIOLIB
+
+static inline u32 smsc95xx_gpio_get_register(unsigned gpio)
+{
+ if (gpio 8)
+ return GPIO_CFG;
+ else
+ return LED_GPIO_CFG;
+}
+
+static inline u8 smsc95xx_gpio_get_enable_offset(unsigned gpio)
+{
+ return (gpio 8) ? (24 + gpio) : (gpio * 4 - 16);
+}
+
+static inline u8 smsc95xx_gpio_get_type_offset(unsigned gpio)
+{
+ return (gpio 8) ? (16 + gpio) : gpio;
+}
+
+static inline u8 smsc95xx_gpio_get_dir_offset(unsigned gpio)
+{
+ return (gpio 8) ? (8 + gpio) : (gpio - 4);
+}
+
+static inline u8 smsc95xx_gpio_get_val_offset(unsigned gpio)
+{
+ return (gpio 8) ? (gpio) : (gpio - 8);
+}
+
+static inline u32* smsc95xx_gpio_get_reg_cache_ptr(struct smsc95xx_priv
*pdata, unsigned gpio)
+{
+ return (gpio 8) ? (pdata-reg_gpio_cfg) : (pdata-reg_led_gpio_cfg);
+}
+
+static int smsc95xx_gpio_request(struct gpio_chip *gpio, unsigned offset)
+{
+ int ret = -1;
+ u32 reg;
+ int type_shift;
+ struct smsc95xx_priv *pdata =
+ container_of(gpio, struct smsc95xx_priv, gpio);
+ u32 *reg_cache_ptr = smsc95xx_gpio_get_reg_cache_ptr(pdata, offset);
+
+ reg = smsc95xx_gpio_get_register(offset);
+ type_shift = smsc95xx_gpio_get_type_offset(offset);
+
+ mutex_lock(pdata-gpio_lock);
+
+ *reg_cache_ptr = ~BIT(smsc95xx_gpio_get_enable_offset(offset));
+ *reg_cache_ptr |= BIT(type_shift);
+ *reg_cache_ptr = ~BIT(smsc95xx_gpio_get_dir_offset(offset));
+
+ ret = smsc95xx_write_reg
Re: [PATCH 1/1] Add support for GPIOs for SMSC LAN95xx chips.
sorry for the delay.
Won't you need to add some GPIOLIB logic to the Kconfig entry for this
driver?
I don't think so. As far as I understand, the standard approach is to
make sure that the driver with optional GPIOs works well with no GPIOLIB
selected.
Examples: tty/serial/max310x.c, input/touchscreen/ad7879.c,
leds/leds-tca6507.c and so on
One empty line is sufficient between functions, please delete on of these
two.
fixed
Please do not put empty lines in the middle of local function
variable declarations.
fixed
Likewise and do put an empty line after the variable declarations
and before the first real C statement.
fixed
Other changes:
Store cached gpio register values in order to
1) speed-up gpio_set by avoiding reading gpio register prior to writing
2) restore gpio register settings after chip reset which is triggered
for instance on link up
Updated patch is as follows:
Signed-off-by: Evgeny Boger bo...@contactless.ru
---
drivers/net/usb/smsc95xx.c | 290
+++--
drivers/net/usb/smsc95xx.h | 1 +
2 files changed, 282 insertions(+), 9 deletions(-)
diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c
index 424db65e..8f236de 100644
--- a/drivers/net/usb/smsc95xx.c
+++ b/drivers/net/usb/smsc95xx.c
@@ -29,6 +29,8 @@
#include linux/crc32.h
#include linux/usb/usbnet.h
#include linux/slab.h
+#include linux/gpio.h
+
#include smsc95xx.h
#define SMSC_CHIPNAMEsmsc95xx
@@ -68,6 +70,15 @@ struct smsc95xx_priv {
spinlock_t mac_cr_lock;
u8 features;
u8 suspend_flags;
+
+struct usbnet *dev;
+#ifdef CONFIG_GPIOLIB
+struct gpio_chip gpio;
+struct mutex gpio_lock;/* lock for GPIO functions */
+#endif
+
+u32 reg_gpio_cfg;
+u32 reg_led_gpio_cfg;
};
static bool turbo_mode = true;
@@ -875,7 +886,7 @@ static int smsc95xx_phy_initialize(struct usbnet *dev)
static int smsc95xx_reset(struct usbnet *dev)
{
struct smsc95xx_priv *pdata = (struct smsc95xx_priv *)(dev-data[0]);
-u32 read_buf, write_buf, burst_cap;
+u32 read_buf, burst_cap;
int ret = 0, timeout;
netif_dbg(dev, ifup, dev-net, entering smsc95xx_reset\n);
@@ -884,6 +895,24 @@ static int smsc95xx_reset(struct usbnet *dev)
if (ret 0)
return ret;
+/* restore and re-read GPIO registers immediately after requesting
Lite Reset */
+
+ret = smsc95xx_write_reg(dev, GPIO_CFG, pdata-reg_gpio_cfg);
+if (ret 0)
+return ret;
+
+ret = smsc95xx_write_reg(dev, LED_GPIO_CFG, pdata-reg_led_gpio_cfg);
+if (ret 0)
+return ret;
+
+ret = smsc95xx_read_reg(dev, GPIO_CFG, pdata-reg_gpio_cfg);
+if (ret 0)
+return ret;
+
+ret = smsc95xx_read_reg(dev, LED_GPIO_CFG, pdata-reg_led_gpio_cfg);
+if (ret 0)
+return ret;
+
timeout = 0;
do {
msleep(10);
@@ -1017,13 +1046,6 @@ static int smsc95xx_reset(struct usbnet *dev)
return ret;
netif_dbg(dev, ifup, dev-net, ID_REV = 0x%08x\n, read_buf);
-/* Configure GPIO pins as LED outputs */
-write_buf = LED_GPIO_CFG_SPD_LED | LED_GPIO_CFG_LNK_LED |
-LED_GPIO_CFG_FDX_LED;
-ret = smsc95xx_write_reg(dev, LED_GPIO_CFG, write_buf);
-if (ret 0)
-return ret;
-
/* Init Tx */
ret = smsc95xx_write_reg(dev, FLOW, 0);
if (ret 0)
@@ -1099,6 +1121,228 @@ static const struct net_device_ops
smsc95xx_netdev_ops = {
.ndo_set_features= smsc95xx_set_features,
};
+/* GPIO
* */
+
+#ifdef CONFIG_GPIOLIB
+
+static inline u32 smsc95xx_gpio_get_register(unsigned gpio)
+{
+if (gpio 8)
+return GPIO_CFG;
+else
+return LED_GPIO_CFG;
+}
+
+static inline u8 smsc95xx_gpio_get_enable_offset(unsigned gpio)
+{
+return (gpio 8) ? (24 + gpio) : (gpio * 4 - 16);
+}
+
+static inline u8 smsc95xx_gpio_get_type_offset(unsigned gpio)
+{
+return (gpio 8) ? (16 + gpio) : gpio;
+}
+
+static inline u8 smsc95xx_gpio_get_dir_offset(unsigned gpio)
+{
+return (gpio 8) ? (8 + gpio) : (gpio - 4);
+}
+
+static inline u8 smsc95xx_gpio_get_val_offset(unsigned gpio)
+{
+return (gpio 8) ? (gpio) : (gpio - 8);
+}
+
+static inline u32* smsc95xx_gpio_get_reg_cache_ptr(struct smsc95xx_priv
*pdata, unsigned gpio)
+{
+return (gpio 8) ? (pdata-reg_gpio_cfg) :
(pdata-reg_led_gpio_cfg);
+}
+
+static int smsc95xx_gpio_request(struct gpio_chip *gpio, unsigned offset)
+{
+int ret = -1;
+u32 reg;
+int type_shift;
+struct smsc95xx_priv *pdata =
+container_of(gpio, struct smsc95xx_priv, gpio);
+u32 *reg_cache_ptr = smsc95xx_gpio_get_reg_cache_ptr(pdata, offset);
+
+reg = smsc95xx_gpio_get_register(offset);
+type_shift = smsc95xx_gpio_get_type_offset(offset);
+
+mutex_lock(pdata-gpio_lock);
+
+*reg_cache_ptr = ~BIT(smsc95xx_gpio_get_enable_offset(offset));
+*reg_cache_ptr |= BIT(type_shift
[PATCH 1/1] Add support for GPIOs for SMSC LAN95xx chips.
There might be 11 GPIOs in total. Last three GPIOs (offsets 8-11, 0-based) are
shared
with FDX, LNKA, SPD LEDs respectively. The LEDs are driven by chip by default
at startup time. Once the corresponding GPIO is requested, the chip LED drive
logic is disabled.
Based on commented out code presumably from SMSC original driver.
https://github.com/olerem/barebox/blob/master/drivers/net/usb/smsc95xx.c
Signed-off-by: Evgeny Boger bo...@contactless.ru
---
drivers/net/usb/smsc95xx.c | 266 +
1 file changed, 266 insertions(+)
diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c
index 424db65e..af29adf 100644
--- a/drivers/net/usb/smsc95xx.c
+++ b/drivers/net/usb/smsc95xx.c
@@ -29,6 +29,8 @@
#include linux/crc32.h
#include linux/usb/usbnet.h
#include linux/slab.h
+#include linux/gpio.h
+
#include smsc95xx.h
#define SMSC_CHIPNAME smsc95xx
@@ -68,6 +70,13 @@ struct smsc95xx_priv {
spinlock_t mac_cr_lock;
u8 features;
u8 suspend_flags;
+
+ struct usbnet *dev;
+#ifdef CONFIG_GPIOLIB
+ struct gpio_chip gpio;
+ struct mutex gpio_lock; /* lock for GPIO functions */
+#endif
+
};
static bool turbo_mode = true;
@@ -1099,6 +1108,246 @@ static const struct net_device_ops smsc95xx_netdev_ops
= {
.ndo_set_features = smsc95xx_set_features,
};
+/* GPIO * */
+
+#ifdef CONFIG_GPIOLIB
+
+static inline u32 smsc95xx_gpio_get_register(unsigned gpio)
+{
+ if (gpio 8)
+ return GPIO_CFG;
+ else
+ return LED_GPIO_CFG;
+}
+
+static inline u8 smsc95xx_gpio_get_enable_offset(unsigned gpio)
+{
+ return (gpio 8) ? (24 + gpio) : (gpio * 4 - 16);
+}
+
+static inline u8 smsc95xx_gpio_get_type_offset(unsigned gpio)
+{
+ return (gpio 8) ? (16 + gpio) : gpio;
+}
+
+static inline u8 smsc95xx_gpio_get_dir_offset(unsigned gpio)
+{
+ return (gpio 8) ? (8 + gpio) : (gpio - 4);
+}
+
+static inline u8 smsc95xx_gpio_get_val_offset(unsigned gpio)
+{
+ return (gpio 8) ? (gpio) : (gpio - 8);
+}
+
+
+static int smsc95xx_gpio_request(struct gpio_chip *gpio, unsigned offset)
+{
+ int ret = -1;
+ u32 val, reg;
+ int type_shift;
+
+ struct smsc95xx_priv *pdata =
+ container_of(gpio, struct smsc95xx_priv, gpio);
+
+ reg = smsc95xx_gpio_get_register(offset);
+ type_shift = smsc95xx_gpio_get_type_offset(offset);
+
+ mutex_lock(pdata-gpio_lock);
+
+ ret = smsc95xx_read_reg(pdata-dev, reg, val);
+ if (ret = 0) {
+ val = ~BIT(smsc95xx_gpio_get_enable_offset(offset));
+
+ val |= BIT(type_shift);
+ val = ~BIT(smsc95xx_gpio_get_dir_offset(offset));
+
+ ret = smsc95xx_write_reg(pdata-dev, reg, val);
+ }
+
+ mutex_unlock(pdata-gpio_lock);
+
+
+ return (ret 0) ? ret : 0;
+}
+
+static void smsc95xx_gpio_free(struct gpio_chip *gpio, unsigned offset)
+{
+ int ret = -1;
+ u32 val, reg;
+ int type_shift;
+
+ struct smsc95xx_priv *pdata =
+ container_of(gpio, struct smsc95xx_priv, gpio);
+
+ reg = smsc95xx_gpio_get_register(offset);
+ type_shift = smsc95xx_gpio_get_type_offset(offset);
+
+ mutex_lock(pdata-gpio_lock);
+
+ ret = smsc95xx_read_reg(pdata-dev, reg, val);
+ if (ret = 0) {
+ val |= BIT(smsc95xx_gpio_get_enable_offset(offset));
+
+ if (offset = 8) {
+ /* Let the chip control LED GPIOs */
+ val = ~BIT(type_shift);
+ val |= BIT(smsc95xx_gpio_get_dir_offset(offset));
+ }
+
+ ret = smsc95xx_write_reg(pdata-dev, reg, val);
+
+ }
+
+ mutex_unlock(pdata-gpio_lock);
+
+ if (ret 0)
+ netif_err(pdata-dev, ifdown, pdata-dev-net,
+ error freeing gpio %d\n, offset);
+
+}
+
+static int smsc95xx_gpio_direction_input(struct gpio_chip *gpio,
+ unsigned offset)
+{
+ int ret = -1;
+ u32 val, reg;
+ struct smsc95xx_priv *pdata =
+ container_of(gpio, struct smsc95xx_priv, gpio);
+
+ reg = smsc95xx_gpio_get_register(offset);
+
+ mutex_lock(pdata-gpio_lock);
+
+ ret = smsc95xx_read_reg(pdata-dev, reg, val);
+ if (ret = 0) {
+ val = ~BIT(smsc95xx_gpio_get_dir_offset(offset));
+
+ ret = smsc95xx_write_reg(pdata-dev, reg, val);
+ }
+
+ mutex_unlock(pdata-gpio_lock);
+
+ return (ret 0) ? ret : 0;
+}
+
+static int smsc95xx_gpio_direction_output(struct gpio_chip *gpio,
+ unsigned offset, int value)
+{
+ int ret = -1;
+ u32 val, reg;
+
+ struct smsc95xx_priv *pdata =
+ container_of(gpio, struct smsc95xx_priv, gpio);
+ reg
