[PATCH] usb: PS3 EHCI remove unneeded ehci_shutdown
Remove an unneeded call to ehci_shutdown() in ps3_ehci_remove(). This removal will allow for a loadable ehci driver. Cc: Arnd Bergmann a...@arndb.de Signed-off-by: Geoff Levand ge...@infradead.org --- drivers/usb/host/ehci-ps3.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/host/ehci-ps3.c b/drivers/usb/host/ehci-ps3.c index df5925a..fd98377 100644 --- a/drivers/usb/host/ehci-ps3.c +++ b/drivers/usb/host/ehci-ps3.c @@ -221,7 +221,6 @@ static int ps3_ehci_remove(struct ps3_system_bus_device *dev) tmp = hcd-irq; - ehci_shutdown(hcd); usb_remove_hcd(hcd); ps3_system_bus_set_drvdata(dev, NULL); -- 1.7.9.5 -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 4/7] USB: EHCI: export ehci_shutdown
Hi Alan, Actually, I think this is not necessary. Instead those three glue files ought to be changed. They should not need to call ehci_shutdown() directly. I sent out a separate patch that removes the ehci_shutdown() call in ps3_ehci_remove(). I tested it by removing and installing the ehci_hcd module and it seems to work OK. -Geoff -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Webcam stops other USB devices (ehci_hcd: HC died; cleaning up)
Hi Alan, On Thu, 2012-05-17 at 11:40 -0400, Alan Stern wrote: On Thu, 17 May 2012, Geoff Levand wrote: I could just do some quick tests but found that with DEBUG defined and your change I see these with the port errors continuing on indefinitely. 7usb 2-2: link qh0-00ff/c0001bcbf480 start 0 [2/0 us] 7usb 1-1: unlink qh256-0001/c0001d181d00 start 1 [1/0 us] Those two lines look normal. 3hub 3-0:1.0: connect-debounce failed, port 1 disabled 3hub 3-0:1.0: over-current condition on port 2 4hub 3-0:1.0: config error on port 2 3hub 3-0:1.0: connect-debounce failed, port 2 disabled 7ps3-ehci-driver sb_06: GetStatus port:1 status 127 ERR POWER OWNER sig=? LPM RESET SUSPEND R 3ps3-ehci-driver sb_06: port 1 resume error -19 7ps3-ehci-driver sb_06: GetStatus port:1 status 127 ERR POWER OWNER sig=? LPM RESET SUSPEND R 3hub 1-0:1.0: over-current condition on port 1 3ps3-ehci-driver sb_06: port 2 resume error -19 7ps3-ehci-driver sb_06: GetStatus port:2 status 127 ERR POWER OWNER sig=? LPM RESET SUSPEND R 3ps3-ehci-driver sb_06: port 2 resume error -19 7ps3-ehci-driver sb_06: GetStatus port:2 status 127 ERR POWER OWNER sig=? LPM RESET SUSPEND R 3hub 1-0:1.0: over-current condition on port 2 7ps3-ehci-driver sb_06: GetStatus port:2 status 127 ERR POWER OWNER sig=? LPM RESET SUSPEND R 3ps3-ehci-driver sb_06: port 2 resume error -19 7ps3-ehci-driver sb_06: GetStatus port:2 status 127 ERR POWER OWNER sig=? LPM RESET SUSPEND R 3ps3-ehci-driver sb_06: port 2 resume error -19 ... It looks like the EHCI controllers are not powering on. All those values are what you get when you read an unpowered register. It doesn't seem like this could be related to the new patch. I'm puzzled. Let me know when you will have some more time available for testing. Some of the changes in that patch are now in the mainline kernel, which will make things easier. Just to follow this up and close it out, I didn't find time to look at this more, but some commit fixed this problem, and USB on PS3 started working around 3.4. If you are really interested in it I could try a bisect to locate when. -Geoff -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [patch] PS3: Fix EHCI ISO transfer bug
On 01/13/2008 09:36 AM, David Brownell wrote: Yes, please. The appended patch is that updated version. === CUT HERE From: David Brownell [EMAIL PROTECTED] This adds a workaround for an issue reported with ISO transfers on some EHCI controllers, most recently with VIA KT800 and PS3 EHCI silicon. The issue is that the silicon doesn't necessarily seem to be done using ISO DMA descriptors (itd, sitd) when it marks them inactive. (One theory is that the ill-defined mechanism where hardware caches periodic transfer descriptors isn't invalidating their state...) With such silicon, quick re-use of those descriptors makes trouble. Waiting until the next frame seems to be a sufficient workaround. This patch ensures that the relevant descriptors aren't available for immediate re-use. It does so by not recycling them until after issuing the completion callback which would reuse them by enqueueing an URB and thus (re)allocating ISO DMA descriptors. Signed-off-by: David Brownell [EMAIL PROTECTED] I tested this on PS3, and it seems to work OK. Acked-by: Geoff Levand [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
