RE: [PATCH v2 00/30] USB: omap-ehci: Move PHY management to PHY driver

2013-02-01 Thread Mohammed, Afzal
Hi Roger,

On Fri, Feb 01, 2013 at 20:01:38, Quadros, Roger wrote:

> but DT boot is not supported for OMAP USB Host. How did you get it to work?
> 
> Are you testing the Host connector or the OTG connector?

If you see latest changes on musb_dsps.c, you will be able to find
out.

As beagle bone first instance works only in device, it was tested
using ether gadget.

Regards
Afzal



RE: [PATCH v2 00/30] USB: omap-ehci: Move PHY management to PHY driver

2013-02-01 Thread Mohammed, Afzal
Hi Roger,

On Fri, Feb 01, 2013 at 19:55:14, Quadros, Roger wrote:

> Thanks Afzal :). You mean the non device tree boot right?

No, dt boot, am335x can only dt boot.

Regards
Afzal



RE: [PATCH v2 00/30] USB: omap-ehci: Move PHY management to PHY driver

2013-02-01 Thread Mohammed, Afzal
Hi Felipe, Roger,

On Wed, Jan 30, 2013 at 18:49:17, Mohammed, Afzal wrote:
> On Wed, Jan 30, 2013 at 18:45:04, Balbi, Felipe wrote:
> > On Wed, Jan 30, 2013 at 02:48:50PM +0200, Roger Quadros wrote:

> > > I would appreciate if someone who knows more about beaglebone can help
> > > with verification.

> > Right, Afzal if you have the bone could you help Roger validating ?

> I am not in a position to validate it, in the middle of another task.

Ok, I tested this, usb first instance of beagle bone works as in mainline.

Regards
Afzal



RE: [PATCH v2 00/30] USB: omap-ehci: Move PHY management to PHY driver

2013-01-30 Thread Mohammed, Afzal
Hi Felipe,

On Wed, Jan 30, 2013 at 18:45:04, Balbi, Felipe wrote:
> On Wed, Jan 30, 2013 at 02:48:50PM +0200, Roger Quadros wrote:

> > I would appreciate if someone who knows more about beaglebone can help
> > with verification.
> > 
> > I could find that Robert C Nelson (now in cc) is maintaining out of tree
> > patches for the beaglebone. Maybe he could help with verification?
> 
> Right, Afzal if you have the bone could you help Roger validating ?

I am not in a position to validate it, in the middle of another task.

Regards
Afzal



RE: [PATCH v2 00/30] USB: omap-ehci: Move PHY management to PHY driver

2013-01-30 Thread Mohammed, Afzal
Hi Roger,

On Wed, Jan 30, 2013 at 18:18:50, Quadros, Roger wrote:
> On 01/30/2013 02:08 PM, Mohammed, Afzal wrote:

> > Please try to ensure that beagle bone USB0 works with this.

> I do not have beaglebone with me and don't seem to find beaglebone
> board support in mainline.

Ok. Fyi, beagle bone is supported in mainline - it is dt boot.

Regards
Afzal

> I would appreciate if someone who knows more about beaglebone can help
> with verification.
> 
> I could find that Robert C Nelson (now in cc) is maintaining out of tree
> patches for the beaglebone. Maybe he could help with verification?



RE: [PATCH v2 00/30] USB: omap-ehci: Move PHY management to PHY driver

2013-01-30 Thread Mohammed, Afzal
Hi Roger,

On Mon, Jan 28, 2013 at 17:00:01, Quadros, Roger wrote:

> NOTE: Tested on 4460ES-B1 Panda and BeagleBoard C4 only. Other boards are only
> build tested.

Please try to ensure that beagle bone USB0 works with this.

Regards
Afzal



RE: [PATCH 1/3] usb: otg: nop: add dt support

2013-01-28 Thread Mohammed, Afzal
Hi Michael,

On Mon, Jan 28, 2013 at 03:10:05, Michael Grzeschik wrote:
> On Thu, Sep 27, 2012 at 11:15:05AM +0530, Afzal Mohammed wrote:

> > From: "B, Ravi" 
> > 
> > Added device tree support for nop transceiver driver and updated the
> > Documentation with device tree binding information for am33xx platform.
> > 
> > Signed-off-by: Ravi Babu 
> > Signed-off-by: Ajay Kumar Gupta 
> > Signed-off-by: Afzal Mohammed 

> What happend to that patch? It did not show up in any new series. Is it
> queued anywhere?

This patch was not required to get the single instance usb supported
on am335x.

Regards
Afzal

N�r��yb�X��ǧv�^�)޺{.n�+{��^n�r���z���h�&���G���h�(�階�ݢj"���m��z�ޖ���f���h���~�m�

RE: [PATCH v1 0/6] USB: Add support for multiple PHYs of same type

2013-01-25 Thread Mohammed, Afzal
Hi Kishon,

On Thu, Jan 24, 2013 at 17:21:45, Mohammed, Afzal wrote:
> On Wed, Jan 23, 2013 at 19:56:37, ABRAHAM, KISHON VIJAY wrote:
> > On Wednesday 23 January 2013 07:28 PM, Mohammed, Afzal wrote:

> > > USB first instance of am335x works in mainline as of now.
> 
> > Can you check if this series indeed breaks am335x?
> > 
> > Thanks for your help.
> 
> Do you have a tree having these changes, it would be easier for me.

I tried with your "omap5-with-palmas" branch that was mentioned in
the cover letter of your latest series (but couldn't find the commit
that you mentioned in the cover letter, HEAD of that branch that I
tested was "2c29519 ARM: dts: palmas: update dt data for palmas-usb")

usb first instance of am335x works as earlier.

Regards
Afzal

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


RE: [PATCH v1 0/6] USB: Add support for multiple PHYs of same type

2013-01-24 Thread Mohammed, Afzal
Hi Kishon,

On Wed, Jan 23, 2013 at 19:56:37, ABRAHAM, KISHON VIJAY wrote:
> On Wednesday 23 January 2013 07:28 PM, Mohammed, Afzal wrote:

> > USB first instance of am335x works in mainline as of now.

> Can you check if this series indeed breaks am335x?
> 
> Thanks for your help.

Do you have a tree having these changes, it would be easier for me.

Regards
Afzal




RE: [PATCH v1 0/6] USB: Add support for multiple PHYs of same type

2013-01-23 Thread Mohammed, Afzal
Hi Koen,

On Tue, Jan 22, 2013 at 22:32:56, Koen Kooi wrote:
 
> Actually it uses nop-phy as a phy, which is missing from 
> arch/arm/boot/dts/am33xx.dtsi, so mainline is already broken. But adding the 
> nop-phy to the DT is easy enough to patch in locally.

USB first instance of am335x works in mainline as of now.

Regards
Afzal


usb: multi phy support

2013-01-07 Thread Mohammed, Afzal
Hi Felipe,

AM335x SoC's used in boards like beagle bone has two instances of USB
modules (2.0) at the hardware level, each having a dedicated phy.
Currently in mainline, only one instance of USB is supported
(including a fix in your latest pull request). To support multi
instance, the biggest obstacle is lack of multi phy support for
usb phy's of same type.

Earlier Kishon was working on usb phy device tree support, later it was
seen that generic phy layer was preferred. And Kishon posted a couple of
versions on generic phy framework, latest being on 26th September 2012,
but I could not see follow up's on that series.

It seems Kishon is not now working on generic phy support. Let me know
your opinion/suggestions on supporting usb phy's of same type. We are
trying to get multi USB instance support in mainline for AM335x.

Regards
Afzal


RE: [PATCH] usb: musb: dsps: header movement build error fix

2012-12-12 Thread Mohammed, Afzal
Hi Felipe,

On Tue, Nov 27, 2012 at 20:15:22, Mohammed, Afzal wrote:

> "54db6ee ARM: OMAP2+: Introduce local usb.h" moved control module bit
> definitions from plat/usb.h (which dsps glue was using) to a local
> header in mach-omap2. And in parallel,
> "c68bb4c usb: musb: dsps: control module handling (quirk)" added
> control module handling capability to dsps glue driver that used
> those control module bit definitions.
> 
> Integration of above two changes would cause build error in musb dsps
> glue driver (they go through different trees upstream) as is seen now
> in linux-next. Fix it by adding necessary definitions in dsps glue
> driver.
> 
> Signed-off-by: Afzal Mohammed 
> ---

> This applies on top of your musb branch, please help this reach
> mainline along with other musb dsps changes for coming merge window
> so that they would not cause build error and so that we can have a
> working usb in mainline for am335x (beaglebone) at the earliest.

musb dsps build breaks in mainline now, this patch fixes it, can you
please help this change reach mainline.

Both commits mentioned above (control module quirk & usb header
movement) has reached mainline.

Regards
Afzal


RE: [PATCH/RESEND 0/2] usb: musb: am335x support part-2

2012-11-08 Thread Mohammed, Afzal
Hi Balbi,

On Thu, Nov 08, 2012 at 23:47:08, Balbi, Felipe wrote:
> On Tue, Nov 06, 2012 at 08:44:59PM +0530, Afzal Mohammed wrote:

> > This is a resend of remaining changes to get am335x usb working. These
> > were sent on 31 Oct with subject, "usb: musb: dsps: fixes for -rc.
> 
> there is no more time for this to reach -rc. Do we need it for v3.8
> merge window ?

Yes, we need it for 3.8, please consider it for inclusion in
3.8 merge window.

> > First one restores capability to support at least one instance of musb.
> > Without it, even a single instance can't be supported as change which
> > is reverted by it was made along with multi phy changes and nop
> > transciever dt support, both other changes didn't make it to mainline. 
> > 
> > Second one corrects binding document; changes were made in driver as
> > per review comments, but documentation was not updated.
> 
> second one is clearly not for -rc.

Ok, please consider both for merge window, without first one,
am335x (hence beagle bone) usb will not work.

Regards
Afzal


RE: [PATCH 0/5] usb: musb: am335x support

2012-11-03 Thread Mohammed, Afzal
Hi Daniel,

* Daniel Mack, November 03, 2012 1:06 AM:

> I'm testing these patches with an AM33xx board that has the first musb
> port wired to an USB type A plug, but it doesn't yet work for me.

> So there is no host interface registered. I'm unsure on how to fix this,
> and I didn't get an answer yet to that question when I asked Felipe
> about how interface drivers like dsps are supposed to act in order to
> get host mode back after the recent musb cleanups.

> What type of hardware do you test this with? Does host mode work for you?

To add to those details mentioned by Ravi,

This was tested on Beagle Bone with USB0 as usb-ethernet.

For purely Kernel part, this series is sufficient (along with
dependency mentioned in cover letter), considering
the fact that dt node is strictly not a part of Kernel.

To test this series, node for usbss should be present in dt.
Example in dt documentation can be pasted onto dtsi file
to get USB0 working.

Alternatively, you can fetch from,

git://gitorious.org/x0148406-public/linux-kernel.git usb

it has dt updated with usbss node.

Regards
Afzal--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


RE: [PATCH 0/5] musb: rebased series of patches for musb_dsps

2012-10-22 Thread Mohammed, Afzal
Hi Daniel,

* Daniel Mack, October 22, 2012 6:44 PM:

> [+ Sekhar, Vaibhav, Afzal]

> And what about these patches in general? I got bounces for the address
> Ajay Kumar Gupta  who is the original author of most
> of them, and I wonder whether he isn't working for TI (and consequently
> on this patch set) anymore?

Oh dear, we are intersecting at multiple places.

Once I am back from vacation next week, my highest priority is to get
USB support for am335x in mainline.

Remaining USB patches based over musb branch (last week) with
proper authorship can be seen
@ git://gitorious.org/x0148406-public/linux-kernel.git usb

Note: This is sent via exchange, I am sorry if the mail is not so readable.

Regards
Afzal
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


RE: query on [PATCH 2/3] usb: otg: add device tree support to otg library

2012-09-25 Thread Mohammed, Afzal
On Tue, Sep 25, 2012 at 16:21:39, ABRAHAM, KISHON VIJAY wrote:
> On Tue, Sep 25, 2012 at 2:24 PM, Marc Kleine-Budde  
> wrote:

> > I'm interested in to get these patches into the kernel soon. Kishon any
> > news on this patch?
> >
> >> Something like this would be required for USB support
> >> on beagle bone (AM335X), which has 2 phy's of same type.
> >>
> >> Or is the plan to use generic phy framework instead ?
> >
> > Yes, Kishon's patches look more generic than mine.
> Will post the next version by this week.

Thanks Marc and Kishon

Regards
Afzal


query on [PATCH 2/3] usb: otg: add device tree support to otg library

2012-09-25 Thread Mohammed, Afzal
Hi Marc,

This is a query regarding patch,
"usb: otg: add device tree support to otg library" [1]

It seems there is so far no consensus on this change.

Do you have ideas to proceed on this ? is there something
that I can help you to proceed on this ?

Something like this would be required for USB support
on beagle bone (AM335X), which has 2 phy's of same type.

Or is the plan to use generic phy framework instead ?

Regards
Afzal

[1] http://marc.info/?l=linux-usb&m=134574263632422&w=2

N�r��yb�X��ǧv�^�)޺{.n�+{��^n�r���z���h�&���G���h�(�階�ݢj"���m��z�ޖ���f���h���~�m�