RE: [PATCH] staging: pl2303: adding TD620 Device ID
Thanks for the feedback. I'll review and resubmit. -Original Message- From: Johan Hovold [mailto:jhov...@gmail.com] On Behalf Of Johan Hovold Sent: Wednesday, September 20, 2017 2:47 AM To: Schoon, Michael Cc: jo...@kernel.org; linux-usb@vger.kernel.org; Greg Kroah-Hartman Subject: Re: [PATCH] staging: pl2303: adding TD620 Device ID On Wed, Sep 20, 2017 at 08:15:38AM +0200, Greg Kroah-Hartman wrote: > On Tue, Sep 19, 2017 at 09:41:48PM +, Schoon, Michael wrote: > > Signed-off-by: Michael Schoon > > No changelog at all? I know I can't take patches like that, hopefully > Johan has the same rule :) Indeed, I do. Please also fix up the Subject; this driver does not live in staging so that should be "USB: serial: pl2303:" instead. Also try to keep any new id-defines you add sorted by PID. Thanks, Johan -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] staging: pl2303: adding TD620 Device ID
Signed-off-by: Michael Schoon
---
drivers/usb/serial/pl2303.c | 1 +
drivers/usb/serial/pl2303.h | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
index a585b47..eab0e55 100644
--- a/drivers/usb/serial/pl2303.c
+++ b/drivers/usb/serial/pl2303.c
@@ -94,6 +94,7 @@ static const struct usb_device_id id_table[] = {
{ USB_DEVICE(HP_VENDOR_ID, HP_LD960_PRODUCT_ID) },
{ USB_DEVICE(HP_VENDOR_ID, HP_LCM220_PRODUCT_ID) },
{ USB_DEVICE(HP_VENDOR_ID, HP_LCM960_PRODUCT_ID) },
+ { USB_DEVICE(HP_VENDOR_ID, HP_TD620_PRODUCT_ID) },
{ USB_DEVICE(CRESSI_VENDOR_ID, CRESSI_EDY_PRODUCT_ID) },
{ USB_DEVICE(ZEAGLE_VENDOR_ID, ZEAGLE_N2ITION3_PRODUCT_ID) },
{ USB_DEVICE(SONY_VENDOR_ID, SONY_QN3USB_PRODUCT_ID) },
diff --git a/drivers/usb/serial/pl2303.h b/drivers/usb/serial/pl2303.h
index 3b5a15d..ca0bfba 100644
--- a/drivers/usb/serial/pl2303.h
+++ b/drivers/usb/serial/pl2303.h
@@ -126,6 +126,7 @@
#define HP_LCM220_PRODUCT_ID 0x3139
#define HP_LCM960_PRODUCT_ID 0x3239
#define HP_LD220_PRODUCT_ID 0x3524
+#define HP_TD620_PRODUCT_ID 0x0956
/* Cressi Edy (diving computer) PC interface */
#define CRESSI_VENDOR_ID 0x04b8
--
2.7.4
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] Adding TD620 Device ID in PL2303
Sorry about that. How's this:
Please add support for HP TD620 Linear Display device to the pl2303 module.
The USB Device ID is 03f0:0956 for this 2x20 display.
--- drivers/usb/serial/pl2303.c.orig2017-07-14 13:43:59.029860481 -0500
+++ drivers/usb/serial/pl2303.c 2017-07-14 13:16:27.928149225 -0500
@@ -92,6 +92,7 @@ static const struct usb_device_id id_tab
{ USB_DEVICE(HP_VENDOR_ID, HP_LD960_PRODUCT_ID) },
{ USB_DEVICE(HP_VENDOR_ID, HP_LCM220_PRODUCT_ID) },
{ USB_DEVICE(HP_VENDOR_ID, HP_LCM960_PRODUCT_ID) },
+ { USB_DEVICE(HP_VENDOR_ID, HP_TD620_PRODUCT_ID) },
{ USB_DEVICE(CRESSI_VENDOR_ID, CRESSI_EDY_PRODUCT_ID) },
{ USB_DEVICE(ZEAGLE_VENDOR_ID, ZEAGLE_N2ITION3_PRODUCT_ID) },
{ USB_DEVICE(SONY_VENDOR_ID, SONY_QN3USB_PRODUCT_ID) },
--- drivers/usb/serial/pl2303.h.orig2017-07-14 13:44:08.893761456 -0500
+++ drivers/usb/serial/pl2303.h 2017-07-14 13:15:07.016508374 -0500
@@ -125,6 +125,7 @@
#define HP_LCM220_PRODUCT_ID 0x3139
#define HP_LCM960_PRODUCT_ID 0x3239
#define HP_LD220_PRODUCT_ID0x3524
+#define HP_TD620_PRODUCT_ID 0x0956
/* Cressi Edy (diving computer) PC interface */
#define CRESSI_VENDOR_ID 0x04b8
-Original Message-
From: Greg KH [mailto:gre...@linuxfoundation.org]
Sent: Monday, July 17, 2017 10:28 AM
To: Schoon, Michael
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH] Adding TD620 Device ID in PL2303
On Mon, Jul 17, 2017 at 03:19:10PM +0000, Schoon, Michael wrote:
> Please add support for HP TD620 Linear Display device to the pl2303
> module. The USB Device ID is 03f0:0956 for this 2x20 display.
>
> Changes to be committed:
> modified: drivers/usb/serial/pl2303.c
> modified: drivers/usb/serial/pl2303.h
>
Intersting indentation :(
Also, what is this "Changes to be..." line for?
And finally, did you run this through scripts/checkpatch.pl?
> --- drivers/usb/serial/pl2303.c 2017-07-14 13:16:27.928149225
> -0500
> +++ drivers/usb/serial/pl2303.c.orig 2017-07-14
> 13:43:59.029860481 -0500
> @@ -92,7 +92,6 @@ static const struct usb_device_id id_tab
> { USB_DEVICE(HP_VENDOR_ID, HP_LD960_PRODUCT_ID) },
> { USB_DEVICE(HP_VENDOR_ID, HP_LCM220_PRODUCT_ID) },
> { USB_DEVICE(HP_VENDOR_ID, HP_LCM960_PRODUCT_ID) },
> - { USB_DEVICE(HP_VENDOR_ID, HP_TD620_PRODUCT_ID) },
Well, now finally, your patch is backwards and whitespace damaged, making it
impossible to apply :(
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] Adding TD620 Device ID in PL2303
Please add support for HP TD620 Linear Display device to the pl2303 module.
The USB Device ID is 03f0:0956 for this 2x20 display.
Changes to be committed:
modified: drivers/usb/serial/pl2303.c
modified: drivers/usb/serial/pl2303.h
--- drivers/usb/serial/pl2303.c 2017-07-14 13:16:27.928149225 -0500
+++ drivers/usb/serial/pl2303.c.orig 2017-07-14 13:43:59.029860481
-0500
@@ -92,7 +92,6 @@ static const struct usb_device_id id_tab
{ USB_DEVICE(HP_VENDOR_ID, HP_LD960_PRODUCT_ID) },
{ USB_DEVICE(HP_VENDOR_ID, HP_LCM220_PRODUCT_ID) },
{ USB_DEVICE(HP_VENDOR_ID, HP_LCM960_PRODUCT_ID) },
- { USB_DEVICE(HP_VENDOR_ID, HP_TD620_PRODUCT_ID) },
{ USB_DEVICE(CRESSI_VENDOR_ID, CRESSI_EDY_PRODUCT_ID) },
{ USB_DEVICE(ZEAGLE_VENDOR_ID, ZEAGLE_N2ITION3_PRODUCT_ID) },
{ USB_DEVICE(SONY_VENDOR_ID, SONY_QN3USB_PRODUCT_ID) },
--- drivers/usb/serial/pl2303.h 2017-07-14 13:15:07.016508374 -0500
+++ drivers/usb/serial/pl2303.h.orig 2017-07-14 13:44:08.893761456
-0500
@@ -125,7 +125,6 @@
#define HP_LCM220_PRODUCT_ID 0x3139
#define HP_LCM960_PRODUCT_ID 0x3239
#define HP_LD220_PRODUCT_ID 0x3524
-#define HP_TD620_PRODUCT_ID 0x0956
/* Cressi Edy (diving computer) PC interface */
#define CRESSI_VENDOR_ID 0x04b8
Signed-off-by: Michael Schoon
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
