Re: [PATCH] USB: gadget: add "maxpacket_limit" field to struct usb_ep

2013-12-11 Thread Alan Stern
On Wed, 11 Dec 2013, Robert Baldyga wrote:

> This patch adds "maxpacket_limit" to struct usb_ep. This field contains
> maximum value of maxpacket supported by driver, and is set in driver probe.
> This value should be used by autoconfig() function, because value of field
> "maxpacket" is set to value from endpoint descriptor when endpoint becomes
> enabled. So when autoconfig() function will be called again for this endpoint,
> "maxpacket" value will contain wMaxPacketSize from descriptior instead of
> maximum packet size for this endpoint.
> 
> For this reason this patch adds new field "maxpacket_limit" which contains
> value of maximum packet size (which defines maximum endpoint capabilities).
> This value is used in ep_matches() function used by autoconfig().
> 
> Value of "maxpacket_limit" should be set in UDC driver probe function, using
> usb_ep_set_maxpacket_limit() function, defined in gadget.h. This function
> set choosen value to both "maxpacket_limit" and "maxpacket" fields.
> 
> This patch modifies UDC drivers by adding support for maxpacket_limit.

Why doesn't the patch modify the dummy-hcd UDC driver?

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH] USB: gadget: add "maxpacket_limit" field to struct usb_ep

2013-12-11 Thread Robert Baldyga
This patch adds "maxpacket_limit" to struct usb_ep. This field contains
maximum value of maxpacket supported by driver, and is set in driver probe.
This value should be used by autoconfig() function, because value of field
"maxpacket" is set to value from endpoint descriptor when endpoint becomes
enabled. So when autoconfig() function will be called again for this endpoint,
"maxpacket" value will contain wMaxPacketSize from descriptior instead of
maximum packet size for this endpoint.

For this reason this patch adds new field "maxpacket_limit" which contains
value of maximum packet size (which defines maximum endpoint capabilities).
This value is used in ep_matches() function used by autoconfig().

Value of "maxpacket_limit" should be set in UDC driver probe function, using
usb_ep_set_maxpacket_limit() function, defined in gadget.h. This function
set choosen value to both "maxpacket_limit" and "maxpacket" fields.

This patch modifies UDC drivers by adding support for maxpacket_limit.

Signed-off-by: Robert Baldyga 
Signed-off-by: Kyungmin Park 
---
 drivers/usb/gadget/amd5536udc.c |   15 +--
 drivers/usb/gadget/at91_udc.c   |   16 
 drivers/usb/gadget/atmel_usba_udc.c |5 +++--
 drivers/usb/gadget/bcm63xx_udc.c|4 ++--
 drivers/usb/gadget/epautoconf.c |6 +++---
 drivers/usb/gadget/fotg210-udc.c|3 ++-
 drivers/usb/gadget/fsl_udc_core.c   |5 +++--
 drivers/usb/gadget/fusb300_udc.c|4 ++--
 drivers/usb/gadget/goku_udc.c   |4 ++--
 drivers/usb/gadget/lpc32xx_udc.c|2 +-
 drivers/usb/gadget/m66592-udc.c |4 ++--
 drivers/usb/gadget/mv_udc_core.c|4 ++--
 drivers/usb/gadget/omap_udc.c   |3 ++-
 drivers/usb/gadget/pch_udc.c|6 +++---
 drivers/usb/gadget/pxa25x_udc.c |1 +
 drivers/usb/gadget/pxa27x_udc.c |5 -
 drivers/usb/gadget/r8a66597-udc.c   |4 ++--
 drivers/usb/gadget/s3c-hsotg.c  |2 +-
 drivers/usb/gadget/s3c-hsudc.c  |2 +-
 drivers/usb/gadget/s3c2410_udc.c|1 +
 include/linux/usb/gadget.h  |8 
 21 files changed, 62 insertions(+), 42 deletions(-)

diff --git a/drivers/usb/gadget/amd5536udc.c b/drivers/usb/gadget/amd5536udc.c
index 54a1e29..f487e0e 100644
--- a/drivers/usb/gadget/amd5536udc.c
+++ b/drivers/usb/gadget/amd5536udc.c
@@ -446,7 +446,7 @@ static void ep_init(struct udc_regs __iomem *regs, struct 
udc_ep *ep)
ep->ep.ops = &udc_ep_ops;
INIT_LIST_HEAD(&ep->queue);
 
-   ep->ep.maxpacket = (u16) ~0;
+   usb_ep_set_maxpacket_limit(&ep->ep,(u16) ~0);
/* set NAK */
tmp = readl(&ep->regs->ctl);
tmp |= AMD_BIT(UDC_EPCTL_SNAK);
@@ -1564,12 +1564,15 @@ static void udc_setup_endpoints(struct udc *dev)
}
/* EP0 max packet */
if (dev->gadget.speed == USB_SPEED_FULL) {
-   dev->ep[UDC_EP0IN_IX].ep.maxpacket = UDC_FS_EP0IN_MAX_PKT_SIZE;
-   dev->ep[UDC_EP0OUT_IX].ep.maxpacket =
-   UDC_FS_EP0OUT_MAX_PKT_SIZE;
+   usb_ep_set_maxpacket_limit(&dev->ep[UDC_EP0IN_IX].ep,
+  UDC_FS_EP0IN_MAX_PKT_SIZE);
+   usb_ep_set_maxpacket_limit(&dev->ep[UDC_EP0OUT_IX].ep,
+  UDC_FS_EP0OUT_MAX_PKT_SIZE);
} else if (dev->gadget.speed == USB_SPEED_HIGH) {
-   dev->ep[UDC_EP0IN_IX].ep.maxpacket = UDC_EP0IN_MAX_PKT_SIZE;
-   dev->ep[UDC_EP0OUT_IX].ep.maxpacket = UDC_EP0OUT_MAX_PKT_SIZE;
+   usb_ep_set_maxpacket_limit(&dev->ep[UDC_EP0IN_IX].ep,
+  UDC_EP0IN_MAX_PKT_SIZE);
+   usb_ep_set_maxpacket_limit(&dev->ep[UDC_EP0OUT_IX].ep,
+  UDC_EP0OUT_MAX_PKT_SIZE);
}
 
/*
diff --git a/drivers/usb/gadget/at91_udc.c b/drivers/usb/gadget/at91_udc.c
index 4cc4fd6..0353b64 100644
--- a/drivers/usb/gadget/at91_udc.c
+++ b/drivers/usb/gadget/at91_udc.c
@@ -834,7 +834,7 @@ static void udc_reinit(struct at91_udc *udc)
ep->ep.desc = NULL;
ep->stopped = 0;
ep->fifo_bank = 0;
-   ep->ep.maxpacket = ep->maxpacket;
+   usb_ep_set_maxpacket_limit(&ep->ep, ep->maxpacket);
ep->creg = (void __iomem *) udc->udp_baseaddr + AT91_UDP_CSR(i);
/* initialize one queue per endpoint */
INIT_LIST_HEAD(&ep->queue);
@@ -1759,15 +1759,15 @@ static int at91udc_probe(struct platform_device *pdev)
 
/* newer chips have more FIFO memory than rm9200 */
if (cpu_is_at91sam9260() || cpu_is_at91sam9g20()) {
-   udc->ep[0].maxpacket = 64;
-   udc->ep[3].maxpacket = 64;
-   udc->ep[4].maxpacket = 512;
-   udc->ep[5].maxpacket = 512;
+   usb_ep_set_maxpacket_limit(&udc->ep[0], 64);
+   usb_ep_set_maxpacket_li