Re: [PATCH] USB: serial: move the simple drivers into usb-serial-simple.c
On Mon, Aug 05, 2013 at 09:36:23AM -0500, Dan Williams wrote:
On Mon, 2013-08-05 at 19:41 +0800, Greg Kroah-Hartman wrote:
+/* All of the above structures mushed into two lists */
+static struct usb_serial_driver * const serial_drivers[] = {
+ zio_device,
+ funsoft_device,
+ flashloader_device,
+ vivopay_device,
+ moto_device,
Maybe moto_modem_device to preserve the module name? I don't
actually care either way, but using only moto_device here means
driver.name will now be different for these devices.
Good point, I've now changed it, thanks for the review.
greg k-h
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] USB: serial: move the simple drivers into usb-serial-simple.c
Flashloader looks good. I totally agree put all these kind of simple drivers into one 2013/8/5 Dan Williams d...@redhat.com: On Mon, 2013-08-05 at 19:41 +0800, Greg Kroah-Hartman wrote: From: Greg Kroah-Hartman gre...@linuxfoundation.org Instead of having to create a new driver for a simple usb to serial device, mush them all into one file, with a macro, so as to make it easy to add new ones. Cc: René Bürgel rene.buer...@sohard.de Cc: Wei Shuai cpuw...@gmail.com Cc: Josh Triplett j...@joshtriplett.org Cc: Frans Klaver frans.kla...@xsens.com Cc: Wesley W. Terpstra w.terps...@gsi.de Cc: Johan Hovold jhov...@gmail.com Signed-off-by: Greg Kroah-Hartman gre...@linuxfoundation.org --- Warning, compile tested only for now. drivers/usb/serial/Kconfig | 84 + drivers/usb/serial/Makefile|9 -- drivers/usb/serial/flashloader.c | 39 --- drivers/usb/serial/funsoft.c | 40 drivers/usb/serial/hp4x.c | 51 --- drivers/usb/serial/moto_modem.c| 48 -- drivers/usb/serial/siemens_mpi.c | 47 -- drivers/usb/serial/suunto.c| 41 drivers/usb/serial/usb-serial-simple.c | 110 + drivers/usb/serial/vivopay-serial.c| 43 drivers/usb/serial/zio.c | 39 --- 11 files changed, 129 insertions(+), 422 deletions(-) --- a/drivers/usb/serial/Kconfig +++ b/drivers/usb/serial/Kconfig @@ -51,6 +51,24 @@ config USB_SERIAL_GENERIC support be compiled as a module for this driver to be used properly. +config USB_SERIAL_SIMPLE + tristate USB Serial Simple Driver + help + Say Y here to use the USB serial simple driver. This driver + handles a wide range of very simple devices, all in one + driver. Specifically, it supports: + - Suunto ANT+ USB device. + - Fundamental Software dongle. + - HP4x calculators + - a number of Motoroloa phones + - Siemens USB/MPI adapter. + - ViVOtech ViVOpay USB device. + - Infineon Modem Flashloader USB interface + - ZIO Motherboard USB serial interface + + To compile this driver as a module, choose M here: the module + will be called usb-serial-simple. + config USB_SERIAL_AIRCABLE tristate USB AIRcable Bluetooth Dongle Driver help @@ -158,14 +176,6 @@ config USB_SERIAL_FTDI_SIO To compile this driver as a module, choose M here: the module will be called ftdi_sio. -config USB_SERIAL_FUNSOFT - tristate USB Fundamental Software Dongle Driver - ---help--- - Say Y here if you want to use the Fundamental Software dongle. - - To compile this driver as a module, choose M here: the - module will be called funsoft. - config USB_SERIAL_VISOR tristate USB Handspring Visor / Palm m50x / Sony Clie Driver help @@ -462,15 +472,6 @@ config USB_SERIAL_MOS7840 To compile this driver as a module, choose M here: the module will be called mos7840. If unsure, choose N. -config USB_SERIAL_MOTOROLA - tristate USB Motorola Phone modem driver - ---help--- - Say Y here if you want to use a Motorola phone with a USB - connector as a modem link. - - To compile this driver as a module, choose M here: the - module will be called moto_modem. If unsure, choose N. - config USB_SERIAL_NAVMAN tristate USB Navman GPS device help @@ -525,14 +526,6 @@ config USB_SERIAL_SPCP8X5 To compile this driver as a module, choose M here: the module will be called spcp8x5. -config USB_SERIAL_HP4X -tristate USB HP4x Calculators support -help - Say Y here if you want to use an Hewlett-Packard 4x Calculator. - - To compile this driver as a module, choose M here: the - module will be called hp4x. - config USB_SERIAL_SAFE tristate USB Safe Serial (Encapsulated) Driver @@ -540,14 +533,6 @@ config USB_SERIAL_SAFE_PADDED bool USB Secure Encapsulated Driver - Padded depends on USB_SERIAL_SAFE -config USB_SERIAL_SIEMENS_MPI - tristate USB Siemens MPI driver - help - Say M here if you want to use a Siemens USB/MPI adapter. - - To compile this driver as a module, choose M here: the - module will be called siemens_mpi. - config USB_SERIAL_SIERRAWIRELESS tristate USB Sierra Wireless Driver help @@ -639,14 +624,6 @@ config USB_SERIAL_OPTICON To compile this driver as a module, choose M here: the module will be called opticon. -config USB_SERIAL_VIVOPAY_SERIAL -tristate USB ViVOpay serial interface driver -help - Say Y here if you want to use a ViVOtech ViVOpay
[PATCH] USB: serial: move the simple drivers into usb-serial-simple.c
From: Greg Kroah-Hartman gre...@linuxfoundation.org Instead of having to create a new driver for a simple usb to serial device, mush them all into one file, with a macro, so as to make it easy to add new ones. Cc: René Bürgel rene.buer...@sohard.de Cc: Wei Shuai cpuw...@gmail.com Cc: Josh Triplett j...@joshtriplett.org Cc: Frans Klaver frans.kla...@xsens.com Cc: Wesley W. Terpstra w.terps...@gsi.de Cc: Johan Hovold jhov...@gmail.com Signed-off-by: Greg Kroah-Hartman gre...@linuxfoundation.org --- Warning, compile tested only for now. drivers/usb/serial/Kconfig | 84 + drivers/usb/serial/Makefile|9 -- drivers/usb/serial/flashloader.c | 39 --- drivers/usb/serial/funsoft.c | 40 drivers/usb/serial/hp4x.c | 51 --- drivers/usb/serial/moto_modem.c| 48 -- drivers/usb/serial/siemens_mpi.c | 47 -- drivers/usb/serial/suunto.c| 41 drivers/usb/serial/usb-serial-simple.c | 110 + drivers/usb/serial/vivopay-serial.c| 43 drivers/usb/serial/zio.c | 39 --- 11 files changed, 129 insertions(+), 422 deletions(-) --- a/drivers/usb/serial/Kconfig +++ b/drivers/usb/serial/Kconfig @@ -51,6 +51,24 @@ config USB_SERIAL_GENERIC support be compiled as a module for this driver to be used properly. +config USB_SERIAL_SIMPLE + tristate USB Serial Simple Driver + help + Say Y here to use the USB serial simple driver. This driver + handles a wide range of very simple devices, all in one + driver. Specifically, it supports: + - Suunto ANT+ USB device. + - Fundamental Software dongle. + - HP4x calculators + - a number of Motoroloa phones + - Siemens USB/MPI adapter. + - ViVOtech ViVOpay USB device. + - Infineon Modem Flashloader USB interface + - ZIO Motherboard USB serial interface + + To compile this driver as a module, choose M here: the module + will be called usb-serial-simple. + config USB_SERIAL_AIRCABLE tristate USB AIRcable Bluetooth Dongle Driver help @@ -158,14 +176,6 @@ config USB_SERIAL_FTDI_SIO To compile this driver as a module, choose M here: the module will be called ftdi_sio. -config USB_SERIAL_FUNSOFT - tristate USB Fundamental Software Dongle Driver - ---help--- - Say Y here if you want to use the Fundamental Software dongle. - - To compile this driver as a module, choose M here: the - module will be called funsoft. - config USB_SERIAL_VISOR tristate USB Handspring Visor / Palm m50x / Sony Clie Driver help @@ -462,15 +472,6 @@ config USB_SERIAL_MOS7840 To compile this driver as a module, choose M here: the module will be called mos7840. If unsure, choose N. -config USB_SERIAL_MOTOROLA - tristate USB Motorola Phone modem driver - ---help--- - Say Y here if you want to use a Motorola phone with a USB - connector as a modem link. - - To compile this driver as a module, choose M here: the - module will be called moto_modem. If unsure, choose N. - config USB_SERIAL_NAVMAN tristate USB Navman GPS device help @@ -525,14 +526,6 @@ config USB_SERIAL_SPCP8X5 To compile this driver as a module, choose M here: the module will be called spcp8x5. -config USB_SERIAL_HP4X -tristate USB HP4x Calculators support -help - Say Y here if you want to use an Hewlett-Packard 4x Calculator. - - To compile this driver as a module, choose M here: the - module will be called hp4x. - config USB_SERIAL_SAFE tristate USB Safe Serial (Encapsulated) Driver @@ -540,14 +533,6 @@ config USB_SERIAL_SAFE_PADDED bool USB Secure Encapsulated Driver - Padded depends on USB_SERIAL_SAFE -config USB_SERIAL_SIEMENS_MPI - tristate USB Siemens MPI driver - help - Say M here if you want to use a Siemens USB/MPI adapter. - - To compile this driver as a module, choose M here: the - module will be called siemens_mpi. - config USB_SERIAL_SIERRAWIRELESS tristate USB Sierra Wireless Driver help @@ -639,14 +624,6 @@ config USB_SERIAL_OPTICON To compile this driver as a module, choose M here: the module will be called opticon. -config USB_SERIAL_VIVOPAY_SERIAL -tristate USB ViVOpay serial interface driver -help - Say Y here if you want to use a ViVOtech ViVOpay USB device. - - To compile this driver as a module, choose M here: the - module will be called vivopay-serial. - config USB_SERIAL_XSENS_MT tristate Xsens motion
Re: [PATCH] USB: serial: move the simple drivers into usb-serial-simple.c
On Mon, 2013-08-05 at 19:41 +0800, Greg Kroah-Hartman wrote: From: Greg Kroah-Hartman gre...@linuxfoundation.org Instead of having to create a new driver for a simple usb to serial device, mush them all into one file, with a macro, so as to make it easy to add new ones. Cc: René Bürgel rene.buer...@sohard.de Cc: Wei Shuai cpuw...@gmail.com Cc: Josh Triplett j...@joshtriplett.org Cc: Frans Klaver frans.kla...@xsens.com Cc: Wesley W. Terpstra w.terps...@gsi.de Cc: Johan Hovold jhov...@gmail.com Signed-off-by: Greg Kroah-Hartman gre...@linuxfoundation.org --- Warning, compile tested only for now. drivers/usb/serial/Kconfig | 84 + drivers/usb/serial/Makefile|9 -- drivers/usb/serial/flashloader.c | 39 --- drivers/usb/serial/funsoft.c | 40 drivers/usb/serial/hp4x.c | 51 --- drivers/usb/serial/moto_modem.c| 48 -- drivers/usb/serial/siemens_mpi.c | 47 -- drivers/usb/serial/suunto.c| 41 drivers/usb/serial/usb-serial-simple.c | 110 + drivers/usb/serial/vivopay-serial.c| 43 drivers/usb/serial/zio.c | 39 --- 11 files changed, 129 insertions(+), 422 deletions(-) --- a/drivers/usb/serial/Kconfig +++ b/drivers/usb/serial/Kconfig @@ -51,6 +51,24 @@ config USB_SERIAL_GENERIC support be compiled as a module for this driver to be used properly. +config USB_SERIAL_SIMPLE + tristate USB Serial Simple Driver + help + Say Y here to use the USB serial simple driver. This driver + handles a wide range of very simple devices, all in one + driver. Specifically, it supports: + - Suunto ANT+ USB device. + - Fundamental Software dongle. + - HP4x calculators + - a number of Motoroloa phones + - Siemens USB/MPI adapter. + - ViVOtech ViVOpay USB device. + - Infineon Modem Flashloader USB interface + - ZIO Motherboard USB serial interface + + To compile this driver as a module, choose M here: the module + will be called usb-serial-simple. + config USB_SERIAL_AIRCABLE tristate USB AIRcable Bluetooth Dongle Driver help @@ -158,14 +176,6 @@ config USB_SERIAL_FTDI_SIO To compile this driver as a module, choose M here: the module will be called ftdi_sio. -config USB_SERIAL_FUNSOFT - tristate USB Fundamental Software Dongle Driver - ---help--- - Say Y here if you want to use the Fundamental Software dongle. - - To compile this driver as a module, choose M here: the - module will be called funsoft. - config USB_SERIAL_VISOR tristate USB Handspring Visor / Palm m50x / Sony Clie Driver help @@ -462,15 +472,6 @@ config USB_SERIAL_MOS7840 To compile this driver as a module, choose M here: the module will be called mos7840. If unsure, choose N. -config USB_SERIAL_MOTOROLA - tristate USB Motorola Phone modem driver - ---help--- - Say Y here if you want to use a Motorola phone with a USB - connector as a modem link. - - To compile this driver as a module, choose M here: the - module will be called moto_modem. If unsure, choose N. - config USB_SERIAL_NAVMAN tristate USB Navman GPS device help @@ -525,14 +526,6 @@ config USB_SERIAL_SPCP8X5 To compile this driver as a module, choose M here: the module will be called spcp8x5. -config USB_SERIAL_HP4X -tristate USB HP4x Calculators support -help - Say Y here if you want to use an Hewlett-Packard 4x Calculator. - - To compile this driver as a module, choose M here: the - module will be called hp4x. - config USB_SERIAL_SAFE tristate USB Safe Serial (Encapsulated) Driver @@ -540,14 +533,6 @@ config USB_SERIAL_SAFE_PADDED bool USB Secure Encapsulated Driver - Padded depends on USB_SERIAL_SAFE -config USB_SERIAL_SIEMENS_MPI - tristate USB Siemens MPI driver - help - Say M here if you want to use a Siemens USB/MPI adapter. - - To compile this driver as a module, choose M here: the - module will be called siemens_mpi. - config USB_SERIAL_SIERRAWIRELESS tristate USB Sierra Wireless Driver help @@ -639,14 +624,6 @@ config USB_SERIAL_OPTICON To compile this driver as a module, choose M here: the module will be called opticon. -config USB_SERIAL_VIVOPAY_SERIAL -tristate USB ViVOpay serial interface driver -help - Say Y here if you want to use a ViVOtech ViVOpay USB device. - - To compile this driver as a module, choose M here: the - module will
Re: [PATCH] USB: serial: move the simple drivers into usb-serial-simple.c
On Mon, Aug 05, 2013 at 07:41:42PM +0800, Greg Kroah-Hartman wrote: From: Greg Kroah-Hartman gre...@linuxfoundation.org Instead of having to create a new driver for a simple usb to serial device, mush them all into one file, with a macro, so as to make it easy to add new ones. Sounds like a sensible thing to do. Cheers, Frans -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
