Re: [PATCH] drivers/usb/host/ehci-xilinx-of.c: Include "linux/of_irq.h" to avoid compiling error
On 9/29/14 9:52, Greg Kroah-Hartman wrote: > On Wed, Sep 24, 2014 at 11:41:55AM -0400, Alan Stern wrote: >> On Mon, 22 Sep 2014, Michal Simek wrote: >> >>> Alan: Can you please add this patch to your queue? >>> Greg: If Alan is not maintaining this part of kernel, is this patch in your >>> queue? >>> >>> I have also not a problem to add this patch through my microblaze tree >>> but I think it will be much better to use any USB tree. >> >> Greg should be able to accept a trivial patch like this one directly. > > I can, if someone will resend it so I can apply it :) > This patch you have already applied (applied this patch in 2014-09-24), so I need not resend it. Thank all of you for your work. Thanks. -- Chen Gang Open, share, and attitude like air, water, and life which God blessed -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] drivers/usb/host/ehci-xilinx-of.c: Include "linux/of_irq.h" to avoid compiling error
On Wed, Sep 24, 2014 at 11:41:55AM -0400, Alan Stern wrote: > On Mon, 22 Sep 2014, Michal Simek wrote: > > > Hi Alan and Greg, > > > > On 09/20/2014 06:19 AM, Chen Gang wrote: > > > Hello Maintainers: > > > > > > Please help check this patch, when you have time. > > > > > > Thanks. > > > > > > On 09/08/2014 01:20 PM, Michal Simek wrote: > > >> On 09/03/2014 05:50 PM, Chen Gang wrote: > > >>> Need include it for irq_of_parse_and_map(), the related error with > > >>> allmodconfig under microblaze: > > >>> > > >>> drivers/usb/host/ehci-xilinx-of.c: In function > > >>> ?ehci_hcd_xilinx_of_probe?: > > >>> drivers/usb/host/ehci-xilinx-of.c:156:2: error: implicit declaration > > >>> of function ?irq_of_parse_and_map? > > >>> [-Werror=implicit-function-declaration] > > >>> irq = irq_of_parse_and_map(dn, 0); > > >>> ^ > > >>> > > >>> Signed-off-by: Chen Gang > > >>> --- > > >>> drivers/usb/host/ehci-xilinx-of.c | 1 + > > >>> 1 file changed, 1 insertion(+) > > >>> > > >>> diff --git a/drivers/usb/host/ehci-xilinx-of.c > > >>> b/drivers/usb/host/ehci-xilinx-of.c > > >>> index fe57710..a232836 100644 > > >>> --- a/drivers/usb/host/ehci-xilinx-of.c > > >>> +++ b/drivers/usb/host/ehci-xilinx-of.c > > >>> @@ -31,6 +31,7 @@ > > >>> #include > > >>> #include > > >>> #include > > >>> +#include > > >>> > > >>> /** > > >>> * ehci_xilinx_port_handed_over - hand the port out if failed to > > >>> enable it > > >>> > > >> > > >> Acked-by: Michal Simek > > > > Alan: Can you please add this patch to your queue? > > Greg: If Alan is not maintaining this part of kernel, is this patch in your > > queue? > > > > I have also not a problem to add this patch through my microblaze tree > > but I think it will be much better to use any USB tree. > > Greg should be able to accept a trivial patch like this one directly. I can, if someone will resend it so I can apply it :) thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] drivers/usb/host/ehci-xilinx-of.c: Include "linux/of_irq.h" to avoid compiling error
On Mon, 22 Sep 2014, Michal Simek wrote: > Hi Alan and Greg, > > On 09/20/2014 06:19 AM, Chen Gang wrote: > > Hello Maintainers: > > > > Please help check this patch, when you have time. > > > > Thanks. > > > > On 09/08/2014 01:20 PM, Michal Simek wrote: > >> On 09/03/2014 05:50 PM, Chen Gang wrote: > >>> Need include it for irq_of_parse_and_map(), the related error with > >>> allmodconfig under microblaze: > >>> > >>> drivers/usb/host/ehci-xilinx-of.c: In function > >>> �ehci_hcd_xilinx_of_probe�: > >>> drivers/usb/host/ehci-xilinx-of.c:156:2: error: implicit declaration of > >>> function �irq_of_parse_and_map� [-Werror=implicit-function-declaration] > >>> irq = irq_of_parse_and_map(dn, 0); > >>> ^ > >>> > >>> Signed-off-by: Chen Gang > >>> --- > >>> drivers/usb/host/ehci-xilinx-of.c | 1 + > >>> 1 file changed, 1 insertion(+) > >>> > >>> diff --git a/drivers/usb/host/ehci-xilinx-of.c > >>> b/drivers/usb/host/ehci-xilinx-of.c > >>> index fe57710..a232836 100644 > >>> --- a/drivers/usb/host/ehci-xilinx-of.c > >>> +++ b/drivers/usb/host/ehci-xilinx-of.c > >>> @@ -31,6 +31,7 @@ > >>> #include > >>> #include > >>> #include > >>> +#include > >>> > >>> /** > >>> * ehci_xilinx_port_handed_over - hand the port out if failed to enable > >>> it > >>> > >> > >> Acked-by: Michal Simek > > Alan: Can you please add this patch to your queue? > Greg: If Alan is not maintaining this part of kernel, is this patch in your > queue? > > I have also not a problem to add this patch through my microblaze tree > but I think it will be much better to use any USB tree. Greg should be able to accept a trivial patch like this one directly. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] drivers/usb/host/ehci-xilinx-of.c: Include "linux/of_irq.h" to avoid compiling error
Hi Alan and Greg, On 09/20/2014 06:19 AM, Chen Gang wrote: > Hello Maintainers: > > Please help check this patch, when you have time. > > Thanks. > > On 09/08/2014 01:20 PM, Michal Simek wrote: >> On 09/03/2014 05:50 PM, Chen Gang wrote: >>> Need include it for irq_of_parse_and_map(), the related error with >>> allmodconfig under microblaze: >>> >>> drivers/usb/host/ehci-xilinx-of.c: In function ‘ehci_hcd_xilinx_of_probe’: >>> drivers/usb/host/ehci-xilinx-of.c:156:2: error: implicit declaration of >>> function ‘irq_of_parse_and_map’ [-Werror=implicit-function-declaration] >>> irq = irq_of_parse_and_map(dn, 0); >>> ^ >>> >>> Signed-off-by: Chen Gang >>> --- >>> drivers/usb/host/ehci-xilinx-of.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/drivers/usb/host/ehci-xilinx-of.c >>> b/drivers/usb/host/ehci-xilinx-of.c >>> index fe57710..a232836 100644 >>> --- a/drivers/usb/host/ehci-xilinx-of.c >>> +++ b/drivers/usb/host/ehci-xilinx-of.c >>> @@ -31,6 +31,7 @@ >>> #include >>> #include >>> #include >>> +#include >>> >>> /** >>> * ehci_xilinx_port_handed_over - hand the port out if failed to enable it >>> >> >> Acked-by: Michal Simek Alan: Can you please add this patch to your queue? Greg: If Alan is not maintaining this part of kernel, is this patch in your queue? I have also not a problem to add this patch through my microblaze tree but I think it will be much better to use any USB tree. Thanks, Michal -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] drivers/usb/host/ehci-xilinx-of.c: Include "linux/of_irq.h" to avoid compiling error
Hello Maintainers: Please help check this patch, when you have time. Thanks. On 09/08/2014 01:20 PM, Michal Simek wrote: > On 09/03/2014 05:50 PM, Chen Gang wrote: >> Need include it for irq_of_parse_and_map(), the related error with >> allmodconfig under microblaze: >> >> drivers/usb/host/ehci-xilinx-of.c: In function ‘ehci_hcd_xilinx_of_probe’: >> drivers/usb/host/ehci-xilinx-of.c:156:2: error: implicit declaration of >> function ‘irq_of_parse_and_map’ [-Werror=implicit-function-declaration] >> irq = irq_of_parse_and_map(dn, 0); >> ^ >> >> Signed-off-by: Chen Gang >> --- >> drivers/usb/host/ehci-xilinx-of.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/usb/host/ehci-xilinx-of.c >> b/drivers/usb/host/ehci-xilinx-of.c >> index fe57710..a232836 100644 >> --- a/drivers/usb/host/ehci-xilinx-of.c >> +++ b/drivers/usb/host/ehci-xilinx-of.c >> @@ -31,6 +31,7 @@ >> #include >> #include >> #include >> +#include >> >> /** >> * ehci_xilinx_port_handed_over - hand the port out if failed to enable it >> > > Acked-by: Michal Simek > > Thanks, > Michal > -- Chen Gang Open, share, and attitude like air, water, and life which God blessed -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] drivers/usb/host/ehci-xilinx-of.c: Include "linux/of_irq.h" to avoid compiling error
On 09/03/2014 05:50 PM, Chen Gang wrote: > Need include it for irq_of_parse_and_map(), the related error with > allmodconfig under microblaze: > > drivers/usb/host/ehci-xilinx-of.c: In function ‘ehci_hcd_xilinx_of_probe’: > drivers/usb/host/ehci-xilinx-of.c:156:2: error: implicit declaration of > function ‘irq_of_parse_and_map’ [-Werror=implicit-function-declaration] > irq = irq_of_parse_and_map(dn, 0); > ^ > > Signed-off-by: Chen Gang > --- > drivers/usb/host/ehci-xilinx-of.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/host/ehci-xilinx-of.c > b/drivers/usb/host/ehci-xilinx-of.c > index fe57710..a232836 100644 > --- a/drivers/usb/host/ehci-xilinx-of.c > +++ b/drivers/usb/host/ehci-xilinx-of.c > @@ -31,6 +31,7 @@ > #include > #include > #include > +#include > > /** > * ehci_xilinx_port_handed_over - hand the port out if failed to enable it > Acked-by: Michal Simek Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/ Maintainer of Linux kernel - Xilinx Zynq ARM architecture Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform signature.asc Description: OpenPGP digital signature
[PATCH] drivers/usb/host/ehci-xilinx-of.c: Include "linux/of_irq.h" to avoid compiling error
Need include it for irq_of_parse_and_map(), the related error with allmodconfig under microblaze: drivers/usb/host/ehci-xilinx-of.c: In function ‘ehci_hcd_xilinx_of_probe’: drivers/usb/host/ehci-xilinx-of.c:156:2: error: implicit declaration of function ‘irq_of_parse_and_map’ [-Werror=implicit-function-declaration] irq = irq_of_parse_and_map(dn, 0); ^ Signed-off-by: Chen Gang --- drivers/usb/host/ehci-xilinx-of.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/host/ehci-xilinx-of.c b/drivers/usb/host/ehci-xilinx-of.c index fe57710..a232836 100644 --- a/drivers/usb/host/ehci-xilinx-of.c +++ b/drivers/usb/host/ehci-xilinx-of.c @@ -31,6 +31,7 @@ #include #include #include +#include /** * ehci_xilinx_port_handed_over - hand the port out if failed to enable it -- 1.9.3 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
