Re: [PATCH] usb: Fixed a few typos in comments
On Sat, Nov 22, 2014 at 01:14:51AM +0800, Mickael Maison wrote: > Fixed typos in comments of 2 drivers/usb/chipidea files > > Signed-off-by: Mickael Maison > --- > drivers/usb/chipidea/core.c| 2 +- > drivers/usb/chipidea/otg_fsm.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c > index 9bdc6bd..9401323 100644 > --- a/drivers/usb/chipidea/core.c > +++ b/drivers/usb/chipidea/core.c > @@ -472,7 +472,7 @@ static int ci_get_platdata(struct device *dev, > if (PTR_ERR(platdata->reg_vbus) == -EPROBE_DEFER) { > return -EPROBE_DEFER; > } else if (PTR_ERR(platdata->reg_vbus) == -ENODEV) { > - /* no vbus regualator is needed */ > + /* no vbus regulator is needed */ > platdata->reg_vbus = NULL; > } else if (IS_ERR(platdata->reg_vbus)) { > dev_err(dev, "Getting regulator error: %ld\n", > diff --git a/drivers/usb/chipidea/otg_fsm.c b/drivers/usb/chipidea/otg_fsm.c > index caaabc5..a8e0064 100644 > --- a/drivers/usb/chipidea/otg_fsm.c > +++ b/drivers/usb/chipidea/otg_fsm.c > @@ -303,7 +303,7 @@ static void a_wait_vfall_tmout_func(void *ptr, unsigned > long indicator) > set_tmout(ci, indicator); > /* Disable port power */ > hw_write(ci, OP_PORTSC, PORTSC_W1C_BITS | PORTSC_PP, 0); > - /* Clear exsiting DP irq */ > + /* Clear existing DP irq */ > hw_write_otgsc(ci, OTGSC_DPIS, OTGSC_DPIS); > /* Enable data pulse irq */ > hw_write_otgsc(ci, OTGSC_DPIE, OTGSC_DPIE); > @@ -663,7 +663,7 @@ static void ci_otg_fsm_event(struct ci_hdrc *ci) >fsm->b_bus_suspend = 1; > /* >* Init a timer to know how long this suspend > - * will contine, if time out, indicates B no longer > + * will continue, if time out, indicates B no longer >* wants to be host role >*/ >ci_otg_add_timer(ci, A_BIDL_ADIS); > -- > 1.9.1 > Thanks, would you change the prefix of subject, something like "usb: chipidea: xxx". -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] usb: Fixed a few typos in comments
Fixed typos in comments of 2 drivers/usb/chipidea files Signed-off-by: Mickael Maison --- drivers/usb/chipidea/core.c| 2 +- drivers/usb/chipidea/otg_fsm.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c index 9bdc6bd..9401323 100644 --- a/drivers/usb/chipidea/core.c +++ b/drivers/usb/chipidea/core.c @@ -472,7 +472,7 @@ static int ci_get_platdata(struct device *dev, if (PTR_ERR(platdata->reg_vbus) == -EPROBE_DEFER) { return -EPROBE_DEFER; } else if (PTR_ERR(platdata->reg_vbus) == -ENODEV) { - /* no vbus regualator is needed */ + /* no vbus regulator is needed */ platdata->reg_vbus = NULL; } else if (IS_ERR(platdata->reg_vbus)) { dev_err(dev, "Getting regulator error: %ld\n", diff --git a/drivers/usb/chipidea/otg_fsm.c b/drivers/usb/chipidea/otg_fsm.c index caaabc5..a8e0064 100644 --- a/drivers/usb/chipidea/otg_fsm.c +++ b/drivers/usb/chipidea/otg_fsm.c @@ -303,7 +303,7 @@ static void a_wait_vfall_tmout_func(void *ptr, unsigned long indicator) set_tmout(ci, indicator); /* Disable port power */ hw_write(ci, OP_PORTSC, PORTSC_W1C_BITS | PORTSC_PP, 0); - /* Clear exsiting DP irq */ + /* Clear existing DP irq */ hw_write_otgsc(ci, OTGSC_DPIS, OTGSC_DPIS); /* Enable data pulse irq */ hw_write_otgsc(ci, OTGSC_DPIE, OTGSC_DPIE); @@ -663,7 +663,7 @@ static void ci_otg_fsm_event(struct ci_hdrc *ci) fsm->b_bus_suspend = 1; /* * Init a timer to know how long this suspend -* will contine, if time out, indicates B no longer +* will continue, if time out, indicates B no longer * wants to be host role */ ci_otg_add_timer(ci, A_BIDL_ADIS); -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] usb: Fixed a few typos
On Thu, Sep 18, 2014 at 11:25:04AM +0200, Mickael Maison wrote: > Fixed typos in comments of various drivers/usb files > > Signed-off-by: Mickael Maison for MUSB: Acked-by: Felipe Balbi -- balbi signature.asc Description: Digital signature
[PATCH] usb: Fixed a few typos
Fixed typos in comments of various drivers/usb files Signed-off-by: Mickael Maison --- drivers/usb/core/hcd.c | 2 +- drivers/usb/musb/musb_regs.h | 2 +- drivers/usb/storage/realtek_cr.c | 4 ++-- drivers/usb/storage/scsiglue.c | 2 +- drivers/usb/storage/usb.c| 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c index 487abcf..56a0661 100644 --- a/drivers/usb/core/hcd.c +++ b/drivers/usb/core/hcd.c @@ -1272,7 +1272,7 @@ EXPORT_SYMBOL_GPL(usb_hcd_unlink_urb_from_ep); * The usb core itself is however optimized for host controllers that can dma * using regular system memory - like pci devices doing bus mastering. * - * To support host controllers with limited dma capabilites we provide dma + * To support host controllers with limited dma capabilities we provide dma * bounce buffers. This feature can be enabled using the HCD_LOCAL_MEM flag. * For this to work properly the host controller code must first use the * function dma_declare_coherent_memory() to point out which memory area diff --git a/drivers/usb/musb/musb_regs.h b/drivers/usb/musb/musb_regs.h index b9bcda5..37122a4 100644 --- a/drivers/usb/musb/musb_regs.h +++ b/drivers/usb/musb/musb_regs.h @@ -577,7 +577,7 @@ static inline u16 musb_read_hwvers(void __iomem *mbase) { /* * This register is invisible on Blackfin, actually the MUSB -* RTL version of Blackfin is 1.9, so just harcode its value. +* RTL version of Blackfin is 1.9, so just hardcode its value. */ return MUSB_HWVERS_1900; } diff --git a/drivers/usb/storage/realtek_cr.c b/drivers/usb/storage/realtek_cr.c index 281be56..8591d89 100644 --- a/drivers/usb/storage/realtek_cr.c +++ b/drivers/usb/storage/realtek_cr.c @@ -115,7 +115,7 @@ struct rts51x_chip { enum RTS51X_STAT state; int support_auto_delink; #endif - /* used to back up the protocal choosen in probe1 phase */ + /* used to back up the protocol chosen in probe1 phase */ proto_cmnd proto_handler_backup; }; @@ -925,7 +925,7 @@ static int realtek_cr_autosuspend_setup(struct us_data *us) (unsigned long)chip); fw5895_init(us); - /* enable autosuspend funciton of the usb device */ + /* enable autosuspend function of the usb device */ usb_enable_autosuspend(us->pusb_dev); return 0; diff --git a/drivers/usb/storage/scsiglue.c b/drivers/usb/storage/scsiglue.c index 866b5df..0e400f3 100644 --- a/drivers/usb/storage/scsiglue.c +++ b/drivers/usb/storage/scsiglue.c @@ -241,7 +241,7 @@ static int slave_configure(struct scsi_device *sdev) /* Some USB cardreaders have trouble reading an sdcard's last * sector in a larger then 1 sector read, since the performance -* impact is negible we set this flag for all USB disks */ +* impact is negligible we set this flag for all USB disks */ sdev->last_sector_bug = 1; /* Enable last-sector hacks for single-target devices using diff --git a/drivers/usb/storage/usb.c b/drivers/usb/storage/usb.c index cedb292..3aef968 100644 --- a/drivers/usb/storage/usb.c +++ b/drivers/usb/storage/usb.c @@ -98,7 +98,7 @@ MODULE_PARM_DESC(quirks, "supplemental list of device IDs and their quirks"); /* The vendor name should be kept at eight characters or less, and * the product name should be kept at 16 characters or less. If a device * has the US_FL_FIX_INQUIRY flag, then the vendor and product names - * normally generated by a device thorugh the INQUIRY response will be + * normally generated by a device through the INQUIRY response will be * taken from this list, and this is the reason for the above size * restriction. However, if the flag is not present, then you * are free to use as many characters as you like. -- 1.8.3.2 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] usb: Fixed a few typos
On Wed, Sep 17, 2014 at 09:16:25PM +0200, Mickael Maison wrote: you really wanna add a commit log here, even if obvious. Also, scripts/get_maintainer.pl would've told you to Cc me as the MUSB maintainer :-) No harm done though, just keep that in mind next time ;-) > Signed-off-by: Mickael Maison After adding a commit log, for musb: Acked-by: Felipe Balbi > diff --git a/drivers/usb/musb/musb_regs.h b/drivers/usb/musb/musb_regs.h > index b9bcda5..37122a4 100644 > --- a/drivers/usb/musb/musb_regs.h > +++ b/drivers/usb/musb/musb_regs.h > @@ -577,7 +577,7 @@ static inline u16 musb_read_hwvers(void __iomem *mbase) > { > /* >* This register is invisible on Blackfin, actually the MUSB > - * RTL version of Blackfin is 1.9, so just harcode its value. > + * RTL version of Blackfin is 1.9, so just hardcode its value. >*/ > return MUSB_HWVERS_1900; > } -- balbi signature.asc Description: Digital signature
[PATCH] usb: Fixed a few typos
Signed-off-by: Mickael Maison --- drivers/usb/core/hcd.c | 2 +- drivers/usb/musb/musb_regs.h | 2 +- drivers/usb/storage/realtek_cr.c | 4 ++-- drivers/usb/storage/scsiglue.c | 2 +- drivers/usb/storage/usb.c| 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c index 487abcf..56a0661 100644 --- a/drivers/usb/core/hcd.c +++ b/drivers/usb/core/hcd.c @@ -1272,7 +1272,7 @@ EXPORT_SYMBOL_GPL(usb_hcd_unlink_urb_from_ep); * The usb core itself is however optimized for host controllers that can dma * using regular system memory - like pci devices doing bus mastering. * - * To support host controllers with limited dma capabilites we provide dma + * To support host controllers with limited dma capabilities we provide dma * bounce buffers. This feature can be enabled using the HCD_LOCAL_MEM flag. * For this to work properly the host controller code must first use the * function dma_declare_coherent_memory() to point out which memory area diff --git a/drivers/usb/musb/musb_regs.h b/drivers/usb/musb/musb_regs.h index b9bcda5..37122a4 100644 --- a/drivers/usb/musb/musb_regs.h +++ b/drivers/usb/musb/musb_regs.h @@ -577,7 +577,7 @@ static inline u16 musb_read_hwvers(void __iomem *mbase) { /* * This register is invisible on Blackfin, actually the MUSB -* RTL version of Blackfin is 1.9, so just harcode its value. +* RTL version of Blackfin is 1.9, so just hardcode its value. */ return MUSB_HWVERS_1900; } diff --git a/drivers/usb/storage/realtek_cr.c b/drivers/usb/storage/realtek_cr.c index 281be56..8591d89 100644 --- a/drivers/usb/storage/realtek_cr.c +++ b/drivers/usb/storage/realtek_cr.c @@ -115,7 +115,7 @@ struct rts51x_chip { enum RTS51X_STAT state; int support_auto_delink; #endif - /* used to back up the protocal choosen in probe1 phase */ + /* used to back up the protocol chosen in probe1 phase */ proto_cmnd proto_handler_backup; }; @@ -925,7 +925,7 @@ static int realtek_cr_autosuspend_setup(struct us_data *us) (unsigned long)chip); fw5895_init(us); - /* enable autosuspend funciton of the usb device */ + /* enable autosuspend function of the usb device */ usb_enable_autosuspend(us->pusb_dev); return 0; diff --git a/drivers/usb/storage/scsiglue.c b/drivers/usb/storage/scsiglue.c index 866b5df..0e400f3 100644 --- a/drivers/usb/storage/scsiglue.c +++ b/drivers/usb/storage/scsiglue.c @@ -241,7 +241,7 @@ static int slave_configure(struct scsi_device *sdev) /* Some USB cardreaders have trouble reading an sdcard's last * sector in a larger then 1 sector read, since the performance -* impact is negible we set this flag for all USB disks */ +* impact is negligible we set this flag for all USB disks */ sdev->last_sector_bug = 1; /* Enable last-sector hacks for single-target devices using diff --git a/drivers/usb/storage/usb.c b/drivers/usb/storage/usb.c index cedb292..3aef968 100644 --- a/drivers/usb/storage/usb.c +++ b/drivers/usb/storage/usb.c @@ -98,7 +98,7 @@ MODULE_PARM_DESC(quirks, "supplemental list of device IDs and their quirks"); /* The vendor name should be kept at eight characters or less, and * the product name should be kept at 16 characters or less. If a device * has the US_FL_FIX_INQUIRY flag, then the vendor and product names - * normally generated by a device thorugh the INQUIRY response will be + * normally generated by a device through the INQUIRY response will be * taken from this list, and this is the reason for the above size * restriction. However, if the flag is not present, then you * are free to use as many characters as you like. -- 1.8.3.2 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] [usb] Fixed a few typos
Signed-off-by: Mickael Maison --- drivers/usb/gadget/mv_udc_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/mv_udc_core.c b/drivers/usb/gadget/mv_udc_core.c index fcff3a5..040fb16 100644 --- a/drivers/usb/gadget/mv_udc_core.c +++ b/drivers/usb/gadget/mv_udc_core.c @@ -332,7 +332,7 @@ static int queue_dtd(struct mv_ep *ep, struct mv_req *req) /* clear active and halt bit, in case set from a previous error */ dqh->size_ioc_int_sts &= ~(DTD_STATUS_ACTIVE | DTD_STATUS_HALTED); - /* Ensure that updates to the QH will occure before priming. */ + /* Ensure that updates to the QH will occur before priming. */ wmb(); /* Prime the Endpoint */ @@ -1656,7 +1656,7 @@ static void handle_setup_packet(struct mv_udc *udc, u8 ep_num, dev_dbg(&udc->dev->dev, "SETUP %02x.%02x v%04x i%04x l%04x\n", setup->bRequestType, setup->bRequest, setup->wValue, setup->wIndex, setup->wLength); - /* We process some stardard setup requests here */ + /* We process some standard setup requests here */ if ((setup->bRequestType & USB_TYPE_MASK) == USB_TYPE_STANDARD) { switch (setup->bRequest) { case USB_REQ_GET_STATUS: -- 1.8.3.2 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] [usb] Fixed a few typos
On Sat, May 24, 2014 at 10:35:24PM +0200, Mickael Maison wrote: > Signed-off-by: Mickael Maison > --- > drivers/usb/gadget/mv_udc_core.c | 4 ++-- > drivers/usb/gadget/s3c-hsotg.c | 2 +- > drivers/usb/usb-common.c | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) This patch doesn't apply at all to my usb-next branch of usb.git as some of these files aren't even around anymore :( Please redo it against that tree and resend. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] [usb] Fixed a few typos
Signed-off-by: Mickael Maison --- drivers/usb/gadget/mv_udc_core.c | 4 ++-- drivers/usb/gadget/s3c-hsotg.c | 2 +- drivers/usb/usb-common.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/usb/gadget/mv_udc_core.c b/drivers/usb/gadget/mv_udc_core.c index fcff3a5..040fb16 100644 --- a/drivers/usb/gadget/mv_udc_core.c +++ b/drivers/usb/gadget/mv_udc_core.c @@ -332,7 +332,7 @@ static int queue_dtd(struct mv_ep *ep, struct mv_req *req) /* clear active and halt bit, in case set from a previous error */ dqh->size_ioc_int_sts &= ~(DTD_STATUS_ACTIVE | DTD_STATUS_HALTED); - /* Ensure that updates to the QH will occure before priming. */ + /* Ensure that updates to the QH will occur before priming. */ wmb(); /* Prime the Endpoint */ @@ -1656,7 +1656,7 @@ static void handle_setup_packet(struct mv_udc *udc, u8 ep_num, dev_dbg(&udc->dev->dev, "SETUP %02x.%02x v%04x i%04x l%04x\n", setup->bRequestType, setup->bRequest, setup->wValue, setup->wIndex, setup->wLength); - /* We process some stardard setup requests here */ + /* We process some standard setup requests here */ if ((setup->bRequestType & USB_TYPE_MASK) == USB_TYPE_STANDARD) { switch (setup->bRequest) { case USB_REQ_GET_STATUS: diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb/gadget/s3c-hsotg.c index 2a9cb67..3fd34b7 100644 --- a/drivers/usb/gadget/s3c-hsotg.c +++ b/drivers/usb/gadget/s3c-hsotg.c @@ -2958,7 +2958,7 @@ static void s3c_hsotg_phy_disable(struct s3c_hsotg *hsotg) } /** - * s3c_hsotg_init - initalize the usb core + * s3c_hsotg_init - initialize the usb core * @hsotg: The driver state */ static void s3c_hsotg_init(struct s3c_hsotg *hsotg) diff --git a/drivers/usb/usb-common.c b/drivers/usb/usb-common.c index 6dfd30a..268f345 100644 --- a/drivers/usb/usb-common.c +++ b/drivers/usb/usb-common.c @@ -94,7 +94,7 @@ static const char *const usb_dr_modes[] = { * @np:Pointer to the given device_node * * The function gets phy interface string from property 'dr_mode', - * and returns the correspondig enum usb_dr_mode + * and returns the corresponding enum usb_dr_mode */ enum usb_dr_mode of_usb_get_dr_mode(struct device_node *np) { -- 1.8.3.2 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] [usb] Fixed a few typos
On Sat, May 24, 2014 at 04:44:22PM +0200, Mickael Maison wrote: > --- > drivers/usb/gadget/mv_udc_core.c | 4 ++-- > drivers/usb/gadget/s3c-hsotg.c | 2 +- > drivers/usb/usb-common.c | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) Always run your patches through scripts/checkpatch.pl before sending them so that we don't have to point out the issues that it reports automatically :) thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] [usb] Fixed a few typos
--- drivers/usb/gadget/mv_udc_core.c | 4 ++-- drivers/usb/gadget/s3c-hsotg.c | 2 +- drivers/usb/usb-common.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/usb/gadget/mv_udc_core.c b/drivers/usb/gadget/mv_udc_core.c index fcff3a5..040fb16 100644 --- a/drivers/usb/gadget/mv_udc_core.c +++ b/drivers/usb/gadget/mv_udc_core.c @@ -332,7 +332,7 @@ static int queue_dtd(struct mv_ep *ep, struct mv_req *req) /* clear active and halt bit, in case set from a previous error */ dqh->size_ioc_int_sts &= ~(DTD_STATUS_ACTIVE | DTD_STATUS_HALTED); - /* Ensure that updates to the QH will occure before priming. */ + /* Ensure that updates to the QH will occur before priming. */ wmb(); /* Prime the Endpoint */ @@ -1656,7 +1656,7 @@ static void handle_setup_packet(struct mv_udc *udc, u8 ep_num, dev_dbg(&udc->dev->dev, "SETUP %02x.%02x v%04x i%04x l%04x\n", setup->bRequestType, setup->bRequest, setup->wValue, setup->wIndex, setup->wLength); - /* We process some stardard setup requests here */ + /* We process some standard setup requests here */ if ((setup->bRequestType & USB_TYPE_MASK) == USB_TYPE_STANDARD) { switch (setup->bRequest) { case USB_REQ_GET_STATUS: diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb/gadget/s3c-hsotg.c index 2a9cb67..3fd34b7 100644 --- a/drivers/usb/gadget/s3c-hsotg.c +++ b/drivers/usb/gadget/s3c-hsotg.c @@ -2958,7 +2958,7 @@ static void s3c_hsotg_phy_disable(struct s3c_hsotg *hsotg) } /** - * s3c_hsotg_init - initalize the usb core + * s3c_hsotg_init - initialize the usb core * @hsotg: The driver state */ static void s3c_hsotg_init(struct s3c_hsotg *hsotg) diff --git a/drivers/usb/usb-common.c b/drivers/usb/usb-common.c index 6dfd30a..268f345 100644 --- a/drivers/usb/usb-common.c +++ b/drivers/usb/usb-common.c @@ -94,7 +94,7 @@ static const char *const usb_dr_modes[] = { * @np:Pointer to the given device_node * * The function gets phy interface string from property 'dr_mode', - * and returns the correspondig enum usb_dr_mode + * and returns the corresponding enum usb_dr_mode */ enum usb_dr_mode of_usb_get_dr_mode(struct device_node *np) { -- 1.8.3.2 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html