Re: [PATCH] usb: dwc3: cleanup DWC3_DCTL_LSFTRST bit
Hi Felipe, On Wed, May 29, 2013 at 01:25:59AM +0800, Felipe Balbi wrote: On Tue, May 28, 2013 at 03:42:50PM +0800, Huang Rui wrote: This bit is removed and set as reserved in 2.50a spec. Signed-off-by: Huang Rui ray.hu...@amd.com so ? This driver also works on older versions of the core. What you should do is, perhaps, add a comment saying that this bit shouldn't be used in v2.50a+, then we need to keep an eye for any future users of that bit and make sure that there is proper revision detection around it. Thanks to your reply. I greped codes, in current driver didn't use this bit, and I saw that the bit is marked as reserved in 2.50a spec. I don't confirm this bit should use in v2.50a+, if it will be used or I was wrong, please correct me. I just looked at register mapping, and compared with spec and found this bit is reserved, so I send this patch to remove this define to prevent to confuse. :) Best Regards, Rui -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] usb: dwc3: cleanup DWC3_DCTL_LSFTRST bit
Hi, On Wed, May 29, 2013 at 02:05:43PM +0800, Huang Rui wrote: Hi Felipe, On Wed, May 29, 2013 at 01:25:59AM +0800, Felipe Balbi wrote: On Tue, May 28, 2013 at 03:42:50PM +0800, Huang Rui wrote: This bit is removed and set as reserved in 2.50a spec. Signed-off-by: Huang Rui ray.hu...@amd.com so ? This driver also works on older versions of the core. What you should do is, perhaps, add a comment saying that this bit shouldn't be used in v2.50a+, then we need to keep an eye for any future users of that bit and make sure that there is proper revision detection around it. Thanks to your reply. I greped codes, in current driver didn't use this bit, and I saw that the bit is marked as reserved in 2.50a spec. I don't confirm this bit should use in v2.50a+, if it will be used or I was wrong, please correct me. I just looked at register mapping, and compared with spec and found this bit is reserved, so I send this patch to remove this define to prevent to confuse. :) it's reserved for 2.50a, what about all the older versions ? What if some older version needs light soft-reset ? -- balbi signature.asc Description: Digital signature
Re: [PATCH] usb: dwc3: cleanup DWC3_DCTL_LSFTRST bit
On Thu, May 30, 2013 at 01:40:39AM +0800, Felipe Balbi wrote: Hi, On Wed, May 29, 2013 at 02:05:43PM +0800, Huang Rui wrote: Hi Felipe, On Wed, May 29, 2013 at 01:25:59AM +0800, Felipe Balbi wrote: On Tue, May 28, 2013 at 03:42:50PM +0800, Huang Rui wrote: This bit is removed and set as reserved in 2.50a spec. Signed-off-by: Huang Rui ray.hu...@amd.com so ? This driver also works on older versions of the core. What you should do is, perhaps, add a comment saying that this bit shouldn't be used in v2.50a+, then we need to keep an eye for any future users of that bit and make sure that there is proper revision detection around it. Thanks to your reply. I greped codes, in current driver didn't use this bit, and I saw that the bit is marked as reserved in 2.50a spec. I don't confirm this bit should use in v2.50a+, if it will be used or I was wrong, please correct me. I just looked at register mapping, and compared with spec and found this bit is reserved, so I send this patch to remove this define to prevent to confuse. :) it's reserved for 2.50a, what about all the older versions ? What if some older version needs light soft-reset ? I got it, you're right. Thanks to your reminder. Rui -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] usb: dwc3: cleanup DWC3_DCTL_LSFTRST bit
This bit is removed and set as reserved in 2.50a spec. Signed-off-by: Huang Rui ray.hu...@amd.com --- drivers/usb/dwc3/core.h |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h index b69d322..4e6e0f9 100644 --- a/drivers/usb/dwc3/core.h +++ b/drivers/usb/dwc3/core.h @@ -223,7 +223,6 @@ /* Device Control Register */ #define DWC3_DCTL_RUN_STOP (1 31) #define DWC3_DCTL_CSFTRST (1 30) -#define DWC3_DCTL_LSFTRST (1 29) #define DWC3_DCTL_HIRD_THRES_MASK (0x1f 24) #define DWC3_DCTL_HIRD_THRES(n)((n) 24) -- 1.7.10.4 -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] usb: dwc3: cleanup DWC3_DCTL_LSFTRST bit
On Tue, May 28, 2013 at 03:42:50PM +0800, Huang Rui wrote: This bit is removed and set as reserved in 2.50a spec. Signed-off-by: Huang Rui ray.hu...@amd.com so ? This driver also works on older versions of the core. What you should do is, perhaps, add a comment saying that this bit shouldn't be used in v2.50a+, then we need to keep an eye for any future users of that bit and make sure that there is proper revision detection around it. -- balbi signature.asc Description: Digital signature
