Re: [PATCH] usb: phy-tegra-usb.c: wrong pointer check for remap UTMI

2013-12-04 Thread Thierry Reding 
On Wed, Dec 04, 2013 at 10:02:44AM +0800, Chris Ruehl wrote:
> usb: phy-tegra-usb.c: wrong pointer check for remap UTMI
> 
> A wrong pointer was used to test the result of devm_ioremap()
> 
> Signed-off-by: Chris Ruehl 
> Acked-by: Venu Byravarasu 
> ---
>  drivers/usb/phy/phy-tegra-usb.c |2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Thierry Reding 


pgpztN5vkmcF9.pgp
Description: PGP signature

RE: [PATCH] usb: phy-tegra-usb.c: wrong pointer check for remap UTMI

2013-12-03 Thread Venu Byravarasu 
Hi Stephen,

Initially Chris sent this patch to Linux-USB alias alone & there I Acked it.
Plz check http://marc.info/?l=linux-usb&m=138475663023376&w=1 

Then he resent the patch to linux-kernel alias with my ACK added.

Thanks,
Venu


> -Original Message-
> From: Stephen Warren [mailto:swar...@wwwdotorg.org]
> Sent: Wednesday, December 04, 2013 9:29 AM
> To: Chris Ruehl; ba...@ti.com
> Cc: gre...@linuxfoundation.org; thierry.red...@gmail.com; linux-
> u...@vger.kernel.org; linux-te...@vger.kernel.org; linux-
> ker...@vger.kernel.org; Venu Byravarasu
> Subject: Re: [PATCH] usb: phy-tegra-usb.c: wrong pointer check for remap
> UTMI
> 
> On 12/03/2013 07:02 PM, Chris Ruehl wrote:
> > usb: phy-tegra-usb.c: wrong pointer check for remap UTMI
> >
> > A wrong pointer was used to test the result of devm_ioremap()
> >
> > Signed-off-by: Chris Ruehl 
> > Acked-by: Venu Byravarasu 
> 
> Out of curiosity, when did that ack happen? I didn't see it. But anyway,
> 
> Acked-by: Stephen Warren 

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] usb: phy-tegra-usb.c: wrong pointer check for remap UTMI

2013-12-03 Thread Stephen Warren 
On 12/03/2013 07:02 PM, Chris Ruehl wrote:
> usb: phy-tegra-usb.c: wrong pointer check for remap UTMI
> 
> A wrong pointer was used to test the result of devm_ioremap()
> 
> Signed-off-by: Chris Ruehl 
> Acked-by: Venu Byravarasu 

Out of curiosity, when did that ack happen? I didn't see it. But anyway,

Acked-by: Stephen Warren 

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] usb: phy-tegra-usb.c: wrong pointer check for remap UTMI

2013-12-03 Thread Chris Ruehl 
usb: phy-tegra-usb.c: wrong pointer check for remap UTMI

A wrong pointer was used to test the result of devm_ioremap()

Signed-off-by: Chris Ruehl 
Acked-by: Venu Byravarasu 
---
 drivers/usb/phy/phy-tegra-usb.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/phy/phy-tegra-usb.c b/drivers/usb/phy/phy-tegra-usb.c
index 82232ac..bbe4f8e 100644
--- a/drivers/usb/phy/phy-tegra-usb.c
+++ b/drivers/usb/phy/phy-tegra-usb.c
@@ -876,7 +876,7 @@ static int utmi_phy_probe(struct tegra_usb_phy *tegra_phy,
 
tegra_phy->pad_regs = devm_ioremap(&pdev->dev, res->start,
resource_size(res));
-   if (!tegra_phy->regs) {
+   if (!tegra_phy->pad_regs) {
dev_err(&pdev->dev, "Failed to remap UTMI Pad regs\n");
return -ENOMEM;
}
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html