Re: [PATCH] usb: renesas: gadget: fixup: complete STATUS stage after receiving

[Kuninori Morimoto]

ping ?

> From: Kuninori Morimoto 
> 
> Current usbhs gadget driver didn't complete STATUS stage after receiving.
> It wasn't problem for us before, because some USB class doesn't use
> DATA OUT stage in control transfer.
> But, it is required on some device.
> 
> Signed-off-by: Yoshihiro Shimoda 
> Signed-off-by: Kuninori Morimoto 
> ---
>  drivers/usb/renesas_usbhs/fifo.c |8 
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/usb/renesas_usbhs/fifo.c 
> b/drivers/usb/renesas_usbhs/fifo.c
> index d49f9c3..4fd3653 100644
> --- a/drivers/usb/renesas_usbhs/fifo.c
> +++ b/drivers/usb/renesas_usbhs/fifo.c
> @@ -681,6 +681,14 @@ usbhs_fifo_read_end:
>   usbhs_pipe_number(pipe),
>   pkt->length, pkt->actual, *is_done, pkt->zero);
>  
> + /*
> +  * Transmission end
> +  */
> + if (*is_done) {
> + if (usbhs_pipe_is_dcp(pipe))
> + usbhs_dcp_control_transfer_done(pipe);
> + }
> +
>  usbhs_fifo_read_busy:
>   usbhsf_fifo_unselect(pipe, fifo);
>  
> -- 
> 1.7.9.5
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] usb: renesas: gadget: fixup: complete STATUS stage after receiving

[Kuninori Morimoto]

Hi Sergei

> > +   /*
> > +* Transmission end
> > +*/
> > +   if (*is_done) {
> > +   if (usbhs_pipe_is_dcp(pipe))
> 
> Why not collapse these into single *if*? That would decrease the 
> indentation level...

This is same style with TX case

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] usb: renesas: gadget: fixup: complete STATUS stage after receiving

[Sergei Shtylyov]

Hello.

On 02-06-2014 7:31, Kuninori Morimoto wrote:


From: Kuninori Morimoto 



Current usbhs gadget driver didn't complete STATUS stage after receiving.
It wasn't problem for us before, because some USB class doesn't use
DATA OUT stage in control transfer.
But, it is required on some device.



Signed-off-by: Yoshihiro Shimoda 
Signed-off-by: Kuninori Morimoto 
---
  drivers/usb/renesas_usbhs/fifo.c |8 
  1 file changed, 8 insertions(+)



diff --git a/drivers/usb/renesas_usbhs/fifo.c b/drivers/usb/renesas_usbhs/fifo.c
index d49f9c3..4fd3653 100644
--- a/drivers/usb/renesas_usbhs/fifo.c
+++ b/drivers/usb/renesas_usbhs/fifo.c
@@ -681,6 +681,14 @@ usbhs_fifo_read_end:
usbhs_pipe_number(pipe),
pkt->length, pkt->actual, *is_done, pkt->zero);

+   /*
+* Transmission end
+*/
+   if (*is_done) {
+   if (usbhs_pipe_is_dcp(pipe))


   Why not collapse these into single *if*? That would decrease the 
indentation level...



+   usbhs_dcp_control_transfer_done(pipe);
+   }
+
  usbhs_fifo_read_busy:
usbhsf_fifo_unselect(pipe, fifo);


WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] usb: renesas: gadget: fixup: complete STATUS stage after receiving

[Kuninori Morimoto]

From: Kuninori Morimoto 

Current usbhs gadget driver didn't complete STATUS stage after receiving.
It wasn't problem for us before, because some USB class doesn't use
DATA OUT stage in control transfer.
But, it is required on some device.

Signed-off-by: Yoshihiro Shimoda 
Signed-off-by: Kuninori Morimoto 
---
 drivers/usb/renesas_usbhs/fifo.c |8 
 1 file changed, 8 insertions(+)

diff --git a/drivers/usb/renesas_usbhs/fifo.c b/drivers/usb/renesas_usbhs/fifo.c
index d49f9c3..4fd3653 100644
--- a/drivers/usb/renesas_usbhs/fifo.c
+++ b/drivers/usb/renesas_usbhs/fifo.c
@@ -681,6 +681,14 @@ usbhs_fifo_read_end:
usbhs_pipe_number(pipe),
pkt->length, pkt->actual, *is_done, pkt->zero);
 
+   /*
+* Transmission end
+*/
+   if (*is_done) {
+   if (usbhs_pipe_is_dcp(pipe))
+   usbhs_dcp_control_transfer_done(pipe);
+   }
+
 usbhs_fifo_read_busy:
usbhsf_fifo_unselect(pipe, fifo);
 
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html