subject:"\[PATCH\] usb mouse quirks"

Re: [PATCH] usb mouse quirks

2016-03-05 Thread Paolo Minazzi

> 
> Aren't these entries supposed to be in numerical order?
> 
> Alan Stern
> 

- Both
045e:0737 (microsoft 500)
046d:c077 (logitech M105 optical wired mouse)
  suffer of auto-reset after 62 seconds if the device is not opened

- Now new entry USB_DEVICE_ID_MS_MOUSE_500 is in correct order

- I checked: from http://www.linux-usb.org/usb.ids
  There is not a product 046d:c007, so USB_DEVICE_ID_LOGITECH_C077 should be 
0xc077 and not 0xc007.
  This is the old patch with the error : 
https://lists.ubuntu.com/archives/kernel-team/2015-June/058955.html

- USB_DEVICE_ID_LOGITECH_C077 with the new code 0xc077 remains in the correct 
order


Signed-off-by: Paolo Minazzi 
---
 drivers/hid/hid-ids.h   | 3 ++-
 drivers/hid/usbhid/hid-quirks.c | 1 +
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index b6ff6e7..e70801a 100644
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -600,7 +600,7 @@
 #define USB_VENDOR_ID_LOGITECH 0x046d
 #define USB_DEVICE_ID_LOGITECH_AUDIOHUB 0x0a0e
 #define USB_DEVICE_ID_LOGITECH_T6510xb00c
-#define USB_DEVICE_ID_LOGITECH_C0770xc007
+#define USB_DEVICE_ID_LOGITECH_C0770xc077
 #define USB_DEVICE_ID_LOGITECH_RECEIVER0xc101
 #define USB_DEVICE_ID_LOGITECH_HARMONY_FIRST  0xc110
 #define USB_DEVICE_ID_LOGITECH_HARMONY_LAST 0xc14f
@@ -679,6 +679,7 @@
 #define USB_DEVICE_ID_MS_PRESENTER_8K_USB  0x0713
 #define USB_DEVICE_ID_MS_NE7K  0x071d
 #define USB_DEVICE_ID_MS_DIGITAL_MEDIA_3K  0x0730
+#define USB_DEVICE_ID_MS_MOUSE_500 0x0737
 #define USB_DEVICE_ID_MS_COMFORT_MOUSE_45000x076c
 #define USB_DEVICE_ID_MS_SURFACE_PRO_2   0x0799
 #define USB_DEVICE_ID_MS_TOUCH_COVER_2   0x07a7
diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c
index 7dd0953..09c8bed 100644
--- a/drivers/hid/usbhid/hid-quirks.c
+++ b/drivers/hid/usbhid/hid-quirks.c
@@ -93,6 +93,7 @@ static const struct hid_blacklist {
{ USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_JP, 
HID_QUIRK_NO_INIT_REPORTS },
{ USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_3, 
HID_QUIRK_NO_INIT_REPORTS },
{ USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_POWER_COVER, 
HID_QUIRK_NO_INIT_REPORTS },
+   { USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_MOUSE_500, 
HID_QUIRK_ALWAYS_POLL },
{ USB_VENDOR_ID_MSI, USB_DEVICE_ID_MSI_GT683R_LED_PANEL, 
HID_QUIRK_NO_INIT_REPORTS },
{ USB_VENDOR_ID_NEXIO, USB_DEVICE_ID_NEXIO_MULTITOUCH_PTI0750, 
HID_QUIRK_NO_INIT_REPORTS },
{ USB_VENDOR_ID_NOVATEK, USB_DEVICE_ID_NOVATEK_MOUSE, 
HID_QUIRK_NO_INIT_REPORTS },
-- 
1.7.12.1

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] usb mouse quirks

2016-03-03 Thread Alan Stern

On Thu, 3 Mar 2016, Paolo Minazzi wrote:

> Dear all,
> I have 3 wired usb optical mouse
> [1] Logitech 0x046D:0xC077
> [2] Logitech 0x046D:0xC05A
> [3] Microsoft 0x045E:0x0737
> 
> I always used 3.10 kernel and all mice have the problem of
> disconnection after 62 seconds.
> I got the latest kernel 4.5-rc3 and I have discovered about quirks and
> HID_QUIRK_ALWAYS_POLL.
> 
> Looking at the kernel 4.5-rc3 ...
> 
> For [1] Logitech 0x046D:0xC077
> there is already a line in quirks
> { USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_C077, HID_QUIRK_ALWAYS_POLL }
> but the #define seems broken:
> #define USB_DEVICE_ID_LOGITECH_C077  0xc007
> Someone can confirm ?
> 
> For [2] Logitech 0x046D:0xC05A all seems already ok. Quirk is already present.
> 
> For [3] Microsoft 0x045E:0x0737 the support for HID_QUIRK_ALWAYS_POLL
> seems missing.
> 
> The final patch should be (against 4.5-rc3) should be
> 
> =
> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
> index b6ff6e7..d788de2 100644
> --- a/drivers/hid/hid-ids.h
> +++ b/drivers/hid/hid-ids.h
> @@ -600,7 +600,7 @@
>  #define USB_VENDOR_ID_LOGITECH 0x046d
>  #define USB_DEVICE_ID_LOGITECH_AUDIOHUB 0x0a0e
>  #define USB_DEVICE_ID_LOGITECH_T6510xb00c
> -#define USB_DEVICE_ID_LOGITECH_C0770xc007
> +#define USB_DEVICE_ID_LOGITECH_C0770xc077
>  #define USB_DEVICE_ID_LOGITECH_RECEIVER0xc101
>  #define USB_DEVICE_ID_LOGITECH_HARMONY_FIRST  0xc110
>  #define USB_DEVICE_ID_LOGITECH_HARMONY_LAST 0xc14f
> @@ -670,6 +670,7 @@
> 
>  #define USB_VENDOR_ID_MICROSOFT0x045e
>  #define USB_DEVICE_ID_SIDEWINDER_GV0x003b
> +#define USB_DEVICE_ID_MS_MOUSE_500 0x0737
>  #define USB_DEVICE_ID_MS_OFFICE_KB 0x0048
>  #define USB_DEVICE_ID_WIRELESS_OPTICAL_DESKTOP_3_0 0x009d
>  #define USB_DEVICE_ID_MS_NE4K  0x00db

Aren't these entries supposed to be in numerical order?

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] usb mouse quirks

2016-03-03 Thread Felipe Balbi

Paolo Minazzi  writes:

> [ text/plain ]
> Dear all,
> I have 3 wired usb optical mouse
> [1] Logitech 0x046D:0xC077
> [2] Logitech 0x046D:0xC05A
> [3] Microsoft 0x045E:0x0737
>
> I always used 3.10 kernel and all mice have the problem of
> disconnection after 62 seconds.
> I got the latest kernel 4.5-rc3 and I have discovered about quirks and
> HID_QUIRK_ALWAYS_POLL.
>
> Looking at the kernel 4.5-rc3 ...
>
> For [1] Logitech 0x046D:0xC077
> there is already a line in quirks
> { USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_C077, HID_QUIRK_ALWAYS_POLL }
> but the #define seems broken:
> #define USB_DEVICE_ID_LOGITECH_C077  0xc007

yeah, seems like that needs patching.

> Someone can confirm ?
>
> For [2] Logitech 0x046D:0xC05A all seems already ok. Quirk is already present.
>
> For [3] Microsoft 0x045E:0x0737 the support for HID_QUIRK_ALWAYS_POLL
> seems missing.
>
> The final patch should be (against 4.5-rc3) should be
>
> =
> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
> index b6ff6e7..d788de2 100644
> --- a/drivers/hid/hid-ids.h
> +++ b/drivers/hid/hid-ids.h
> @@ -600,7 +600,7 @@
>  #define USB_VENDOR_ID_LOGITECH 0x046d
>  #define USB_DEVICE_ID_LOGITECH_AUDIOHUB 0x0a0e
>  #define USB_DEVICE_ID_LOGITECH_T6510xb00c
> -#define USB_DEVICE_ID_LOGITECH_C0770xc007
> +#define USB_DEVICE_ID_LOGITECH_C0770xc077
>  #define USB_DEVICE_ID_LOGITECH_RECEIVER0xc101
>  #define USB_DEVICE_ID_LOGITECH_HARMONY_FIRST  0xc110
>  #define USB_DEVICE_ID_LOGITECH_HARMONY_LAST 0xc14f
> @@ -670,6 +670,7 @@
>
>  #define USB_VENDOR_ID_MICROSOFT0x045e
>  #define USB_DEVICE_ID_SIDEWINDER_GV0x003b
> +#define USB_DEVICE_ID_MS_MOUSE_500 0x0737
>  #define USB_DEVICE_ID_MS_OFFICE_KB 0x0048
>  #define USB_DEVICE_ID_WIRELESS_OPTICAL_DESKTOP_3_0 0x009d
>  #define USB_DEVICE_ID_MS_NE4K  0x00db
> diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c
> index 7dd0953..09c8bed 100644
> --- a/drivers/hid/usbhid/hid-quirks.c
> +++ b/drivers/hid/usbhid/hid-quirks.c
> @@ -93,6 +93,7 @@ static const struct hid_blacklist {
> { USB_VENDOR_ID_MICROSOFT,
> USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_JP, HID_QUIRK_NO_INIT_REPORTS },
> { USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_3,
> HID_QUIRK_NO_INIT_REPORTS },
> { USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_POWER_COVER,
> HID_QUIRK_NO_INIT_REPORTS },
> +   { USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_MOUSE_500,
> HID_QUIRK_ALWAYS_POLL },
> { USB_VENDOR_ID_MSI, USB_DEVICE_ID_MSI_GT683R_LED_PANEL,
> HID_QUIRK_NO_INIT_REPORTS },
> { USB_VENDOR_ID_NEXIO, USB_DEVICE_ID_NEXIO_MULTITOUCH_PTI0750,
> HID_QUIRK_NO_INIT_REPORTS },
> { USB_VENDOR_ID_NOVATEK, USB_DEVICE_ID_NOVATEK_MOUSE,
> HID_QUIRK_NO_INIT_REPORTS },
> =

patch looks okay to me, but you need to send it as a proper patch. Have
a look at Documentation/SubmittingPatches and that should answer all
your questions.

cheers

-- 
balbi


signature.asc
Description: PGP signature

[PATCH] usb mouse quirks

2016-03-03 Thread Paolo Minazzi

Dear all,
I have 3 wired usb optical mouse
[1] Logitech 0x046D:0xC077
[2] Logitech 0x046D:0xC05A
[3] Microsoft 0x045E:0x0737

I always used 3.10 kernel and all mice have the problem of
disconnection after 62 seconds.
I got the latest kernel 4.5-rc3 and I have discovered about quirks and
HID_QUIRK_ALWAYS_POLL.

Looking at the kernel 4.5-rc3 ...

For [1] Logitech 0x046D:0xC077
there is already a line in quirks
{ USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_C077, HID_QUIRK_ALWAYS_POLL }
but the #define seems broken:
#define USB_DEVICE_ID_LOGITECH_C077  0xc007
Someone can confirm ?

For [2] Logitech 0x046D:0xC05A all seems already ok. Quirk is already present.

For [3] Microsoft 0x045E:0x0737 the support for HID_QUIRK_ALWAYS_POLL
seems missing.

The final patch should be (against 4.5-rc3) should be

=
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index b6ff6e7..d788de2 100644
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -600,7 +600,7 @@
 #define USB_VENDOR_ID_LOGITECH 0x046d
 #define USB_DEVICE_ID_LOGITECH_AUDIOHUB 0x0a0e
 #define USB_DEVICE_ID_LOGITECH_T6510xb00c
-#define USB_DEVICE_ID_LOGITECH_C0770xc007
+#define USB_DEVICE_ID_LOGITECH_C0770xc077
 #define USB_DEVICE_ID_LOGITECH_RECEIVER0xc101
 #define USB_DEVICE_ID_LOGITECH_HARMONY_FIRST  0xc110
 #define USB_DEVICE_ID_LOGITECH_HARMONY_LAST 0xc14f
@@ -670,6 +670,7 @@

 #define USB_VENDOR_ID_MICROSOFT0x045e
 #define USB_DEVICE_ID_SIDEWINDER_GV0x003b
+#define USB_DEVICE_ID_MS_MOUSE_500 0x0737
 #define USB_DEVICE_ID_MS_OFFICE_KB 0x0048
 #define USB_DEVICE_ID_WIRELESS_OPTICAL_DESKTOP_3_0 0x009d
 #define USB_DEVICE_ID_MS_NE4K  0x00db
diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c
index 7dd0953..09c8bed 100644
--- a/drivers/hid/usbhid/hid-quirks.c
+++ b/drivers/hid/usbhid/hid-quirks.c
@@ -93,6 +93,7 @@ static const struct hid_blacklist {
{ USB_VENDOR_ID_MICROSOFT,
USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_JP, HID_QUIRK_NO_INIT_REPORTS },
{ USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_3,
HID_QUIRK_NO_INIT_REPORTS },
{ USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_POWER_COVER,
HID_QUIRK_NO_INIT_REPORTS },
+   { USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_MOUSE_500,
HID_QUIRK_ALWAYS_POLL },
{ USB_VENDOR_ID_MSI, USB_DEVICE_ID_MSI_GT683R_LED_PANEL,
HID_QUIRK_NO_INIT_REPORTS },
{ USB_VENDOR_ID_NEXIO, USB_DEVICE_ID_NEXIO_MULTITOUCH_PTI0750,
HID_QUIRK_NO_INIT_REPORTS },
{ USB_VENDOR_ID_NOVATEK, USB_DEVICE_ID_NOVATEK_MOUSE,
HID_QUIRK_NO_INIT_REPORTS },
=

Regards,
Paolo Minazzi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] usb mouse quirks

Re: [PATCH] usb mouse quirks

Re: [PATCH] usb mouse quirks

[PATCH] usb mouse quirks

4 matches

Site Navigation

Mail list logo

Footer information