There is some limitation for AMD Promontory xHCI host to
disable USB port function. It will enable USB wake-up function then cause USB
disable port feature to fail.
Workaround this issue on Promontory xHCI host
is clear PORT_WAKE_BITS.
Signed-off-by: Jiahau Chang
---
drivers/usb/host/xhci-hub.c | 20 +++-
drivers/usb/host/xhci-pci.c | 13 +
drivers/usb/host/xhci.h | 2 ++
3 files changed, 30 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/host/xhci-hub.c b/drivers/usb/host/xhci-hub.c
index 0dde49c..252c278 100644
--- a/drivers/usb/host/xhci-hub.c
+++ b/drivers/usb/host/xhci-hub.c
@@ -1218,12 +1218,19 @@ int xhci_hub_control(struct usb_hcd *hcd, u16 typeReq,
u16 wValue,
xhci_dbg(xhci, "set port reset, actual port %d status
= 0x%x\n", wIndex, temp);
break;
case USB_PORT_FEAT_REMOTE_WAKE_MASK:
- xhci_set_remote_wake_mask(xhci, port_array,
+ if((xhci->quirks & XHCI_U2_DISABLE_WAKE) &&(hcd->speed
< HCD_USB3)) {
+ temp = readl(port_array[wIndex]);
+ xhci_dbg(xhci, "skip set port remote wake mask,
"
+ "actual port %d status =
0x%x\n",
+ wIndex, temp);
+ }else{
+ xhci_set_remote_wake_mask(xhci, port_array,
wIndex, wake_mask);
- temp = readl(port_array[wIndex]);
- xhci_dbg(xhci, "set port remote wake mask, "
- "actual port %d status = 0x%x\n",
- wIndex, temp);
+ temp = readl(port_array[wIndex]);
+ xhci_dbg(xhci, "set port remote wake mask, "
+ "actual port %d status =
0x%x\n",
+ wIndex, temp);
+ }
break;
case USB_PORT_FEAT_BH_PORT_RESET:
temp |= PORT_WR;
@@ -1461,6 +1468,9 @@ int xhci_bus_suspend(struct usb_hcd *hcd)
t2 |= PORT_WKOC_E | PORT_WKCONN_E;
t2 &= ~PORT_WKDISC_E;
}
+
+ if((xhci->quirks & XHCI_U2_DISABLE_WAKE) &&(hcd->speed
< HCD_USB3))
+ t2 &= ~PORT_WAKE_BITS;
} else
t2 &= ~PORT_WAKE_BITS;
diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
index fcf1f3f..8a66ac1 100644
--- a/drivers/usb/host/xhci-pci.c
+++ b/drivers/usb/host/xhci-pci.c
@@ -54,6 +54,11 @@
#define PCI_DEVICE_ID_INTEL_APL_XHCI 0x5aa8
#define PCI_DEVICE_ID_INTEL_DNV_XHCI 0x19d0
+#define PCI_DEVICE_ID_AMD_PROMONTORYA_40x43b9
+#define PCI_DEVICE_ID_AMD_PROMONTORYA_30x43ba
+#define PCI_DEVICE_ID_AMD_PROMONTORYA_20x43bb
+#define PCI_DEVICE_ID_AMD_PROMONTORYA_10x43bc
+
static const char hcd_name[] = "xhci_hcd";
static struct hc_driver __read_mostly xhci_pci_hc_driver;
@@ -135,6 +140,14 @@ static void xhci_pci_quirks(struct device *dev, struct
xhci_hcd *xhci)
if (pdev->vendor == PCI_VENDOR_ID_AMD)
xhci->quirks |= XHCI_TRUST_TX_LENGTH;
+ if((pdev->vendor == PCI_VENDOR_ID_AMD)&&
+ (( pdev->device==PCI_DEVICE_ID_AMD_PROMONTORYA_4)||
+( pdev->device==PCI_DEVICE_ID_AMD_PROMONTORYA_3)||
+( pdev->device==PCI_DEVICE_ID_AMD_PROMONTORYA_2)||
+( pdev->device==PCI_DEVICE_ID_AMD_PROMONTORYA_1)))
+ xhci->quirks |= XHCI_U2_DISABLE_WAKE;
+
+
if (pdev->vendor == PCI_VENDOR_ID_INTEL) {
xhci->quirks |= XHCI_LPM_SUPPORT;
xhci->quirks |= XHCI_INTEL_HOST;
diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h
index 73a28a9..48b262a 100644
--- a/drivers/usb/host/xhci.h
+++ b/drivers/usb/host/xhci.h
@@ -1819,6 +1819,8 @@ struct xhci_hcd {
/* For controller with a broken Port Disable implementation */
#define XHCI_BROKEN_PORT_PED (1 << 25)
#define XHCI_LIMIT_ENDPOINT_INTERVAL_7 (1 << 26)
+#define XHCI_U2_DISABLE_WAKE(1 << 27)
+
unsigned intnum_active_eps;
unsigned intlimit_active_eps;
--
2.7.4
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
