Re: [PATCH 0/1] Input: xpad - Add a variation of Mad Catz Beat Pad

2012-07-06 Thread Dmitry Torokhov
On Fri, Jul 06, 2012 at 11:57:44PM +0700, Yuri Khan wrote:
> On Fri, Jul 6, 2012 at 11:32 PM, Yuri Khan  wrote:
> 
> > When I add a usbhid option quirks=0x0738:0x4540:0x4 (so that usbhid does
> > not attempt to handle this device) and rebuild the xpad module with the
> > following patch, the device works as expected. Dmitry Torokhov, the
> > current maintainer of input drivers, suggested that I include a change
> > to add the usbhid quirk in my patch.
> 
> Of course the good idea only ever comes after the fact. If I change
> usbhid to ignore this vendor:device unconditionally, then xpad should
> also always handle it regardless of interface class/subclass/protocol,
> right?

Yes.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 0/1] Input: xpad - Add a variation of Mad Catz Beat Pad

2012-07-06 Thread Yuri Khan
On Fri, Jul 6, 2012 at 11:32 PM, Yuri Khan  wrote:

> When I add a usbhid option quirks=0x0738:0x4540:0x4 (so that usbhid does
> not attempt to handle this device) and rebuild the xpad module with the
> following patch, the device works as expected. Dmitry Torokhov, the
> current maintainer of input drivers, suggested that I include a change
> to add the usbhid quirk in my patch.

Of course the good idea only ever comes after the fact. If I change
usbhid to ignore this vendor:device unconditionally, then xpad should
also always handle it regardless of interface class/subclass/protocol,
right?
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH 0/1] Input: xpad - Add a variation of Mad Catz Beat Pad

2012-07-06 Thread Yuri Khan
Hello all,

I have a dance pad that has the vendor and product IDs of a Mad Catz 
Beat Pad (0738:4540), but it doesn't get handled by xpad.ko because xpad 
expects (a) interface class and subclass of 'X':'B', or (b) interface 
class 255, subclass 93, protocol 1 or 129; while my device identifies as 
interface class 3 (HID), subclass 0, protocol 0. As a result, usbhid 
grabs it and it sort of works, but the diagonal pads are not mapped.

When I add a usbhid option quirks=0x0738:0x4540:0x4 (so that usbhid does 
not attempt to handle this device) and rebuild the xpad module with the 
following patch, the device works as expected. Dmitry Torokhov, the 
current maintainer of input drivers, suggested that I include a change 
to add the usbhid quirk in my patch.

Yuri Khan (1):
  Input: xpad - Add a variation of Mad Catz Beat Pad

 drivers/hid/hid-ids.h   |3 +++
 drivers/hid/usbhid/hid-quirks.c |2 ++
 drivers/input/joystick/xpad.c   |2 ++
 3 files changed, 7 insertions(+)

-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html