Re: [PATCH 0/2] Introduce usb charger framework to deal with the usb gadget power negotation

2015-08-08 Thread Baolin Wang
On 8 August 2015 at 01:52, Greg KH gre...@linuxfoundation.org wrote:
 On Fri, Aug 07, 2015 at 04:19:40PM +0800, Baolin Wang wrote:
 On 7 August 2015 at 13:34, Peter Chen peter.c...@freescale.com wrote:
  On Thu, Aug 06, 2015 at 03:03:47PM +0800, Baolin Wang wrote:
  Currently the Linux kernel does not provide any standard integration of 
  this
  feature that integrates the USB subsystem with the system power regulation
  provided by PMICs meaning that either vendors must add this in their 
  kernels
  or USB gadget devices based on Linux (such as mobile phones) may not 
  behave
  as they should.
 
  Providing a standard framework for doing this in the kernel.
 
  Baolin, thanks for introducing a framework for doing it, we do support
  USB Charger for chipidea driver at internal tree, but it is specific
  for imx, and still have some problems to upstream due to need to
  change some common code.
 
  One suggestion, would you add your user next time? In that case, we can
  know better for this framework.
 

 Peter, Thanks for your reviewing and comments. Now I just introduce
 the framework to review for more feedbacks and do not have a useful
 user to use it. I just can show you some example code to show how to
 use it. Thanks.

 Without a real, in-tree user, I can not accept this code.  We don't add
 frameworks for non-existant things, otherwise it will be instantly
 ripped out the next kernel release.

 Please come up with at least 2 users, ideally 3, otherwise there's no
 real way to know if the framework is sufficient.


OK, I'll try to come up with 2 or 3 users. Thanks.

 thanks,

 greg k-h



-- 
Baolin.wang
Best Regards
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 0/2] Introduce usb charger framework to deal with the usb gadget power negotation

2015-08-07 Thread Peter Chen
On Thu, Aug 06, 2015 at 03:03:47PM +0800, Baolin Wang wrote:
 Currently the Linux kernel does not provide any standard integration of this
 feature that integrates the USB subsystem with the system power regulation
 provided by PMICs meaning that either vendors must add this in their kernels
 or USB gadget devices based on Linux (such as mobile phones) may not behave
 as they should.
 
 Providing a standard framework for doing this in the kernel.

Baolin, thanks for introducing a framework for doing it, we do support
USB Charger for chipidea driver at internal tree, but it is specific 
for imx, and still have some problems to upstream due to need to
change some common code.

One suggestion, would you add your user next time? In that case, we can
know better for this framework.

 
 Baolin Wang (2):
   gadget: Introduce the usb charger framework
   gadget: Support for the usb charger framework
 
  drivers/usb/gadget/charger.c  |  547 
 +
  drivers/usb/gadget/udc/udc-core.c |   41 +++
  include/linux/usb/gadget.h|   20 ++
  include/linux/usb/usb_charger.h   |  101 +++
  4 files changed, 709 insertions(+)
  create mode 100644 drivers/usb/gadget/charger.c
  create mode 100644 include/linux/usb/usb_charger.h
 
 -- 
 1.7.9.5
 

-- 

Best Regards,
Peter Chen
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


RE: [PATCH 0/2] Introduce usb charger framework to deal with the usb gadget power negotation

2015-08-07 Thread Peter Chen
 
 
 Peter, Thanks for your reviewing and comments. Now I just introduce the
 framework to review for more feedbacks and do not have a useful user to use
 it. I just can show you some example code to show how to use it. Thanks.
 

Felipe may not accept the code which are no user on it, I remember he said it 
before.
Besides, if no user on it, how you test it?

Peter
N�r��yb�X��ǧv�^�)޺{.n�+{��^n�r���z���h����G���h�(�階�ݢj���m��z�ޖ���f���h���~�m�

Re: [PATCH 0/2] Introduce usb charger framework to deal with the usb gadget power negotation

2015-08-07 Thread Baolin Wang
On 7 August 2015 at 16:31, Peter Chen peter.c...@freescale.com wrote:


 Peter, Thanks for your reviewing and comments. Now I just introduce the
 framework to review for more feedbacks and do not have a useful user to use
 it. I just can show you some example code to show how to use it. Thanks.


 Felipe may not accept the code which are no user on it, I remember he said it 
 before.
 Besides, if no user on it, how you test it?


Make sense of it. I'll try to build the user to test it. Thanks for
your reminding.

 Peter



-- 
Baolin.wang
Best Regards
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 0/2] Introduce usb charger framework to deal with the usb gadget power negotation

2015-08-07 Thread Baolin Wang
On 7 August 2015 at 13:34, Peter Chen peter.c...@freescale.com wrote:
 On Thu, Aug 06, 2015 at 03:03:47PM +0800, Baolin Wang wrote:
 Currently the Linux kernel does not provide any standard integration of this
 feature that integrates the USB subsystem with the system power regulation
 provided by PMICs meaning that either vendors must add this in their kernels
 or USB gadget devices based on Linux (such as mobile phones) may not behave
 as they should.

 Providing a standard framework for doing this in the kernel.

 Baolin, thanks for introducing a framework for doing it, we do support
 USB Charger for chipidea driver at internal tree, but it is specific
 for imx, and still have some problems to upstream due to need to
 change some common code.

 One suggestion, would you add your user next time? In that case, we can
 know better for this framework.


Peter, Thanks for your reviewing and comments. Now I just introduce
the framework to review for more feedbacks and do not have a useful
user to use it. I just can show you some example code to show how to
use it. Thanks.


 Baolin Wang (2):
   gadget: Introduce the usb charger framework
   gadget: Support for the usb charger framework

  drivers/usb/gadget/charger.c  |  547 
 +
  drivers/usb/gadget/udc/udc-core.c |   41 +++
  include/linux/usb/gadget.h|   20 ++
  include/linux/usb/usb_charger.h   |  101 +++
  4 files changed, 709 insertions(+)
  create mode 100644 drivers/usb/gadget/charger.c
  create mode 100644 include/linux/usb/usb_charger.h

 --
 1.7.9.5


 --

 Best Regards,
 Peter Chen



-- 
Baolin.wang
Best Regards
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 0/2] Introduce usb charger framework to deal with the usb gadget power negotation

2015-08-07 Thread Greg KH
On Fri, Aug 07, 2015 at 04:19:40PM +0800, Baolin Wang wrote:
 On 7 August 2015 at 13:34, Peter Chen peter.c...@freescale.com wrote:
  On Thu, Aug 06, 2015 at 03:03:47PM +0800, Baolin Wang wrote:
  Currently the Linux kernel does not provide any standard integration of 
  this
  feature that integrates the USB subsystem with the system power regulation
  provided by PMICs meaning that either vendors must add this in their 
  kernels
  or USB gadget devices based on Linux (such as mobile phones) may not behave
  as they should.
 
  Providing a standard framework for doing this in the kernel.
 
  Baolin, thanks for introducing a framework for doing it, we do support
  USB Charger for chipidea driver at internal tree, but it is specific
  for imx, and still have some problems to upstream due to need to
  change some common code.
 
  One suggestion, would you add your user next time? In that case, we can
  know better for this framework.
 
 
 Peter, Thanks for your reviewing and comments. Now I just introduce
 the framework to review for more feedbacks and do not have a useful
 user to use it. I just can show you some example code to show how to
 use it. Thanks.

Without a real, in-tree user, I can not accept this code.  We don't add
frameworks for non-existant things, otherwise it will be instantly
ripped out the next kernel release.

Please come up with at least 2 users, ideally 3, otherwise there's no
real way to know if the framework is sufficient.

thanks,

greg k-h
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 0/2] Introduce usb charger framework to deal with the usb gadget power negotation

2015-08-06 Thread Greg KH
On Thu, Aug 06, 2015 at 11:21:22AM -0500, Felipe Balbi wrote:
 Hi,
 
 On Thu, Aug 06, 2015 at 03:03:47PM +0800, Baolin Wang wrote:
  Currently the Linux kernel does not provide any standard integration of this
  feature that integrates the USB subsystem with the system power regulation
  provided by PMICs meaning that either vendors must add this in their kernels
  or USB gadget devices based on Linux (such as mobile phones) may not behave
  as they should.
  
  Providing a standard framework for doing this in the kernel.
 
 it's too late in this cycle to even start discussing this. i'll drop
 from my queue, please resend rebase on v4.3-rc1 once that's out.

Why should that matter?  Can't they just rebase on linux-next and we can
work it out from there?  the merge cycle is just for us maintainers to
worry about, people can submit code whenever they want to, it's up to us
as to what tree we merge it to (now or next).

thanks,

greg k-h
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH 0/2] Introduce usb charger framework to deal with the usb gadget power negotation

2015-08-06 Thread Baolin Wang
Currently the Linux kernel does not provide any standard integration of this
feature that integrates the USB subsystem with the system power regulation
provided by PMICs meaning that either vendors must add this in their kernels
or USB gadget devices based on Linux (such as mobile phones) may not behave
as they should.

Providing a standard framework for doing this in the kernel.

Baolin Wang (2):
  gadget: Introduce the usb charger framework
  gadget: Support for the usb charger framework

 drivers/usb/gadget/charger.c  |  547 +
 drivers/usb/gadget/udc/udc-core.c |   41 +++
 include/linux/usb/gadget.h|   20 ++
 include/linux/usb/usb_charger.h   |  101 +++
 4 files changed, 709 insertions(+)
 create mode 100644 drivers/usb/gadget/charger.c
 create mode 100644 include/linux/usb/usb_charger.h

-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 0/2] Introduce usb charger framework to deal with the usb gadget power negotation

2015-08-06 Thread Felipe Balbi
Hi,

On Thu, Aug 06, 2015 at 03:03:47PM +0800, Baolin Wang wrote:
 Currently the Linux kernel does not provide any standard integration of this
 feature that integrates the USB subsystem with the system power regulation
 provided by PMICs meaning that either vendors must add this in their kernels
 or USB gadget devices based on Linux (such as mobile phones) may not behave
 as they should.
 
 Providing a standard framework for doing this in the kernel.

it's too late in this cycle to even start discussing this. i'll drop
from my queue, please resend rebase on v4.3-rc1 once that's out.

-- 
balbi


signature.asc
Description: Digital signature