Re: [PATCH 0/3] usb: musb: da8xx: Add support of suspend / resume

2016-12-15 Thread Bin Liu
On Mon, Nov 28, 2016 at 05:26:18PM +0100, Alexandre Bailon wrote:
> There is no suspend / resume support for da8xx.
> Add the PM methods to da8xx glue.
> In addition, introduce a new quirk to not clear the devctl register.
> Clearing devctl will power off vbus on da8xx platform
> (when it is host mode) and then devices will be disconnected on resume.
> 
> The quirk name (MUSB_PRESERVE_DEVCTL) doesn't seem good to me,
> so if anyone have better name, I will be happy to rename it.

Writting 0 to MUSB_DEVCTL register is basically to clear bit 0 to turn
off the session, so I think MUSB_PRESERVE_SESSION would be a better
name.

Regards,
-Bin.

> I think there is other ways to fix the VBUS issue but adding a quirk
> make the required changes harmless to other platform.
> 
> Alexandre Bailon (3):
>   usb: musb: da8xx: Add support of suspend / resume
>   usb: musb: Add a quirk to preserve MUSB_DEVCTL during suspend
>   usb: musb: da8xx: Fix host mode suspend
> 
>  drivers/usb/musb/da8xx.c | 33 +++--
>  drivers/usb/musb/musb_core.c | 13 +++--
>  drivers/usb/musb/musb_core.h |  1 +
>  3 files changed, 39 insertions(+), 8 deletions(-)
> 
> -- 
> 2.7.3
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH 0/3] usb: musb: da8xx: Add support of suspend / resume

2016-11-28 Thread Alexandre Bailon
There is no suspend / resume support for da8xx.
Add the PM methods to da8xx glue.
In addition, introduce a new quirk to not clear the devctl register.
Clearing devctl will power off vbus on da8xx platform
(when it is host mode) and then devices will be disconnected on resume.

The quirk name (MUSB_PRESERVE_DEVCTL) doesn't seem good to me,
so if anyone have better name, I will be happy to rename it.
I think there is other ways to fix the VBUS issue but adding a quirk
make the required changes harmless to other platform.

Alexandre Bailon (3):
  usb: musb: da8xx: Add support of suspend / resume
  usb: musb: Add a quirk to preserve MUSB_DEVCTL during suspend
  usb: musb: da8xx: Fix host mode suspend

 drivers/usb/musb/da8xx.c | 33 +++--
 drivers/usb/musb/musb_core.c | 13 +++--
 drivers/usb/musb/musb_core.h |  1 +
 3 files changed, 39 insertions(+), 8 deletions(-)

-- 
2.7.3

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html