Re: [PATCH 0/6] musb-fixes for v4.9-rc6

[Bin Liu]

On Thu, Nov 17, 2016 at 04:26:17PM +0100, Greg KH wrote:
> On Thu, Nov 17, 2016 at 08:38:29AM -0600, Bin Liu wrote:
> > On Thu, Nov 17, 2016 at 10:20:10AM +0100, Johan Hovold wrote:
> > > [ +CC: Tony ]
> > > 
> > > On Thu, Nov 17, 2016 at 08:10:55AM +0100, Greg Kroah-Hartman wrote:
> > > > On Wed, Nov 16, 2016 at 01:21:21PM -0600, Bin Liu wrote:
> > > > > Hi Greg,
> > > > > 
> > > > > Hope this is not too late for -rc6. This set fixes a long standing 
> > > > > musb
> > > > > regression introduced in v4.8.  Please let me know if any change is 
> > > > > needed.
> > > > 
> > > > As these were bugs in 4.8 (i.e. not a regression due to changes in
> > > > 4.9-rc1), can we just wait for 4.10-rc1 for these patches?
> > > 
> > > I believe that may have been a typo as this series fixes a number of
> > > regressions in 4.9. Most of the patches have either or both of
> > > 
> > > Fixes: 467d5c980709 ("usb: musb: Implement session bit based runtime
> > > PM for musb-core")
> > > Fixes: 65b3f50ed6fa ("usb: musb: Add PM runtime support for MUSB DSPS
> > > 
> > > that went into 4.9, or are prerequisite clean ups (patch 1/6).
> > > 
> > > The exception being patch 4/6 that claims to fix a commit in 4.7.
> > 
> > This is all correct, thanks for clarification Johan. My faulty memory
> > told me those two patches got merged in v4.8 cycle, my bad, I should
> > double check it before writing the message.
> > 
> > Greg, considering v4.9 will be a LTS, it would be great if these fixes
> > got merged in v4.9-rc6 or -rc7.
> 
> Ok, all now queued up, thanks,
> 
> greg k-h

Thanks.

-Bin.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/6] musb-fixes for v4.9-rc6

[Tony Lindgren]

* Johan Hovold  [161117 01:20]:
> [ +CC: Tony ]
> 
> On Thu, Nov 17, 2016 at 08:10:55AM +0100, Greg Kroah-Hartman wrote:
> > On Wed, Nov 16, 2016 at 01:21:21PM -0600, Bin Liu wrote:
> > > Hi Greg,
> > > 
> > > Hope this is not too late for -rc6. This set fixes a long standing musb
> > > regression introduced in v4.8.  Please let me know if any change is 
> > > needed.
> > 
> > As these were bugs in 4.8 (i.e. not a regression due to changes in
> > 4.9-rc1), can we just wait for 4.10-rc1 for these patches?
> 
> I believe that may have been a typo as this series fixes a number of
> regressions in 4.9. Most of the patches have either or both of
> 
> Fixes: 467d5c980709 ("usb: musb: Implement session bit based runtime
> PM for musb-core")
> Fixes: 65b3f50ed6fa ("usb: musb: Add PM runtime support for MUSB DSPS
> 
> that went into 4.9, or are prerequisite clean ups (patch 1/6).
> 
> The exception being patch 4/6 that claims to fix a commit in 4.7.
> 
> The driver appeared to work well-enough for me in 4.8, but then again I
> only hit the debug splat triggered by 65b3f50ed6fa ("usb: musb: Add PM
> runtime support for MUSB DSPS) every other second (fixed by patch 2/6).

Heh these are for v4.9-rc yes, not v4.8 :) We made PM generic and
also enabled it for MUSB DSPS glue layer which caused tons of issues
to show up.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/6] musb-fixes for v4.9-rc6

[Johan Hovold]

[ +CC: Tony ]

On Thu, Nov 17, 2016 at 08:10:55AM +0100, Greg Kroah-Hartman wrote:
> On Wed, Nov 16, 2016 at 01:21:21PM -0600, Bin Liu wrote:
> > Hi Greg,
> > 
> > Hope this is not too late for -rc6. This set fixes a long standing musb
> > regression introduced in v4.8.  Please let me know if any change is needed.
> 
> As these were bugs in 4.8 (i.e. not a regression due to changes in
> 4.9-rc1), can we just wait for 4.10-rc1 for these patches?

I believe that may have been a typo as this series fixes a number of
regressions in 4.9. Most of the patches have either or both of

Fixes: 467d5c980709 ("usb: musb: Implement session bit based runtime
PM for musb-core")
Fixes: 65b3f50ed6fa ("usb: musb: Add PM runtime support for MUSB DSPS

that went into 4.9, or are prerequisite clean ups (patch 1/6).

The exception being patch 4/6 that claims to fix a commit in 4.7.

The driver appeared to work well-enough for me in 4.8, but then again I
only hit the debug splat triggered by 65b3f50ed6fa ("usb: musb: Add PM
runtime support for MUSB DSPS) every other second (fixed by patch 2/6).

Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/6] musb-fixes for v4.9-rc6

[Greg KH]

On Wed, Nov 16, 2016 at 01:21:21PM -0600, Bin Liu wrote:
> Hi Greg,
> 
> Hope this is not too late for -rc6. This set fixes a long standing musb
> regression introduced in v4.8.  Please let me know if any change is needed.

As these were bugs in 4.8 (i.e. not a regression due to changes in
4.9-rc1), can we just wait for 4.10-rc1 for these patches?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 0/6] musb-fixes for v4.9-rc6

[Bin Liu]

Hi Greg,

Hope this is not too late for -rc6. This set fixes a long standing musb
regression introduced in v4.8.  Please let me know if any change is needed.

Thanks,
-Bin.
---

Tony Lindgren (6):
  usb: musb: Fix broken use of static variable for multiple instances
  usb: musb: Fix sleeping function called from invalid context for hdrc glue
  usb: musb: Fix PM for hub disconnect
  usb: musb: Add missing pm_runtime_disable and drop 2430 PM timeout
  usb: musb: Drop pointless PM runtime code for dsps glue
  phy: twl4030-usb: Fix for musb session bit based PM

 drivers/phy/phy-twl4030-usb.c  |   4 +-
 drivers/usb/musb/musb_core.c   | 147 -
 drivers/usb/musb/musb_core.h   |  13 +++-
 drivers/usb/musb/musb_dsps.c   |  58 
 drivers/usb/musb/musb_gadget.c |  39 +--
 drivers/usb/musb/omap2430.c|  10 ++-
 drivers/usb/musb/tusb6010.c|   6 +-
 7 files changed, 209 insertions(+), 68 deletions(-)

-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html