Re: [PATCH 00/18] Resend of usbip-utils migration patches and various other fixes
On Sun, Mar 09, 2014 at 05:53:51PM +0200, Valentina Manea wrote: > I was notified that one of the patches in the series (staging: usbip: > claim ports used by shared devices) breaks the build. > I take full responsability for this as I haven't compiled the kernel > with allyesconfig and I am sorry. No worries, it happens to all of us :) > This can be fixed by moving struct dev_state, usb_hub_claim_port() and > usb_hub_release_port() declarations from include/linux/usb.h to > usbip/stub.h, and leaving the declarations in usb/core/usb.h > untouched. > > Should the fix come as a separate patch or v2 of the broken one? No, I can't redo the patch that I've already committed. As "dev_state" is a very generic term, how about we just rename it to something more USB specific, like usb_dev_state? That way it would fix the build issue, and keep it from being a problem in the future in other drivers. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 00/18] Resend of usbip-utils migration patches and various other fixes
I was notified that one of the patches in the series (staging: usbip: claim ports used by shared devices) breaks the build. I take full responsability for this as I haven't compiled the kernel with allyesconfig and I am sorry. This can be fixed by moving struct dev_state, usb_hub_claim_port() and usb_hub_release_port() declarations from include/linux/usb.h to usbip/stub.h, and leaving the declarations in usb/core/usb.h untouched. Should the fix come as a separate patch or v2 of the broken one? Thanks, Valentina -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 00/18] Resend of usbip-utils migration patches and various other fixes
On Sat, Mar 08, 2014 at 02:53:18PM +0200, Valentina Manea wrote: > This is a resend of the patches sent a few days ago, including > the migration of USB/IP userspace side to use libudev instead > of libsysfs and various other fixes, all ordered in a big patch > series. Very nice work, thanks so much for doing all of this, it looks great. Now applied to my tree, you should have gotten the emails about it already. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 00/18] Resend of usbip-utils migration patches and various other fixes
This is a resend of the patches sent a few days ago, including the migration of USB/IP userspace side to use libudev instead of libsysfs and various other fixes, all ordered in a big patch series. The patches have been modified according to received feedback. Valentina Manea (18): staging: usbip: userspace: migrate usbip_bind to libudev staging: usbip: userspace: remove useless libsysfs includes staging: usbip: userspace: migrate usbip_unbind to libudev staging: usbip: userspace: migrate usbip_list to libudev staging: usbip: userspace: re-add interface information listing staging: usbip: userspace: add new list API staging: usbip: userspace: move sysfs_utils to libsrc staging: usbip: userspace: migrate usbip_host_driver to libudev staging: usbip: userspace: remove class device infrastructure in vhci_driver staging: usbip: userspace: migrate vhci_driver to libudev staging: usbip: userspace: remove libsysfs flag and autoconf check staging: usbip: userspace: update dependencies in README staging: usbip: userspace: increase version to 2.0 staging: usbip: let client choose device configuration staging: usbip: trigger driver probing after unbinding from usbip-host staging: usbip: claim ports used by shared devices staging: usbip: userspace: don't throw error when trying to read configuration specific attributes staging: usbip: userspace: add hwdata as optional dependency in README drivers/staging/usbip/stub.h | 1 + drivers/staging/usbip/stub_dev.c | 33 +- drivers/staging/usbip/stub_main.c | 39 +++ drivers/staging/usbip/stub_rx.c| 26 +- drivers/staging/usbip/userspace/README | 8 +- drivers/staging/usbip/userspace/configure.ac | 12 +- drivers/staging/usbip/userspace/libsrc/Makefile.am | 3 +- drivers/staging/usbip/userspace/libsrc/list.h | 136 .../staging/usbip/userspace/libsrc/sysfs_utils.c | 31 ++ .../staging/usbip/userspace/libsrc/sysfs_utils.h | 8 + .../staging/usbip/userspace/libsrc/usbip_common.c | 91 +++--- .../staging/usbip/userspace/libsrc/usbip_common.h | 15 +- .../usbip/userspace/libsrc/usbip_host_driver.c | 285 + .../usbip/userspace/libsrc/usbip_host_driver.h | 7 +- .../staging/usbip/userspace/libsrc/vhci_driver.c | 346 - .../staging/usbip/userspace/libsrc/vhci_driver.h | 14 +- drivers/staging/usbip/userspace/src/Makefile.am| 1 - drivers/staging/usbip/userspace/src/usbip_attach.c | 1 - drivers/staging/usbip/userspace/src/usbip_bind.c | 149 - drivers/staging/usbip/userspace/src/usbip_detach.c | 2 - drivers/staging/usbip/userspace/src/usbip_list.c | 153 - .../staging/usbip/userspace/src/usbip_network.h| 1 - drivers/staging/usbip/userspace/src/usbip_unbind.c | 110 +++ drivers/staging/usbip/userspace/src/usbipd.c | 30 +- drivers/staging/usbip/userspace/src/utils.c| 48 +-- drivers/usb/core/hub.c | 2 + drivers/usb/core/usb.h | 4 - include/linux/usb.h| 7 + 28 files changed, 676 insertions(+), 887 deletions(-) create mode 100644 drivers/staging/usbip/userspace/libsrc/list.h create mode 100644 drivers/staging/usbip/userspace/libsrc/sysfs_utils.c create mode 100644 drivers/staging/usbip/userspace/libsrc/sysfs_utils.h -- 1.8.1.2 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
