Re: [PATCH 00/27] add pm_runtime_last_busy_and_autosuspend() helper
On Thursday, September 25, 2014 04:27:58 PM Wolfram Sang wrote: > > --Bn2rw/3z4jIqBvZU > Content-Type: text/plain; charset=us-ascii > Content-Disposition: inline > Content-Transfer-Encoding: quoted-printable > > On Thu, Sep 25, 2014 at 09:22:01AM -0500, Felipe Balbi wrote: > > On Thu, Sep 25, 2014 at 01:27:18PM +0530, Vinod Koul wrote: > > > On Wed, Sep 24, 2014 at 03:32:19PM -0500, Felipe Balbi wrote: > > > > > > > OK, I guess this is as good as it gets. > > > > > > >=20 > > > > > > > What tree would you like it go through? > > > > > >=20 > > > > > > Do we really need this new helper ? I mean, the very moment when = > we > > > > > > decide to implement ->runtime_idle() we will need to get rid of t= > his > > > > > > change. I wonder if it's really valid... > > > > >=20 > > > > > I'm not sure I'm following? This seems to simply implement what dr= > ivers > > > > > have been doing already as one function. Why would it be invalid t= > o reduce > > > > > code duplication? > > > >=20 > > > > For two reasons: > > > >=20 > > > > 1) the helper has no inteligence whatsoever. It just calls the same > > > > functions. > > > >=20 > > > > 2) the duplication will vanish whenever someone implements > > > > ->runtime_idle() and have that call pm_runtime_autosuspend() (like PCI > > > > and USB buses are doing today). This will just be yet another line th= > at > > > > needs to change. > > > >=20 > > > > Frankly though, no strong feelings, I just think it's a commit that > > > > doesn't bring that any benefits other than looking like one line was > > > > removed. > > > and yes that is what it tries to do nothing more nothing less. If in fu= > ture > > > there are no users (today we have quite a few), then we can remove the = > dead > > > macro, no harm. But that is not the situation today. > >=20 > > as I said, a commit that's bound to be useless. It's not like you're > > saving 10 lines of code, it's only one. Replacing two simple lines with > > a function which takes almost as many characters to type . > >=20 > > IMO, this is pretty useless and I'd rather not see them in the drivers I > > maintain, sorry. > > It is not a NACK from me; yet from a high-level perspective I agree with > Felipe. OK I'd rather not merge something that driver people don't want to use. Vinod? -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 00/27] add pm_runtime_last_busy_and_autosuspend() helper
On Wed, Sep 24, 2014 at 10:28:07PM +0200, Rafael J. Wysocki wrote: > > OK, I guess this is as good as it gets. > > What tree would you like it go through? Since rest of the patches are dependent upon 1st patch which should go thru your tree, we should merge this thru your tree Thanks -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 00/27] add pm_runtime_last_busy_and_autosuspend() helper
On Wednesday, September 24, 2014 09:44:50 PM Vinod Koul wrote: > This patch series adds a simple macro pm_runtime_last_busy_and_autosuspend() > which invokes pm_runtime_mark_last_busy() and pm_runtime_put_autosuspend() > sequentially. Then we do a tree wide update of current patterns which are > present. As evident from log below this pattern is frequent in the > kernel. > > This series can be found at > git://git.kernel.org/pub/scm/linux/kernel/git/vkoul/slave-dma.git > topic/pm_runtime_last_busy_and_autosuspend > > Fengguang's kbuild has tested it so it shouldn't break things for anyone. > Barring one patch (explictyly mentioned in its changelog) rest are simple > replacements. > > If all are okay, this should be merged thru PM tree as it depends on macro > addition. > > Subhransu S. Prusty (1): > PM: Add helper pm_runtime_last_busy_and_autosuspend() > > Vinod Koul (26): > dmaengine: ste_dma: use pm_runtime_last_busy_and_autosuspend helper > extcon: arizona: use pm_runtime_last_busy_and_autosuspend helper > drm/i915: use pm_runtime_last_busy_and_autosuspend helper > drm/nouveau: use pm_runtime_last_busy_and_autosuspend helper > drm/radeon: use pm_runtime_last_busy_and_autosuspend helper > vga_switcheroo: use pm_runtime_last_busy_and_autosuspend helper > i2c: designware: use pm_runtime_last_busy_and_autosuspend helper > i2c: omap: use pm_runtime_last_busy_and_autosuspend helper > i2c: qup: use pm_runtime_last_busy_and_autosuspend helper > mfd: ab8500-gpadc: use pm_runtime_last_busy_and_autosuspend helper > mfd: arizona: use pm_runtime_last_busy_and_autosuspend helper > mei: use pm_runtime_last_busy_and_autosuspend helper > mmc: use pm_runtime_last_busy_and_autosuspend helper > mmc: mmci: use pm_runtime_last_busy_and_autosuspend helper > mmc: omap_hsmmc: use pm_runtime_last_busy_and_autosuspend helper > mmc: sdhci-pxav3: use pm_runtime_last_busy_and_autosuspend helper > mmc: sdhci: use pm_runtime_last_busy_and_autosuspend helper > NFC: trf7970a: use pm_runtime_last_busy_and_autosuspend helper > pm2301-charger: use pm_runtime_last_busy_and_autosuspend helper > spi: omap2-mcspi: use pm_runtime_last_busy_and_autosuspend helper > spi: orion: use pm_runtime_last_busy_and_autosuspend helper > spi: ti-qspi: use pm_runtime_last_busy_and_autosuspend helper > spi: core: use pm_runtime_last_busy_and_autosuspend helper > tty: serial: omap: use pm_runtime_last_busy_and_autosuspend helper > usb: musb: omap2430: use pm_runtime_last_busy_and_autosuspend helper > video: fbdev: use pm_runtime_last_busy_and_autosuspend helper > > Documentation/power/runtime_pm.txt |4 ++ > drivers/dma/ste_dma40.c | 30 - > drivers/extcon/extcon-arizona.c |6 +-- > drivers/gpu/drm/i915/intel_pm.c |3 +- > drivers/gpu/drm/nouveau/nouveau_connector.c |3 +- > drivers/gpu/drm/nouveau/nouveau_drm.c |9 +--- > drivers/gpu/drm/radeon/radeon_connectors.c | 15 ++ > drivers/gpu/drm/radeon/radeon_drv.c |5 +- > drivers/gpu/drm/radeon/radeon_kms.c |6 +-- > drivers/gpu/vga/vga_switcheroo.c|7 +-- > drivers/i2c/busses/i2c-designware-core.c|3 +- > drivers/i2c/busses/i2c-omap.c |6 +-- > drivers/i2c/busses/i2c-qup.c|3 +- > drivers/mfd/ab8500-gpadc.c |6 +-- > drivers/mfd/arizona-irq.c |3 +- > drivers/misc/mei/client.c | 12 ++ > drivers/mmc/core/core.c |3 +- > drivers/mmc/host/mmci.c | 12 ++ > drivers/mmc/host/omap_hsmmc.c | 19 ++--- > drivers/mmc/host/sdhci-pxav3.c |6 +-- > drivers/mmc/host/sdhci.c|3 +- > drivers/nfc/trf7970a.c |3 +- > drivers/power/pm2301_charger.c |3 +- > drivers/spi/spi-omap2-mcspi.c |9 +--- > drivers/spi/spi-orion.c |3 +- > drivers/spi/spi-ti-qspi.c |5 +- > drivers/spi/spi.c |6 +-- > drivers/tty/serial/omap-serial.c| 60 > +-- > drivers/usb/musb/omap2430.c |6 +-- > drivers/video/fbdev/auo_k190x.c |9 +--- > include/linux/pm_runtime.h |6 +++ > 31 files changed, 97 insertions(+), 177 deletions(-) OK, I guess this is as good as it gets. What tree would you like it go through? -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 00/27] add pm_runtime_last_busy_and_autosuspend() helper
This patch series adds a simple macro pm_runtime_last_busy_and_autosuspend() which invokes pm_runtime_mark_last_busy() and pm_runtime_put_autosuspend() sequentially. Then we do a tree wide update of current patterns which are present. As evident from log below this pattern is frequent in the kernel. This series can be found at git://git.kernel.org/pub/scm/linux/kernel/git/vkoul/slave-dma.git topic/pm_runtime_last_busy_and_autosuspend Fengguang's kbuild has tested it so it shouldn't break things for anyone. Barring one patch (explictyly mentioned in its changelog) rest are simple replacements. If all are okay, this should be merged thru PM tree as it depends on macro addition. Subhransu S. Prusty (1): PM: Add helper pm_runtime_last_busy_and_autosuspend() Vinod Koul (26): dmaengine: ste_dma: use pm_runtime_last_busy_and_autosuspend helper extcon: arizona: use pm_runtime_last_busy_and_autosuspend helper drm/i915: use pm_runtime_last_busy_and_autosuspend helper drm/nouveau: use pm_runtime_last_busy_and_autosuspend helper drm/radeon: use pm_runtime_last_busy_and_autosuspend helper vga_switcheroo: use pm_runtime_last_busy_and_autosuspend helper i2c: designware: use pm_runtime_last_busy_and_autosuspend helper i2c: omap: use pm_runtime_last_busy_and_autosuspend helper i2c: qup: use pm_runtime_last_busy_and_autosuspend helper mfd: ab8500-gpadc: use pm_runtime_last_busy_and_autosuspend helper mfd: arizona: use pm_runtime_last_busy_and_autosuspend helper mei: use pm_runtime_last_busy_and_autosuspend helper mmc: use pm_runtime_last_busy_and_autosuspend helper mmc: mmci: use pm_runtime_last_busy_and_autosuspend helper mmc: omap_hsmmc: use pm_runtime_last_busy_and_autosuspend helper mmc: sdhci-pxav3: use pm_runtime_last_busy_and_autosuspend helper mmc: sdhci: use pm_runtime_last_busy_and_autosuspend helper NFC: trf7970a: use pm_runtime_last_busy_and_autosuspend helper pm2301-charger: use pm_runtime_last_busy_and_autosuspend helper spi: omap2-mcspi: use pm_runtime_last_busy_and_autosuspend helper spi: orion: use pm_runtime_last_busy_and_autosuspend helper spi: ti-qspi: use pm_runtime_last_busy_and_autosuspend helper spi: core: use pm_runtime_last_busy_and_autosuspend helper tty: serial: omap: use pm_runtime_last_busy_and_autosuspend helper usb: musb: omap2430: use pm_runtime_last_busy_and_autosuspend helper video: fbdev: use pm_runtime_last_busy_and_autosuspend helper Documentation/power/runtime_pm.txt |4 ++ drivers/dma/ste_dma40.c | 30 - drivers/extcon/extcon-arizona.c |6 +-- drivers/gpu/drm/i915/intel_pm.c |3 +- drivers/gpu/drm/nouveau/nouveau_connector.c |3 +- drivers/gpu/drm/nouveau/nouveau_drm.c |9 +--- drivers/gpu/drm/radeon/radeon_connectors.c | 15 ++ drivers/gpu/drm/radeon/radeon_drv.c |5 +- drivers/gpu/drm/radeon/radeon_kms.c |6 +-- drivers/gpu/vga/vga_switcheroo.c|7 +-- drivers/i2c/busses/i2c-designware-core.c|3 +- drivers/i2c/busses/i2c-omap.c |6 +-- drivers/i2c/busses/i2c-qup.c|3 +- drivers/mfd/ab8500-gpadc.c |6 +-- drivers/mfd/arizona-irq.c |3 +- drivers/misc/mei/client.c | 12 ++ drivers/mmc/core/core.c |3 +- drivers/mmc/host/mmci.c | 12 ++ drivers/mmc/host/omap_hsmmc.c | 19 ++--- drivers/mmc/host/sdhci-pxav3.c |6 +-- drivers/mmc/host/sdhci.c|3 +- drivers/nfc/trf7970a.c |3 +- drivers/power/pm2301_charger.c |3 +- drivers/spi/spi-omap2-mcspi.c |9 +--- drivers/spi/spi-orion.c |3 +- drivers/spi/spi-ti-qspi.c |5 +- drivers/spi/spi.c |6 +-- drivers/tty/serial/omap-serial.c| 60 +-- drivers/usb/musb/omap2430.c |6 +-- drivers/video/fbdev/auo_k190x.c |9 +--- include/linux/pm_runtime.h |6 +++ 31 files changed, 97 insertions(+), 177 deletions(-) Thanks -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
