Re: [PATCH 03/15] usb: dwc3: Update DWC_usb31 GTXFIFOSIZ reg fields

[Thinh Nguyen]

On 1/8/2018 4:02 AM, Felipe Balbi wrote:
> 
> Hi,
> 
> Thinh Nguyen  writes:
>> Update two GTXFIFOSIZ bit fields for the DWC_usb31 controller. TXFDEP
>> is a 15-bit value instead of 16-bit value, and bit 15 is TXFRAMNUM.
>>
>> The GTXFIFOSIZ register for DWC_usb31 is as follows:
>>   +---+---+--+
>>   | BITS  | Name  | Description  |
>>   +===+===+==+
>>   | 31:16 | TXFSTADDR | Transmit FIFOn RAM Start Address |
>>   | 15| TXFRAMNUM | Asynchronous/Periodic TXFIFO |
>>   | 14:0  | TXFDEP| TXFIFO Depth |
>>   +---+---+--+
>>
>> Signed-off-by: Thinh Nguyen 
>> ---
>>   drivers/usb/dwc3/core.h | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
>> index 4a4a4c98508c..6ebf7ddc547d 100644
>> --- a/drivers/usb/dwc3/core.h
>> +++ b/drivers/usb/dwc3/core.h
>> @@ -239,6 +239,8 @@
>>   #define DWC3_GUSB3PIPECTL_TX_DEEPH(n)  ((n) << 1)
>>   
>>   /* Global TX Fifo Size Register */
>> +#define DWC3_USB31_GTXFIFOSIZ_TXFRAMNUM BIT(15) /* DWC_usb31 
>> only */
>> +#define DWC3_USB31_GTXFIFOSIZ_TXFDEF(n) ((n) & 0x7fff)  /* DWC_usb31 
>> only */
> 
> just to make it shorter, do you mind replacing DWC3_USB31 with DWC31 ?
> 

Sure, I'll make the change.

Thanks,
Thinh
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 03/15] usb: dwc3: Update DWC_usb31 GTXFIFOSIZ reg fields

[Felipe Balbi]

Hi,

Thinh Nguyen  writes:
> Update two GTXFIFOSIZ bit fields for the DWC_usb31 controller. TXFDEP
> is a 15-bit value instead of 16-bit value, and bit 15 is TXFRAMNUM.
>
> The GTXFIFOSIZ register for DWC_usb31 is as follows:
>  +---+---+--+
>  | BITS  | Name  | Description  |
>  +===+===+==+
>  | 31:16 | TXFSTADDR | Transmit FIFOn RAM Start Address |
>  | 15| TXFRAMNUM | Asynchronous/Periodic TXFIFO |
>  | 14:0  | TXFDEP| TXFIFO Depth |
>  +---+---+--+
>
> Signed-off-by: Thinh Nguyen 
> ---
>  drivers/usb/dwc3/core.h | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
> index 4a4a4c98508c..6ebf7ddc547d 100644
> --- a/drivers/usb/dwc3/core.h
> +++ b/drivers/usb/dwc3/core.h
> @@ -239,6 +239,8 @@
>  #define DWC3_GUSB3PIPECTL_TX_DEEPH(n)((n) << 1)
>  
>  /* Global TX Fifo Size Register */
> +#define DWC3_USB31_GTXFIFOSIZ_TXFRAMNUM  BIT(15) /* DWC_usb31 
> only */
> +#define DWC3_USB31_GTXFIFOSIZ_TXFDEF(n)  ((n) & 0x7fff)  /* DWC_usb31 
> only */

just to make it shorter, do you mind replacing DWC3_USB31 with DWC31 ?

-- 
balbi


signature.asc
Description: PGP signature

[PATCH 03/15] usb: dwc3: Update DWC_usb31 GTXFIFOSIZ reg fields

[Thinh Nguyen]

Update two GTXFIFOSIZ bit fields for the DWC_usb31 controller. TXFDEP
is a 15-bit value instead of 16-bit value, and bit 15 is TXFRAMNUM.

The GTXFIFOSIZ register for DWC_usb31 is as follows:
 +---+---+--+
 | BITS  | Name  | Description  |
 +===+===+==+
 | 31:16 | TXFSTADDR | Transmit FIFOn RAM Start Address |
 | 15| TXFRAMNUM | Asynchronous/Periodic TXFIFO |
 | 14:0  | TXFDEP| TXFIFO Depth |
 +---+---+--+

Signed-off-by: Thinh Nguyen 
---
 drivers/usb/dwc3/core.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
index 4a4a4c98508c..6ebf7ddc547d 100644
--- a/drivers/usb/dwc3/core.h
+++ b/drivers/usb/dwc3/core.h
@@ -239,6 +239,8 @@
 #define DWC3_GUSB3PIPECTL_TX_DEEPH(n)  ((n) << 1)
 
 /* Global TX Fifo Size Register */
+#define DWC3_USB31_GTXFIFOSIZ_TXFRAMNUMBIT(15) /* DWC_usb31 
only */
+#define DWC3_USB31_GTXFIFOSIZ_TXFDEF(n)((n) & 0x7fff)  /* DWC_usb31 
only */
 #define DWC3_GTXFIFOSIZ_TXFDEF(n)  ((n) & 0x)
 #define DWC3_GTXFIFOSIZ_TXFSTADDR(n)   ((n) & 0x)
 
-- 
2.11.0

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html