Re: [PATCH 076/100] usb: gadget: udc-core: copy dma-related parameters from parent
On Tue, Feb 26, 2013 at 10:59:12PM +0400, Sergei Shtylyov wrote: > Hello. > > On 26-02-2013 13:34, Felipe Balbi wrote: > > >gadget's device pointer now is guaranteed to > >have valid dma_mask, dma_parms and coherent_dma_mask > >fields since we're always copying from our > >parent device. > > >Signed-off-by: Felipe Balbi > >--- > > drivers/usb/gadget/udc-core.c | 4 > > 1 file changed, 4 insertions(+) > > >diff --git a/drivers/usb/gadget/udc-core.c b/drivers/usb/gadget/udc-core.c > >index 8a1eeb2..08d5df7 100644 > >--- a/drivers/usb/gadget/udc-core.c > >+++ b/drivers/usb/gadget/udc-core.c > >@@ -185,6 +185,10 @@ int usb_add_gadget_udc(struct device *parent, struct > >usb_gadget *gadget) > > > > dev_set_name(&gadget->dev, "gadget"); > > > >+dma_set_coherent_mas(&gadget->dev, parent->coherent_dma_mask); > >s/mas/mask/ right, that I fixed earlier today ;-) http://git.kernel.org/?p=linux/kernel/git/balbi/usb.git;a=commitdiff;h=517efc0e7fdbf0fb318ef2b0d28d1615d22513c0 For whatever reason, I ended up sending the older version. Guess I forgot to format-patch again :-s -- balbi signature.asc Description: Digital signature
Re: [PATCH 076/100] usb: gadget: udc-core: copy dma-related parameters from parent
Hello. On 26-02-2013 13:34, Felipe Balbi wrote: gadget's device pointer now is guaranteed to have valid dma_mask, dma_parms and coherent_dma_mask fields since we're always copying from our parent device. Signed-off-by: Felipe Balbi --- drivers/usb/gadget/udc-core.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/usb/gadget/udc-core.c b/drivers/usb/gadget/udc-core.c index 8a1eeb2..08d5df7 100644 --- a/drivers/usb/gadget/udc-core.c +++ b/drivers/usb/gadget/udc-core.c @@ -185,6 +185,10 @@ int usb_add_gadget_udc(struct device *parent, struct usb_gadget *gadget) dev_set_name(&gadget->dev, "gadget"); + dma_set_coherent_mas(&gadget->dev, parent->coherent_dma_mask); s/mas/mask/ WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 076/100] usb: gadget: udc-core: copy dma-related parameters from parent
Hi, On Tue, Feb 26, 2013 at 11:34:38AM +0200, Felipe Balbi wrote: > gadget's device pointer now is guaranteed to > have valid dma_mask, dma_parms and coherent_dma_mask > fields since we're always copying from our > parent device. > > Signed-off-by: Felipe Balbi > --- > drivers/usb/gadget/udc-core.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/drivers/usb/gadget/udc-core.c b/drivers/usb/gadget/udc-core.c > index 8a1eeb2..08d5df7 100644 > --- a/drivers/usb/gadget/udc-core.c > +++ b/drivers/usb/gadget/udc-core.c > @@ -185,6 +185,10 @@ int usb_add_gadget_udc(struct device *parent, struct > usb_gadget *gadget) > > dev_set_name(&gadget->dev, "gadget"); > > + dma_set_coherent_mas(&gadget->dev, parent->coherent_dma_mask); fixed this one > + gadget->dev.dma_mask = dev->dma_mask; fixed this one -- balbi signature.asc Description: Digital signature
[PATCH 076/100] usb: gadget: udc-core: copy dma-related parameters from parent
gadget's device pointer now is guaranteed to have valid dma_mask, dma_parms and coherent_dma_mask fields since we're always copying from our parent device. Signed-off-by: Felipe Balbi --- drivers/usb/gadget/udc-core.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/usb/gadget/udc-core.c b/drivers/usb/gadget/udc-core.c index 8a1eeb2..08d5df7 100644 --- a/drivers/usb/gadget/udc-core.c +++ b/drivers/usb/gadget/udc-core.c @@ -185,6 +185,10 @@ int usb_add_gadget_udc(struct device *parent, struct usb_gadget *gadget) dev_set_name(&gadget->dev, "gadget"); + dma_set_coherent_mas(&gadget->dev, parent->coherent_dma_mask); + gadget->dev.dma_parms = parent->dma_parms; + gadget->dev.dma_mask = dev->dma_mask; + ret = device_register(&gadget->dev); if (ret) goto err2; -- 1.8.1.rc1.5.g7e0651a -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
