Re: [PATCH 1/1] usb: xhci: cleanup cmd_completion in xhci_virt_device

2016-11-03 Thread Lu Baolu 
Hi,

On 11/03/2016 07:36 PM, Mathias Nyman wrote:
> On 03.11.2016 12:22, Sergei Shtylyov wrote:
>> On 11/3/2016 9:48 AM, Lu Baolu wrote:
>>
>>> cmd_completion in struct xhci_virt_device is legacy. With command
>>> strutcture and command queue introduced in xhci, cmd_completion is
>>
>> Structure.
>>
>
> I'll fix that while applying the patch, no need to resend

Thank you.

Best regards,
Lu Baolu

>
> -Mathias
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] usb: xhci: cleanup cmd_completion in xhci_virt_device

2016-11-03 Thread Mathias Nyman 

On 03.11.2016 12:22, Sergei Shtylyov wrote:

On 11/3/2016 9:48 AM, Lu Baolu wrote:


cmd_completion in struct xhci_virt_device is legacy. With command
strutcture and command queue introduced in xhci, cmd_completion is


Structure.



I'll fix that while applying the patch, no need to resend

-Mathias

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] usb: xhci: cleanup cmd_completion in xhci_virt_device

2016-11-03 Thread Mathias Nyman 

On 03.11.2016 08:48, Lu Baolu wrote:

cmd_completion in struct xhci_virt_device is legacy. With command
strutcture and command queue introduced in xhci, cmd_completion is
not used any more. This patch removes it.

Signed-off-by: Lu Baolu 
---
  drivers/usb/host/xhci-mem.c | 1 -
  drivers/usb/host/xhci.h | 1 -
  2 files changed, 2 deletions(-)



Thanks, I'll apply it.

-Mathias

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] usb: xhci: cleanup cmd_completion in xhci_virt_device

2016-11-03 Thread Sergei Shtylyov 

On 11/3/2016 9:48 AM, Lu Baolu wrote:


cmd_completion in struct xhci_virt_device is legacy. With command
strutcture and command queue introduced in xhci, cmd_completion is


   Structure.


not used any more. This patch removes it.

Signed-off-by: Lu Baolu 

[...]

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 1/1] usb: xhci: cleanup cmd_completion in xhci_virt_device

2016-11-03 Thread Lu Baolu 
cmd_completion in struct xhci_virt_device is legacy. With command
strutcture and command queue introduced in xhci, cmd_completion is
not used any more. This patch removes it.

Signed-off-by: Lu Baolu 
---
 drivers/usb/host/xhci-mem.c | 1 -
 drivers/usb/host/xhci.h | 1 -
 2 files changed, 2 deletions(-)

diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c
index 6afe323..8102a86 100644
--- a/drivers/usb/host/xhci-mem.c
+++ b/drivers/usb/host/xhci-mem.c
@@ -1032,7 +1032,6 @@ int xhci_alloc_virt_device(struct xhci_hcd *xhci, int 
slot_id,
goto fail;
dev->num_rings_cached = 0;
 
-   init_completion(>cmd_completion);
dev->udev = udev;
 
/* Point to output device context in dcbaa. */
diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h
index f945380..e2b62e0 100644
--- a/drivers/usb/host/xhci.h
+++ b/drivers/usb/host/xhci.h
@@ -997,7 +997,6 @@ struct xhci_virt_device {
int num_rings_cached;
 #defineXHCI_MAX_RINGS_CACHED   31
struct xhci_virt_ep eps[31];
-   struct completion   cmd_completion;
u8  fake_port;
u8  real_port;
struct xhci_interval_bw_table   *bw_table;
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html