[PATCH 2/2] usb: gadget: f_midi: check for error on usb_ep_queue
From: "Felipe F. Tonello" f_midi is not checking weather the is an error on usb_ep_queue request, ignoring potential problems, such as memory leaks. Signed-off-by: Felipe F. Tonello --- drivers/usb/gadget/function/f_midi.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/function/f_midi.c b/drivers/usb/gadget/function/f_midi.c index ad50a67..a5e446d 100644 --- a/drivers/usb/gadget/function/f_midi.c +++ b/drivers/usb/gadget/function/f_midi.c @@ -543,8 +543,14 @@ static void f_midi_transmit(struct f_midi *midi, struct usb_request *req) } } - if (req->length > 0) - usb_ep_queue(ep, req, GFP_ATOMIC); + if (req->length > 0) { + int err; + + err = usb_ep_queue(ep, req, GFP_ATOMIC); + if (err < 0) + ERROR(midi, "%s queue req: %d\n", + midi->out_ep->name, err); + } else free_ep_req(ep, req); } -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/2] usb: gadget: f_midi: check for error on usb_ep_queue
On Fri, Sep 18, 2015 at 06:12:41PM +0100, e...@felipetonello.com wrote: > From: "Felipe F. Tonello" > > f_midi is not checking weather the is an error on usb_ep_queue > request, ignoring potential problems, such as memory leaks. > > Signed-off-by: Felipe F. Tonello > --- > drivers/usb/gadget/function/f_midi.c | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/gadget/function/f_midi.c > b/drivers/usb/gadget/function/f_midi.c > index ad50a67..a5e446d 100644 > --- a/drivers/usb/gadget/function/f_midi.c > +++ b/drivers/usb/gadget/function/f_midi.c > @@ -543,8 +543,14 @@ static void f_midi_transmit(struct f_midi *midi, struct > usb_request *req) > } > } > > - if (req->length > 0) > - usb_ep_queue(ep, req, GFP_ATOMIC); > + if (req->length > 0) { > + int err; > + > + err = usb_ep_queue(ep, req, GFP_ATOMIC); > + if (err < 0) > + ERROR(midi, "%s queue req: %d\n", > + midi->out_ep->name, err); > + } > else yeah, cool, but you need to fix the style here. This else needs to be after the curly brace and you need to curly brace to the else branch too. > free_ep_req(ep, req); > } > -- > 2.1.4 > -- balbi signature.asc Description: Digital signature
Re: [PATCH 2/2] usb: gadget: f_midi: check for error on usb_ep_queue
Hello. On 9/18/2015 8:12 PM, e...@felipetonello.com wrote: From: "Felipe F. Tonello" f_midi is not checking weather the is an error on usb_ep_queue request, ignoring potential problems, such as memory leaks. Signed-off-by: Felipe F. Tonello --- drivers/usb/gadget/function/f_midi.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/function/f_midi.c b/drivers/usb/gadget/function/f_midi.c index ad50a67..a5e446d 100644 --- a/drivers/usb/gadget/function/f_midi.c +++ b/drivers/usb/gadget/function/f_midi.c @@ -543,8 +543,14 @@ static void f_midi_transmit(struct f_midi *midi, struct usb_request *req) } } - if (req->length > 0) - usb_ep_queue(ep, req, GFP_ATOMIC); + if (req->length > 0) { + int err; + + err = usb_ep_queue(ep, req, GFP_ATOMIC); + if (err < 0) + ERROR(midi, "%s queue req: %d\n", + midi->out_ep->name, err); + } else } else { free_ep_req(ep, req); } } The lines added above show the proper kernel CodingStyle. } should be on the same line as *else* and {} should be used in all branches of the *if* statement if at least one branch has them. MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/2] usb: gadget: f_midi: check for error on usb_ep_queue
On Fri, Sep 18, 2015 at 06:12:41PM +0100, e...@felipetonello.com wrote: > From: "Felipe F. Tonello" > > f_midi is not checking weather the is an error on usb_ep_queue %s/weather/whether %s/the/there > request, ignoring potential problems, such as memory leaks. > > Signed-off-by: Felipe F. Tonello > --- > drivers/usb/gadget/function/f_midi.c | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/gadget/function/f_midi.c > b/drivers/usb/gadget/function/f_midi.c > index ad50a67..a5e446d 100644 > --- a/drivers/usb/gadget/function/f_midi.c > +++ b/drivers/usb/gadget/function/f_midi.c > @@ -543,8 +543,14 @@ static void f_midi_transmit(struct f_midi *midi, struct > usb_request *req) > } > } > > - if (req->length > 0) > - usb_ep_queue(ep, req, GFP_ATOMIC); > + if (req->length > 0) { > + int err; > + > + err = usb_ep_queue(ep, req, GFP_ATOMIC); > + if (err < 0) > + ERROR(midi, "%s queue req: %d\n", > + midi->out_ep->name, err); > + } > else > free_ep_req(ep, req); > } > -- > 2.1.4 > -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/2] usb: gadget: f_midi: check for error on usb_ep_queue
Hi Chen, On Mon, Sep 21, 2015 at 7:30 AM, Peter Chen wrote: > On Fri, Sep 18, 2015 at 06:12:41PM +0100, e...@felipetonello.com wrote: >> From: "Felipe F. Tonello" >> >> f_midi is not checking weather the is an error on usb_ep_queue > > %s/weather/whether > %s/the/there I fixed it on v3. Did you receive it? Felipe -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/2] usb: gadget: f_midi: check for error on usb_ep_queue
On Mon, Sep 21, 2015 at 09:16:05AM +0100, Felipe Tonello wrote: > Hi Chen, > > On Mon, Sep 21, 2015 at 7:30 AM, Peter Chen wrote: > > On Fri, Sep 18, 2015 at 06:12:41PM +0100, e...@felipetonello.com wrote: > >> From: "Felipe F. Tonello" > >> > >> f_midi is not checking weather the is an error on usb_ep_queue > > > > %s/weather/whether > > %s/the/there > > I fixed it on v3. Did you receive it? > oh, get it, You may add "--subject-prefix="PATCH v3" when you format patch, in that case, the reader can see "PATCH v3 2/2" at the subject, and know it is the third version. Your two changes for chipidea are ok, I will queue them. -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/2] usb: gadget: f_midi: check for error on usb_ep_queue
Hi Peter, On Mon, Sep 21, 2015 at 8:49 AM, Peter Chen wrote: > On Mon, Sep 21, 2015 at 09:16:05AM +0100, Felipe Tonello wrote: >> Hi Chen, >> >> On Mon, Sep 21, 2015 at 7:30 AM, Peter Chen wrote: >> > On Fri, Sep 18, 2015 at 06:12:41PM +0100, e...@felipetonello.com wrote: >> >> From: "Felipe F. Tonello" >> >> >> >> f_midi is not checking weather the is an error on usb_ep_queue >> > >> > %s/weather/whether >> > %s/the/there >> >> I fixed it on v3. Did you receive it? >> > > oh, get it, You may add "--subject-prefix="PATCH v3" when you format > patch, in that case, the reader can see "PATCH v3 2/2" at the subject, > and know it is the third version. > > Your two changes for chipidea are ok, I will queue them. Thanks. Sorry about that, I thought I did it. Felipe -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html