Re: [PATCH 2/5] TTY: bfin_jtag_comm: remove incorrect wait_until_sent operation

2015-03-05 Thread Peter Hurley
On 03/04/2015 04:39 AM, Johan Hovold wrote:
 Remove incorrect and redundant wait_until_sent operation, which waits
 for the driver buffer rather than any hardware buffers to drain,
 something which is already taken care of by the tty layer (and
 chars_in_buffer).

Reviewed-by: Peter Hurley pe...@hurleysoftware.com

--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH 2/5] TTY: bfin_jtag_comm: remove incorrect wait_until_sent operation

2015-03-04 Thread Johan Hovold
Remove incorrect and redundant wait_until_sent operation, which waits
for the driver buffer rather than any hardware buffers to drain,
something which is already taken care of by the tty layer (and
chars_in_buffer).

Signed-off-by: Johan Hovold jo...@kernel.org
---
 drivers/tty/bfin_jtag_comm.c | 13 -
 1 file changed, 13 deletions(-)

diff --git a/drivers/tty/bfin_jtag_comm.c b/drivers/tty/bfin_jtag_comm.c
index d7b198c400c7..ce24182f8514 100644
--- a/drivers/tty/bfin_jtag_comm.c
+++ b/drivers/tty/bfin_jtag_comm.c
@@ -210,18 +210,6 @@ bfin_jc_chars_in_buffer(struct tty_struct *tty)
return circ_cnt(bfin_jc_write_buf);
 }
 
-static void
-bfin_jc_wait_until_sent(struct tty_struct *tty, int timeout)
-{
-   unsigned long expire = jiffies + timeout;
-   while (!circ_empty(bfin_jc_write_buf)) {
-   if (signal_pending(current))
-   break;
-   if (time_after(jiffies, expire))
-   break;
-   }
-}
-
 static const struct tty_operations bfin_jc_ops = {
.open= bfin_jc_open,
.close   = bfin_jc_close,
@@ -230,7 +218,6 @@ static const struct tty_operations bfin_jc_ops = {
.flush_chars = bfin_jc_flush_chars,
.write_room  = bfin_jc_write_room,
.chars_in_buffer = bfin_jc_chars_in_buffer,
-   .wait_until_sent = bfin_jc_wait_until_sent,
 };
 
 static int __init bfin_jc_init(void)
-- 
2.0.5

--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html