Re: [PATCH 23/24] USB: gadget: function: Remove redundant license text
On Mon, Nov 06, 2017 at 11:05:44PM +, Vincent Pelletier wrote: > On Mon, 6 Nov 2017 15:37:32 +0100, Greg Kroah-Hartman > wrote: > > Now that the SPDX tag is in all USB files, that identifies the license > > in a specific and legally-defined manner. So the extra GPL text wording > > can be removed as it is no longer needed at all. > > > > This is done on a quest to remove the 700+ different ways that files in > > the kernel describe the GPL license text. And there's unneeded stuff > > like the address (sometimes incorrect) for the FSF which is never > > needed. > > > > No copyright headers or other non-license-description text was removed. > > > > Cc: Felipe Balbi > > Cc: Laurent Pinchart > > Cc: Oliver Neukum > > Cc: Johan Hovold > > Cc: Michal Nazarewicz > > Cc: Vincent Pelletier > > Acked-by: Vincent Pelletier Thanks for the ack. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 23/24] USB: gadget: function: Remove redundant license text
On Mon, Nov 06, 2017 at 04:55:06PM +0100, Michal Nazarewicz wrote: > On Mon, Nov 06 2017, Greg Kroah-Hartman wrote: > > Now that the SPDX tag is in all USB files, that identifies the license > > in a specific and legally-defined manner. So the extra GPL text wording > > can be removed as it is no longer needed at all. > > > > This is done on a quest to remove the 700+ different ways that files in > > the kernel describe the GPL license text. And there's unneeded stuff > > like the address (sometimes incorrect) for the FSF which is never > > needed. > > > > No copyright headers or other non-license-description text was removed. > > > > Cc: Felipe Balbi > > Cc: Laurent Pinchart > > Cc: Oliver Neukum > > Cc: Johan Hovold > > Cc: Michal Nazarewicz > > Acked-by: Michal Nazarewicz Thanks! greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 23/24] USB: gadget: function: Remove redundant license text
On Tue, Nov 07, 2017 at 04:37:38AM +0200, Laurent Pinchart wrote: > Hi Greg, > > Thank you for the patch. > > On Monday, 6 November 2017 16:37:32 EET Greg Kroah-Hartman wrote: > > Now that the SPDX tag is in all USB files, that identifies the license > > in a specific and legally-defined manner. So the extra GPL text wording > > can be removed as it is no longer needed at all. > > > > This is done on a quest to remove the 700+ different ways that files in > > the kernel describe the GPL license text. And there's unneeded stuff > > like the address (sometimes incorrect) for the FSF which is never > > needed. > > > > No copyright headers or other non-license-description text was removed. > > > > Cc: Felipe Balbi > > Cc: Laurent Pinchart > > Cc: Oliver Neukum > > Cc: Johan Hovold > > Cc: Michal Nazarewicz > > Cc: Vincent Pelletier > > Cc: Jerry Zhang > > Cc: John Keeping > > Cc: Krzysztof Opasiak > > Cc: Abdulhadi Mohamed > > Cc: Matthew Wilcox > > Cc: Janusz Dziedzic > > Signed-off-by: Greg Kroah-Hartman > > Acked-by: Laurent Pinchart > > I have however not checked whether the SPDX tag matches the license text for > every file (GPLv2 vs. GPLv2+), I expect that to have been verified when the > SPDX tags got merged. Yes, it was, and I verified it again when I removed this license text. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 23/24] USB: gadget: function: Remove redundant license text
Hi Greg, Thank you for the patch. On Monday, 6 November 2017 16:37:32 EET Greg Kroah-Hartman wrote: > Now that the SPDX tag is in all USB files, that identifies the license > in a specific and legally-defined manner. So the extra GPL text wording > can be removed as it is no longer needed at all. > > This is done on a quest to remove the 700+ different ways that files in > the kernel describe the GPL license text. And there's unneeded stuff > like the address (sometimes incorrect) for the FSF which is never > needed. > > No copyright headers or other non-license-description text was removed. > > Cc: Felipe Balbi > Cc: Laurent Pinchart > Cc: Oliver Neukum > Cc: Johan Hovold > Cc: Michal Nazarewicz > Cc: Vincent Pelletier > Cc: Jerry Zhang > Cc: John Keeping > Cc: Krzysztof Opasiak > Cc: Abdulhadi Mohamed > Cc: Matthew Wilcox > Cc: Janusz Dziedzic > Signed-off-by: Greg Kroah-Hartman Acked-by: Laurent Pinchart I have however not checked whether the SPDX tag matches the license text for every file (GPLv2 vs. GPLv2+), I expect that to have been verified when the SPDX tags got merged. > --- > drivers/usb/gadget/function/f_acm.c| 4 > drivers/usb/gadget/function/f_ecm.c| 5 - > drivers/usb/gadget/function/f_eem.c| 5 - > drivers/usb/gadget/function/f_fs.c | 5 - > drivers/usb/gadget/function/f_hid.c| 5 - > drivers/usb/gadget/function/f_loopback.c | 5 - > drivers/usb/gadget/function/f_midi.c | 2 -- > drivers/usb/gadget/function/f_ncm.c| 5 - > drivers/usb/gadget/function/f_obex.c | 5 - > drivers/usb/gadget/function/f_phonet.c | 4 > drivers/usb/gadget/function/f_printer.c| 5 - > drivers/usb/gadget/function/f_rndis.c | 5 - > drivers/usb/gadget/function/f_serial.c | 4 > drivers/usb/gadget/function/f_sourcesink.c | 5 - > drivers/usb/gadget/function/f_subset.c | 5 - > drivers/usb/gadget/function/f_tcm.c| 1 - > drivers/usb/gadget/function/f_uac1.c | 5 - > drivers/usb/gadget/function/f_uac1_legacy.c| 2 -- > drivers/usb/gadget/function/f_uac2.c | 5 - > drivers/usb/gadget/function/f_uvc.c| 5 - > drivers/usb/gadget/function/f_uvc.h| 5 - > drivers/usb/gadget/function/rndis.c| 4 > drivers/usb/gadget/function/rndis.h| 4 > drivers/usb/gadget/function/storage_common.c | 5 - > drivers/usb/gadget/function/u_audio.c | 10 -- > drivers/usb/gadget/function/u_audio.h | 11 --- > drivers/usb/gadget/function/u_ecm.h| 4 > drivers/usb/gadget/function/u_eem.h| 4 > drivers/usb/gadget/function/u_ether.c | 5 - > drivers/usb/gadget/function/u_ether.h | 5 - > drivers/usb/gadget/function/u_ether_configfs.h | 4 > drivers/usb/gadget/function/u_fs.h | 4 > drivers/usb/gadget/function/u_gether.h | 4 > drivers/usb/gadget/function/u_hid.h| 4 > drivers/usb/gadget/function/u_midi.h | 4 > drivers/usb/gadget/function/u_ncm.h| 4 > drivers/usb/gadget/function/u_phonet.h | 4 > drivers/usb/gadget/function/u_printer.h| 4 > drivers/usb/gadget/function/u_rndis.h | 4 > drivers/usb/gadget/function/u_serial.c | 4 > drivers/usb/gadget/function/u_serial.h | 4 > drivers/usb/gadget/function/u_tcm.h| 4 > drivers/usb/gadget/function/u_uac1.h | 4 > drivers/usb/gadget/function/u_uac1_legacy.c| 2 -- > drivers/usb/gadget/function/u_uac1_legacy.h| 2 -- > drivers/usb/gadget/function/u_uac2.h | 4 > drivers/usb/gadget/function/u_uvc.h| 4 > drivers/usb/gadget/function/uvc.h | 5 - > drivers/usb/gadget/function/uvc_configfs.c | 4 > drivers/usb/gadget/function/uvc_configfs.h | 4 > drivers/usb/gadget/function/uvc_queue.c| 5 - > drivers/usb/gadget/function/uvc_v4l2.c | 5 - > drivers/usb/gadget/function/uvc_v4l2.h | 4 > drivers/usb/gadget/function/uvc_video.c| 5 - > drivers/usb/gadget/function/uvc_video.h| 4 > 55 files changed, 244 deletions(-) -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 23/24] USB: gadget: function: Remove redundant license text
On Mon, 6 Nov 2017 15:37:32 +0100, Greg Kroah-Hartman wrote: > Now that the SPDX tag is in all USB files, that identifies the license > in a specific and legally-defined manner. So the extra GPL text wording > can be removed as it is no longer needed at all. > > This is done on a quest to remove the 700+ different ways that files in > the kernel describe the GPL license text. And there's unneeded stuff > like the address (sometimes incorrect) for the FSF which is never > needed. > > No copyright headers or other non-license-description text was removed. > > Cc: Felipe Balbi > Cc: Laurent Pinchart > Cc: Oliver Neukum > Cc: Johan Hovold > Cc: Michal Nazarewicz > Cc: Vincent Pelletier Acked-by: Vincent Pelletier > Cc: Jerry Zhang > Cc: John Keeping > Cc: Krzysztof Opasiak > Cc: Abdulhadi Mohamed > Cc: Matthew Wilcox > Cc: Janusz Dziedzic > Signed-off-by: Greg Kroah-Hartman -- Vincent Pelletier -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 23/24] USB: gadget: function: Remove redundant license text
On Mon, Nov 06 2017, Greg Kroah-Hartman wrote: > Now that the SPDX tag is in all USB files, that identifies the license > in a specific and legally-defined manner. So the extra GPL text wording > can be removed as it is no longer needed at all. > > This is done on a quest to remove the 700+ different ways that files in > the kernel describe the GPL license text. And there's unneeded stuff > like the address (sometimes incorrect) for the FSF which is never > needed. > > No copyright headers or other non-license-description text was removed. > > Cc: Felipe Balbi > Cc: Laurent Pinchart > Cc: Oliver Neukum > Cc: Johan Hovold > Cc: Michal Nazarewicz Acked-by: Michal Nazarewicz > Cc: Vincent Pelletier > Cc: Jerry Zhang > Cc: John Keeping > Cc: Krzysztof Opasiak > Cc: Abdulhadi Mohamed > Cc: Matthew Wilcox > Cc: Janusz Dziedzic > Signed-off-by: Greg Kroah-Hartman > --- > drivers/usb/gadget/function/f_acm.c| 4 > drivers/usb/gadget/function/f_ecm.c| 5 - > drivers/usb/gadget/function/f_eem.c| 5 - > drivers/usb/gadget/function/f_fs.c | 5 - > drivers/usb/gadget/function/f_hid.c| 5 - > drivers/usb/gadget/function/f_loopback.c | 5 - > drivers/usb/gadget/function/f_midi.c | 2 -- > drivers/usb/gadget/function/f_ncm.c| 5 - > drivers/usb/gadget/function/f_obex.c | 5 - > drivers/usb/gadget/function/f_phonet.c | 4 > drivers/usb/gadget/function/f_printer.c| 5 - > drivers/usb/gadget/function/f_rndis.c | 5 - > drivers/usb/gadget/function/f_serial.c | 4 > drivers/usb/gadget/function/f_sourcesink.c | 5 - > drivers/usb/gadget/function/f_subset.c | 5 - > drivers/usb/gadget/function/f_tcm.c| 1 - > drivers/usb/gadget/function/f_uac1.c | 5 - > drivers/usb/gadget/function/f_uac1_legacy.c| 2 -- > drivers/usb/gadget/function/f_uac2.c | 5 - > drivers/usb/gadget/function/f_uvc.c| 5 - > drivers/usb/gadget/function/f_uvc.h| 5 - > drivers/usb/gadget/function/rndis.c| 4 > drivers/usb/gadget/function/rndis.h| 4 > drivers/usb/gadget/function/storage_common.c | 5 - > drivers/usb/gadget/function/u_audio.c | 10 -- > drivers/usb/gadget/function/u_audio.h | 11 --- > drivers/usb/gadget/function/u_ecm.h| 4 > drivers/usb/gadget/function/u_eem.h| 4 > drivers/usb/gadget/function/u_ether.c | 5 - > drivers/usb/gadget/function/u_ether.h | 5 - > drivers/usb/gadget/function/u_ether_configfs.h | 4 > drivers/usb/gadget/function/u_fs.h | 4 > drivers/usb/gadget/function/u_gether.h | 4 > drivers/usb/gadget/function/u_hid.h| 4 > drivers/usb/gadget/function/u_midi.h | 4 > drivers/usb/gadget/function/u_ncm.h| 4 > drivers/usb/gadget/function/u_phonet.h | 4 > drivers/usb/gadget/function/u_printer.h| 4 > drivers/usb/gadget/function/u_rndis.h | 4 > drivers/usb/gadget/function/u_serial.c | 4 > drivers/usb/gadget/function/u_serial.h | 4 > drivers/usb/gadget/function/u_tcm.h| 4 > drivers/usb/gadget/function/u_uac1.h | 4 > drivers/usb/gadget/function/u_uac1_legacy.c| 2 -- > drivers/usb/gadget/function/u_uac1_legacy.h| 2 -- > drivers/usb/gadget/function/u_uac2.h | 4 > drivers/usb/gadget/function/u_uvc.h| 4 > drivers/usb/gadget/function/uvc.h | 5 - > drivers/usb/gadget/function/uvc_configfs.c | 4 > drivers/usb/gadget/function/uvc_configfs.h | 4 > drivers/usb/gadget/function/uvc_queue.c| 5 - > drivers/usb/gadget/function/uvc_v4l2.c | 5 - > drivers/usb/gadget/function/uvc_v4l2.h | 4 > drivers/usb/gadget/function/uvc_video.c| 5 - > drivers/usb/gadget/function/uvc_video.h| 4 > 55 files changed, 244 deletions(-) > > diff --git a/drivers/usb/gadget/function/f_acm.c > b/drivers/usb/gadget/function/f_acm.c > index 5a2229784bd6..7140bf3c74fa 100644 > --- a/drivers/usb/gadget/function/f_acm.c > +++ b/drivers/usb/gadget/function/f_acm.c > @@ -7,10 +7,6 @@ > * Copyright (C) 2008 by Nokia Corporation > * Copyright (C) 2009 by Samsung Electronics > * Author: Michal Nazarewicz (min...@mina86.com) > - * > - * This software is distributed under the terms of the GNU General > - * Public License ("GPL") as published by the Free Software Foundation, > - * either version 2 of that License or (at your option) any later version. > */ > > /* #define VERBOSE_DEBUG */ > diff --git a/drivers/usb/gadget/function/f_ecm.c > b/drivers/usb/gadget/function/
Re: [PATCH 23/24] USB: gadget: function: Remove redundant license text
Greg Kroah-Hartman writes: > Now that the SPDX tag is in all USB files, that identifies the license > in a specific and legally-defined manner. So the extra GPL text wording > can be removed as it is no longer needed at all. > > This is done on a quest to remove the 700+ different ways that files in > the kernel describe the GPL license text. And there's unneeded stuff > like the address (sometimes incorrect) for the FSF which is never > needed. > > No copyright headers or other non-license-description text was removed. > > Cc: Felipe Balbi > Cc: Laurent Pinchart > Cc: Oliver Neukum > Cc: Johan Hovold > Cc: Michal Nazarewicz > Cc: Vincent Pelletier > Cc: Jerry Zhang > Cc: John Keeping > Cc: Krzysztof Opasiak > Cc: Abdulhadi Mohamed > Cc: Matthew Wilcox > Cc: Janusz Dziedzic > Signed-off-by: Greg Kroah-Hartman Acked-by: Felipe Balbi -- balbi signature.asc Description: PGP signature
[PATCH 23/24] USB: gadget: function: Remove redundant license text
Now that the SPDX tag is in all USB files, that identifies the license in a specific and legally-defined manner. So the extra GPL text wording can be removed as it is no longer needed at all. This is done on a quest to remove the 700+ different ways that files in the kernel describe the GPL license text. And there's unneeded stuff like the address (sometimes incorrect) for the FSF which is never needed. No copyright headers or other non-license-description text was removed. Cc: Felipe Balbi Cc: Laurent Pinchart Cc: Oliver Neukum Cc: Johan Hovold Cc: Michal Nazarewicz Cc: Vincent Pelletier Cc: Jerry Zhang Cc: John Keeping Cc: Krzysztof Opasiak Cc: Abdulhadi Mohamed Cc: Matthew Wilcox Cc: Janusz Dziedzic Signed-off-by: Greg Kroah-Hartman --- drivers/usb/gadget/function/f_acm.c| 4 drivers/usb/gadget/function/f_ecm.c| 5 - drivers/usb/gadget/function/f_eem.c| 5 - drivers/usb/gadget/function/f_fs.c | 5 - drivers/usb/gadget/function/f_hid.c| 5 - drivers/usb/gadget/function/f_loopback.c | 5 - drivers/usb/gadget/function/f_midi.c | 2 -- drivers/usb/gadget/function/f_ncm.c| 5 - drivers/usb/gadget/function/f_obex.c | 5 - drivers/usb/gadget/function/f_phonet.c | 4 drivers/usb/gadget/function/f_printer.c| 5 - drivers/usb/gadget/function/f_rndis.c | 5 - drivers/usb/gadget/function/f_serial.c | 4 drivers/usb/gadget/function/f_sourcesink.c | 5 - drivers/usb/gadget/function/f_subset.c | 5 - drivers/usb/gadget/function/f_tcm.c| 1 - drivers/usb/gadget/function/f_uac1.c | 5 - drivers/usb/gadget/function/f_uac1_legacy.c| 2 -- drivers/usb/gadget/function/f_uac2.c | 5 - drivers/usb/gadget/function/f_uvc.c| 5 - drivers/usb/gadget/function/f_uvc.h| 5 - drivers/usb/gadget/function/rndis.c| 4 drivers/usb/gadget/function/rndis.h| 4 drivers/usb/gadget/function/storage_common.c | 5 - drivers/usb/gadget/function/u_audio.c | 10 -- drivers/usb/gadget/function/u_audio.h | 11 --- drivers/usb/gadget/function/u_ecm.h| 4 drivers/usb/gadget/function/u_eem.h| 4 drivers/usb/gadget/function/u_ether.c | 5 - drivers/usb/gadget/function/u_ether.h | 5 - drivers/usb/gadget/function/u_ether_configfs.h | 4 drivers/usb/gadget/function/u_fs.h | 4 drivers/usb/gadget/function/u_gether.h | 4 drivers/usb/gadget/function/u_hid.h| 4 drivers/usb/gadget/function/u_midi.h | 4 drivers/usb/gadget/function/u_ncm.h| 4 drivers/usb/gadget/function/u_phonet.h | 4 drivers/usb/gadget/function/u_printer.h| 4 drivers/usb/gadget/function/u_rndis.h | 4 drivers/usb/gadget/function/u_serial.c | 4 drivers/usb/gadget/function/u_serial.h | 4 drivers/usb/gadget/function/u_tcm.h| 4 drivers/usb/gadget/function/u_uac1.h | 4 drivers/usb/gadget/function/u_uac1_legacy.c| 2 -- drivers/usb/gadget/function/u_uac1_legacy.h| 2 -- drivers/usb/gadget/function/u_uac2.h | 4 drivers/usb/gadget/function/u_uvc.h| 4 drivers/usb/gadget/function/uvc.h | 5 - drivers/usb/gadget/function/uvc_configfs.c | 4 drivers/usb/gadget/function/uvc_configfs.h | 4 drivers/usb/gadget/function/uvc_queue.c| 5 - drivers/usb/gadget/function/uvc_v4l2.c | 5 - drivers/usb/gadget/function/uvc_v4l2.h | 4 drivers/usb/gadget/function/uvc_video.c| 5 - drivers/usb/gadget/function/uvc_video.h| 4 55 files changed, 244 deletions(-) diff --git a/drivers/usb/gadget/function/f_acm.c b/drivers/usb/gadget/function/f_acm.c index 5a2229784bd6..7140bf3c74fa 100644 --- a/drivers/usb/gadget/function/f_acm.c +++ b/drivers/usb/gadget/function/f_acm.c @@ -7,10 +7,6 @@ * Copyright (C) 2008 by Nokia Corporation * Copyright (C) 2009 by Samsung Electronics * Author: Michal Nazarewicz (min...@mina86.com) - * - * This software is distributed under the terms of the GNU General - * Public License ("GPL") as published by the Free Software Foundation, - * either version 2 of that License or (at your option) any later version. */ /* #define VERBOSE_DEBUG */ diff --git a/drivers/usb/gadget/function/f_ecm.c b/drivers/usb/gadget/function/f_ecm.c index d2a83dd78cb9..b322ca20cd98 100644 --- a/drivers/usb/gadget/function/f_ecm.c +++ b/drivers/usb/gadget/function/f_ecm.c @@ -4,11 +4,6 @@ * * Copyright (C) 2003-2005,2008 David Brownell * Copyright (C) 2008 Nokia Corporation - * - * This program is free sof