Re: [PATCH 3/3] USB: serial: ark3116: use port device for info and error messages

2017-01-31 Thread Greg KH
On Tue, Jan 31, 2017 at 11:51:09AM +0100, Johan Hovold wrote:
> Use the port device rather than usb device in info and error messages.
> 
> This makes sure that driver and tty port is included in the messages,
> while also making them more uniform.
> 
> Signed-off-by: Johan Hovold 
> ---
>  drivers/usb/serial/ark3116.c | 16 ++--
>  1 file changed, 6 insertions(+), 10 deletions(-)
> 

Reviewed-by: Greg Kroah-Hartman 

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH 3/3] USB: serial: ark3116: use port device for info and error messages

2017-01-31 Thread Johan Hovold
Use the port device rather than usb device in info and error messages.

This makes sure that driver and tty port is included in the messages,
while also making them more uniform.

Signed-off-by: Johan Hovold 
---
 drivers/usb/serial/ark3116.c | 16 ++--
 1 file changed, 6 insertions(+), 10 deletions(-)

diff --git a/drivers/usb/serial/ark3116.c b/drivers/usb/serial/ark3116.c
index e3f6a4e2e2ad..2779e59c30f1 100644
--- a/drivers/usb/serial/ark3116.c
+++ b/drivers/usb/serial/ark3116.c
@@ -187,10 +187,8 @@ static int ark3116_port_probe(struct usb_serial_port *port)
if (priv->irda)
ark3116_write_reg(serial, 0x9, 0);
 
-   dev_info(&serial->dev->dev,
-   "%s using %s mode\n",
-   KBUILD_MODNAME,
-   priv->irda ? "IrDA" : "RS232");
+   dev_info(&port->dev, "using %s mode\n", priv->irda ? "IrDA" : "RS232");
+
return 0;
 }
 
@@ -326,9 +324,8 @@ static void ark3116_set_termios(struct tty_struct *tty,
 
/* check for software flow control */
if (I_IXOFF(tty) || I_IXON(tty)) {
-   dev_warn(&serial->dev->dev,
-"%s: don't know how to do software flow control\n",
-KBUILD_MODNAME);
+   dev_warn(&port->dev,
+   "software flow control not implemented\n");
}
 
/* Don't rewrite B0 */
@@ -616,9 +613,8 @@ static void ark3116_read_int_callback(struct urb *urb)
 
result = usb_submit_urb(urb, GFP_ATOMIC);
if (result)
-   dev_err(&urb->dev->dev,
-   "%s - Error %d submitting interrupt urb\n",
-   __func__, result);
+   dev_err(&port->dev, "failed to resubmit interrupt urb: %d\n",
+   result);
 }
 
 
-- 
2.10.2

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html