[PATCH 3/3] usb: gadget: s3c-hsudc: Replace 0 with NULL for pointers

2012-09-03 Thread Sachin Kamat 
Silences the following type of sparse warnings:
warning: Using plain integer as NULL pointer

Signed-off-by: Sachin Kamat 
---
 drivers/usb/gadget/s3c-hsudc.c |8 
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/usb/gadget/s3c-hsudc.c b/drivers/usb/gadget/s3c-hsudc.c
index 35cdc6a..d8e785d 100644
--- a/drivers/usb/gadget/s3c-hsudc.c
+++ b/drivers/usb/gadget/s3c-hsudc.c
@@ -835,7 +835,7 @@ static struct usb_request *s3c_hsudc_alloc_request(struct 
usb_ep *_ep,
 
hsreq = kzalloc(sizeof(*hsreq), gfp_flags);
if (!hsreq)
-   return 0;
+   return NULL;
 
INIT_LIST_HEAD(&hsreq->queue);
return &hsreq->req;
@@ -904,16 +904,16 @@ static int s3c_hsudc_queue(struct usb_ep *_ep, struct 
usb_request *_req,
csr = readl((u32)hsudc->regs + offset);
if (!(csr & S3C_ESR_TX_SUCCESS) &&
(s3c_hsudc_write_fifo(hsep, hsreq) == 1))
-   hsreq = 0;
+   hsreq = NULL;
} else {
csr = readl((u32)hsudc->regs + offset);
if ((csr & S3C_ESR_RX_SUCCESS)
   && (s3c_hsudc_read_fifo(hsep, hsreq) == 1))
-   hsreq = 0;
+   hsreq = NULL;
}
}
 
-   if (hsreq != 0)
+   if (hsreq)
list_add_tail(&hsreq->queue, &hsep->queue);
 
spin_unlock_irqrestore(&hsudc->lock, flags);
-- 
1.7.4.1

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/3] usb: gadget: s3c-hsudc: Replace 0 with NULL for pointers

2012-09-03 Thread ABRAHAM, KISHON VIJAY 
Hi,

On Mon, Sep 3, 2012 at 3:48 PM, Sachin Kamat  wrote:
> Silences the following type of sparse warnings:
> warning: Using plain integer as NULL pointer
>
> Signed-off-by: Sachin Kamat 
> ---
>  drivers/usb/gadget/s3c-hsudc.c |8 
>  1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/gadget/s3c-hsudc.c b/drivers/usb/gadget/s3c-hsudc.c
> index 35cdc6a..d8e785d 100644
> --- a/drivers/usb/gadget/s3c-hsudc.c
> +++ b/drivers/usb/gadget/s3c-hsudc.c
> @@ -835,7 +835,7 @@ static struct usb_request *s3c_hsudc_alloc_request(struct 
> usb_ep *_ep,
>
> hsreq = kzalloc(sizeof(*hsreq), gfp_flags);
> if (!hsreq)
> -   return 0;
> +   return NULL;

shouldn't this be -ENOMEM?

Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/3] usb: gadget: s3c-hsudc: Replace 0 with NULL for pointers

2012-09-03 Thread Sachin Kamat 
Hi

On 3 September 2012 16:37, ABRAHAM, KISHON VIJAY  wrote:
> Hi,
>
> On Mon, Sep 3, 2012 at 3:48 PM, Sachin Kamat  wrote:
>> Silences the following type of sparse warnings:
>> warning: Using plain integer as NULL pointer
>>
>> Signed-off-by: Sachin Kamat 
>> ---
>>  drivers/usb/gadget/s3c-hsudc.c |8 
>>  1 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/usb/gadget/s3c-hsudc.c b/drivers/usb/gadget/s3c-hsudc.c
>> index 35cdc6a..d8e785d 100644
>> --- a/drivers/usb/gadget/s3c-hsudc.c
>> +++ b/drivers/usb/gadget/s3c-hsudc.c
>> @@ -835,7 +835,7 @@ static struct usb_request 
>> *s3c_hsudc_alloc_request(struct usb_ep *_ep,
>>
>> hsreq = kzalloc(sizeof(*hsreq), gfp_flags);
>> if (!hsreq)
>> -   return 0;
>> +   return NULL;
>
> shouldn't this be -ENOMEM?

That should have been the obvious return value. However, I thought
probably it was made so with some reasoning and did not change it as I
am not familiar with this driver.

>
> Thanks
> Kishon



-- 
With warm regards,
Sachin
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/3] usb: gadget: s3c-hsudc: Replace 0 with NULL for pointers

2012-09-03 Thread Felipe Balbi 
On Mon, Sep 03, 2012 at 05:00:44PM +0530, Sachin Kamat wrote:
> Hi
> 
> On 3 September 2012 16:37, ABRAHAM, KISHON VIJAY  wrote:
> > Hi,
> >
> > On Mon, Sep 3, 2012 at 3:48 PM, Sachin Kamat  
> > wrote:
> >> Silences the following type of sparse warnings:
> >> warning: Using plain integer as NULL pointer
> >>
> >> Signed-off-by: Sachin Kamat 
> >> ---
> >>  drivers/usb/gadget/s3c-hsudc.c |8 
> >>  1 files changed, 4 insertions(+), 4 deletions(-)
> >>
> >> diff --git a/drivers/usb/gadget/s3c-hsudc.c 
> >> b/drivers/usb/gadget/s3c-hsudc.c
> >> index 35cdc6a..d8e785d 100644
> >> --- a/drivers/usb/gadget/s3c-hsudc.c
> >> +++ b/drivers/usb/gadget/s3c-hsudc.c
> >> @@ -835,7 +835,7 @@ static struct usb_request 
> >> *s3c_hsudc_alloc_request(struct usb_ep *_ep,
> >>
> >> hsreq = kzalloc(sizeof(*hsreq), gfp_flags);
> >> if (!hsreq)
> >> -   return 0;
> >> +   return NULL;
> >
> > shouldn't this be -ENOMEM?
> 
> That should have been the obvious return value. However, I thought
> probably it was made so with some reasoning and did not change it as I
> am not familiar with this driver.

it's just the way the API was designed. If we fail to allocate a
usb_request, we must return NULL so function/gadget drivers can check if
it was successful or not.

Of course it could be changed into ERR_PTR(-ENOMEM) or something, but
that's an API change... ;-)

-- 
balbi


signature.asc
Description: Digital signature