Re: [PATCH 4.10-rc3 12/13] net: ath5k: fix build errors when linux/phy*.h is removed from net/dsa.h
Russell King writes: > Fix these errors reported by the 0-day builder by replacing the > linux/export.h include with linux/module.h. > > In file included from include/linux/platform_device.h:14:0, > from drivers/net/wireless/ath/ath5k/ahb.c:20: > include/linux/device.h:1463:1: warning: data definition has no type or > storage class > module_init(__driver##_init); \ > ^ > include/linux/platform_device.h:228:2: note: in expansion of macro > 'module_driver' > module_driver(__platform_driver, platform_driver_register, \ > ^ > drivers/net/wireless/ath/ath5k/ahb.c:233:1: note: in expansion of macro > 'module_platform_driver' > module_platform_driver(ath_ahb_driver); > ^~ > include/linux/device.h:1463:1: error: type defaults to 'int' in declaration > of 'module_init' [-Werror=implicit-int] > module_init(__driver##_init); \ > ^ > include/linux/platform_device.h:228:2: note: in expansion of macro > 'module_driver' > module_driver(__platform_driver, platform_driver_register, \ > ^ > drivers/net/wireless/ath/ath5k/ahb.c:233:1: note: in expansion of macro > 'module_platform_driver' > module_platform_driver(ath_ahb_driver); > ^~ > drivers/net/wireless/ath/ath5k/ahb.c:233:1: warning: parameter names (without > types) in function declaration > In file included from include/linux/platform_device.h:14:0, > from drivers/net/wireless/ath/ath5k/ahb.c:20: > include/linux/device.h:1468:1: warning: data definition has no type or > storage class > module_exit(__driver##_exit); > ^ > include/linux/platform_device.h:228:2: note: in expansion of macro > 'module_driver' > module_driver(__platform_driver, platform_driver_register, \ > ^ > drivers/net/wireless/ath/ath5k/ahb.c:233:1: note: in expansion of macro > 'module_platform_driver' > module_platform_driver(ath_ahb_driver); > ^~ > include/linux/device.h:1468:1: error: type defaults to 'int' in declaration > of 'module_exit' [-Werror=implicit-int] > module_exit(__driver##_exit); > ^ > include/linux/platform_device.h:228:2: note: in expansion of macro > 'module_driver' > module_driver(__platform_driver, platform_driver_register, \ > ^ > drivers/net/wireless/ath/ath5k/ahb.c:233:1: note: in expansion of macro > 'module_platform_driver' > module_platform_driver(ath_ahb_driver); > ^~ > drivers/net/wireless/ath/ath5k/ahb.c:233:1: warning: parameter names (without > types) in function declaration > In file included from include/linux/platform_device.h:14:0, > from drivers/net/wireless/ath/ath5k/ahb.c:20: > drivers/net/wireless/ath/ath5k/ahb.c:233:24: warning: 'ath_ahb_driver_exit' > defined but not used [-Wunused-function] > module_platform_driver(ath_ahb_driver); > ^ > include/linux/device.h:1464:20: note: in definition of macro 'module_driver' > static void __exit __driver##_exit(void) \ > ^~~~ > drivers/net/wireless/ath/ath5k/ahb.c:233:1: note: in expansion of macro > 'module_platform_driver' > module_platform_driver(ath_ahb_driver); > ^~ > drivers/net/wireless/ath/ath5k/ahb.c:233:24: warning: 'ath_ahb_driver_init' > defined but not used [-Wunused-function] > module_platform_driver(ath_ahb_driver); > ^ > include/linux/device.h:1459:19: note: in definition of macro 'module_driver' > static int __init __driver##_init(void) \ >^~~~ > drivers/net/wireless/ath/ath5k/ahb.c:233:1: note: in expansion of macro > 'module_platform_driver' > module_platform_driver(ath_ahb_driver); > ^~ > > Signed-off-by: Russell King Looks good to me: Acked-by: Kalle Valo I assume Dave will take this so I'll drop the patch from my queue. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 4.10-rc3 12/13] net: ath5k: fix build errors when linux/phy*.h is removed from net/dsa.h
Fix these errors reported by the 0-day builder by replacing the linux/export.h include with linux/module.h. In file included from include/linux/platform_device.h:14:0, from drivers/net/wireless/ath/ath5k/ahb.c:20: include/linux/device.h:1463:1: warning: data definition has no type or storage class module_init(__driver##_init); \ ^ include/linux/platform_device.h:228:2: note: in expansion of macro 'module_driver' module_driver(__platform_driver, platform_driver_register, \ ^ drivers/net/wireless/ath/ath5k/ahb.c:233:1: note: in expansion of macro 'module_platform_driver' module_platform_driver(ath_ahb_driver); ^~ include/linux/device.h:1463:1: error: type defaults to 'int' in declaration of 'module_init' [-Werror=implicit-int] module_init(__driver##_init); \ ^ include/linux/platform_device.h:228:2: note: in expansion of macro 'module_driver' module_driver(__platform_driver, platform_driver_register, \ ^ drivers/net/wireless/ath/ath5k/ahb.c:233:1: note: in expansion of macro 'module_platform_driver' module_platform_driver(ath_ahb_driver); ^~ drivers/net/wireless/ath/ath5k/ahb.c:233:1: warning: parameter names (without types) in function declaration In file included from include/linux/platform_device.h:14:0, from drivers/net/wireless/ath/ath5k/ahb.c:20: include/linux/device.h:1468:1: warning: data definition has no type or storage class module_exit(__driver##_exit); ^ include/linux/platform_device.h:228:2: note: in expansion of macro 'module_driver' module_driver(__platform_driver, platform_driver_register, \ ^ drivers/net/wireless/ath/ath5k/ahb.c:233:1: note: in expansion of macro 'module_platform_driver' module_platform_driver(ath_ahb_driver); ^~ include/linux/device.h:1468:1: error: type defaults to 'int' in declaration of 'module_exit' [-Werror=implicit-int] module_exit(__driver##_exit); ^ include/linux/platform_device.h:228:2: note: in expansion of macro 'module_driver' module_driver(__platform_driver, platform_driver_register, \ ^ drivers/net/wireless/ath/ath5k/ahb.c:233:1: note: in expansion of macro 'module_platform_driver' module_platform_driver(ath_ahb_driver); ^~ drivers/net/wireless/ath/ath5k/ahb.c:233:1: warning: parameter names (without types) in function declaration In file included from include/linux/platform_device.h:14:0, from drivers/net/wireless/ath/ath5k/ahb.c:20: drivers/net/wireless/ath/ath5k/ahb.c:233:24: warning: 'ath_ahb_driver_exit' defined but not used [-Wunused-function] module_platform_driver(ath_ahb_driver); ^ include/linux/device.h:1464:20: note: in definition of macro 'module_driver' static void __exit __driver##_exit(void) \ ^~~~ drivers/net/wireless/ath/ath5k/ahb.c:233:1: note: in expansion of macro 'module_platform_driver' module_platform_driver(ath_ahb_driver); ^~ drivers/net/wireless/ath/ath5k/ahb.c:233:24: warning: 'ath_ahb_driver_init' defined but not used [-Wunused-function] module_platform_driver(ath_ahb_driver); ^ include/linux/device.h:1459:19: note: in definition of macro 'module_driver' static int __init __driver##_init(void) \ ^~~~ drivers/net/wireless/ath/ath5k/ahb.c:233:1: note: in expansion of macro 'module_platform_driver' module_platform_driver(ath_ahb_driver); ^~ Signed-off-by: Russell King --- drivers/net/wireless/ath/ath5k/ahb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath5k/ahb.c b/drivers/net/wireless/ath/ath5k/ahb.c index 2ca88b593e4c..c0794f5988b3 100644 --- a/drivers/net/wireless/ath/ath5k/ahb.c +++ b/drivers/net/wireless/ath/ath5k/ahb.c @@ -16,10 +16,10 @@ * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. */ +#include #include #include #include -#include #include #include "ath5k.h" #include "debug.h" -- 2.7.4 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
