Re: [PATCH 6/7] usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag
On Thu, Dec 05, 2013 at 03:20:54PM +0800, Peter Chen wrote: From: Chris Ruehl chris.ru...@gtsys.com.hk * init the sts flag to 0 (missed) * fix write the real bit not sts value * Set PORTCS_STS and DEVLC_STS only if sts = 1 Signed-off-by: Chris Ruehl chris.ru...@gtsys.com.hk Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/chipidea/core.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) If this is so important, why isn't it for 3.12-stable as well? is this really a regression? Or just something nice to fix up? thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 6/7] usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag
On Thu, Dec 05, 2013 at 03:20:54PM +0800, Peter Chen wrote: From: Chris Ruehl chris.ru...@gtsys.com.hk * init the sts flag to 0 (missed) * fix write the real bit not sts value * Set PORTCS_STS and DEVLC_STS only if sts = 1 Signed-off-by: Chris Ruehl chris.ru...@gtsys.com.hk Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/chipidea/core.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) If this is so important, why isn't it for 3.12-stable as well? is this really a regression? Or just something nice to fix up? It is nice to fix up. Thanks, Peter -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 6/7] usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag
On Mon, Dec 09, 2013 at 08:40:42AM +, peter.c...@freescale.com wrote: On Thu, Dec 05, 2013 at 03:20:54PM +0800, Peter Chen wrote: From: Chris Ruehl chris.ru...@gtsys.com.hk * init the sts flag to 0 (missed) * fix write the real bit not sts value * Set PORTCS_STS and DEVLC_STS only if sts = 1 Signed-off-by: Chris Ruehl chris.ru...@gtsys.com.hk Signed-off-by: Peter Chen peter.c...@freescale.com --- drivers/usb/chipidea/core.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) If this is so important, why isn't it for 3.12-stable as well? is this really a regression? Or just something nice to fix up? It is nice to fix up. Then it can't go into 3.13-final this late in the development cycle, sorry. This is regression fixes only at this point in time. greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 6/7] usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag
From: Chris Ruehl chris.ru...@gtsys.com.hk
* init the sts flag to 0 (missed)
* fix write the real bit not sts value
* Set PORTCS_STS and DEVLC_STS only if sts = 1
Signed-off-by: Chris Ruehl chris.ru...@gtsys.com.hk
Signed-off-by: Peter Chen peter.c...@freescale.com
---
drivers/usb/chipidea/core.c |8 +---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
index 5efdc9b..1677fed 100644
--- a/drivers/usb/chipidea/core.c
+++ b/drivers/usb/chipidea/core.c
@@ -242,7 +242,7 @@ static int hw_device_init(struct ci_hdrc *ci, void __iomem
*base)
static void hw_phymode_configure(struct ci_hdrc *ci)
{
- u32 portsc, lpm, sts;
+ u32 portsc, lpm, sts = 0;
switch (ci-platdata-phy_mode) {
case USBPHY_INTERFACE_MODE_UTMI:
@@ -272,10 +272,12 @@ static void hw_phymode_configure(struct ci_hdrc *ci)
if (ci-hw_bank.lpm) {
hw_write(ci, OP_DEVLC, DEVLC_PTS(7) | DEVLC_PTW, lpm);
- hw_write(ci, OP_DEVLC, DEVLC_STS, sts);
+ if (sts)
+ hw_write(ci, OP_DEVLC, DEVLC_STS, DEVLC_STS);
} else {
hw_write(ci, OP_PORTSC, PORTSC_PTS(7) | PORTSC_PTW, portsc);
- hw_write(ci, OP_PORTSC, PORTSC_STS, sts);
+ if (sts)
+ hw_write(ci, OP_PORTSC, PORTSC_STS, PORTSC_STS);
}
}
--
1.7.8
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
