Re: [PATCH usb 1/2] usb: musb: Add missing ATOMIC_INIT_NOTIFIER_HEAD
Hi, On Thu, Sep 26, 2013 at 02:00:59AM +0200, Pavel Machek wrote: On Wed, Sep 25, 2013 at 10:17:38AM +0200, Pali Rohár wrote: On Wednesday 18 September 2013 19:03:33 Pali Rohár wrote: twl-phy.notifier is not initalized Signed-off-by: Pali Rohár pali.ro...@gmail.com diff --git a/drivers/usb/phy/phy-twl4030-usb.c b/drivers/usb/phy/phy-twl4030-usb.c index 8f78d2d..efe6155 100644 --- a/drivers/usb/phy/phy-twl4030-usb.c +++ b/drivers/usb/phy/phy-twl4030-usb.c @@ -705,6 +705,8 @@ static int twl4030_usb_probe(struct platform_device *pdev) if (device_create_file(pdev-dev, dev_attr_vbus)) dev_warn(pdev-dev, could not create sysfs file\n); + ATOMIC_INIT_NOTIFIER_HEAD(twl-phy.notifier); + /* Our job is to use irqs and status from the power module * to keep the transceiver disabled when nothing's connected. * I sent above patch week ago. Did you already included it? look at my testing branch. Felipe prefers you to go MAINTAINERS file for git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git entry. After few clicks, you'll find out your two patches in https://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/log/?h=testing . So yes, it seems that after 10+ flames Felipe was _not_ lazy to send, Thanks for a patch mail was too much work. Apparently, we'll need Documentation/HowToBeGoodMaintainer file... I only send my automated emails after properly testing them. They sit in 'testing' for as long as necessary. After all the test is done, they'll be moved to 'next' at which point you get your email notification and they reach linux-next for the next day. -- balbi signature.asc Description: Digital signature
Re: [PATCH usb 1/2] usb: musb: Add missing ATOMIC_INIT_NOTIFIER_HEAD
On Wednesday 18 September 2013 19:03:33 Pali Rohár wrote: twl-phy.notifier is not initalized Signed-off-by: Pali Rohár pali.ro...@gmail.com diff --git a/drivers/usb/phy/phy-twl4030-usb.c b/drivers/usb/phy/phy-twl4030-usb.c index 8f78d2d..efe6155 100644 --- a/drivers/usb/phy/phy-twl4030-usb.c +++ b/drivers/usb/phy/phy-twl4030-usb.c @@ -705,6 +705,8 @@ static int twl4030_usb_probe(struct platform_device *pdev) if (device_create_file(pdev-dev, dev_attr_vbus)) dev_warn(pdev-dev, could not create sysfs file\n); + ATOMIC_INIT_NOTIFIER_HEAD(twl-phy.notifier); + /* Our job is to use irqs and status from the power module * to keep the transceiver disabled when nothing's connected. * I sent above patch week ago. Did you already included it? -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.
Re: [PATCH usb 1/2] usb: musb: Add missing ATOMIC_INIT_NOTIFIER_HEAD
Hi, On Wed, Sep 25, 2013 at 10:17:38AM +0200, Pali Rohár wrote: On Wednesday 18 September 2013 19:03:33 Pali Rohár wrote: twl-phy.notifier is not initalized Signed-off-by: Pali Rohár pali.ro...@gmail.com diff --git a/drivers/usb/phy/phy-twl4030-usb.c b/drivers/usb/phy/phy-twl4030-usb.c index 8f78d2d..efe6155 100644 --- a/drivers/usb/phy/phy-twl4030-usb.c +++ b/drivers/usb/phy/phy-twl4030-usb.c @@ -705,6 +705,8 @@ static int twl4030_usb_probe(struct platform_device *pdev) if (device_create_file(pdev-dev, dev_attr_vbus)) dev_warn(pdev-dev, could not create sysfs file\n); + ATOMIC_INIT_NOTIFIER_HEAD(twl-phy.notifier); + /* Our job is to use irqs and status from the power module * to keep the transceiver disabled when nothing's connected. * I sent above patch week ago. Did you already included it? look at my testing branch. -- balbi signature.asc Description: Digital signature
Re: [PATCH usb 1/2] usb: musb: Add missing ATOMIC_INIT_NOTIFIER_HEAD
On Wed 2013-09-25 15:33:33, Felipe Balbi wrote: Hi, On Wed, Sep 25, 2013 at 10:17:38AM +0200, Pali Rohár wrote: On Wednesday 18 September 2013 19:03:33 Pali Rohár wrote: twl-phy.notifier is not initalized Signed-off-by: Pali Rohár pali.ro...@gmail.com diff --git a/drivers/usb/phy/phy-twl4030-usb.c b/drivers/usb/phy/phy-twl4030-usb.c index 8f78d2d..efe6155 100644 --- a/drivers/usb/phy/phy-twl4030-usb.c +++ b/drivers/usb/phy/phy-twl4030-usb.c @@ -705,6 +705,8 @@ static int twl4030_usb_probe(struct platform_device *pdev) if (device_create_file(pdev-dev, dev_attr_vbus)) dev_warn(pdev-dev, could not create sysfs file\n); + ATOMIC_INIT_NOTIFIER_HEAD(twl-phy.notifier); + /* Our job is to use irqs and status from the power module * to keep the transceiver disabled when nothing's connected. * I sent above patch week ago. Did you already included it? look at my testing branch. Felipe prefers you to go MAINTAINERS file for git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git entry. After few clicks, you'll find out your two patches in https://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/log/?h=testing . So yes, it seems that after 10+ flames Felipe was _not_ lazy to send, Thanks for a patch mail was too much work. Apparently, we'll need Documentation/HowToBeGoodMaintainer file... Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH usb 1/2] usb: musb: Add missing ATOMIC_INIT_NOTIFIER_HEAD
twl-phy.notifier is not initalized Signed-off-by: Pali Rohár pali.ro...@gmail.com diff --git a/drivers/usb/phy/phy-twl4030-usb.c b/drivers/usb/phy/phy-twl4030-usb.c index 8f78d2d..efe6155 100644 --- a/drivers/usb/phy/phy-twl4030-usb.c +++ b/drivers/usb/phy/phy-twl4030-usb.c @@ -705,6 +705,8 @@ static int twl4030_usb_probe(struct platform_device *pdev) if (device_create_file(pdev-dev, dev_attr_vbus)) dev_warn(pdev-dev, could not create sysfs file\n); + ATOMIC_INIT_NOTIFIER_HEAD(twl-phy.notifier); + /* Our job is to use irqs and status from the power module * to keep the transceiver disabled when nothing's connected. * signature.asc Description: This is a digitally signed message part.