[PATCH usb v2 26/29] renesas_usbhs: common: remove duplicate check on resource

2014-10-30 Thread varkabhadram 
From: Varka Bhadram varkabhad...@gmail.com

Sanity check on resource happening with devm_ioremap_resource().

Signed-off-by: Varka Bhadram var...@cdac.in
---
 drivers/usb/renesas_usbhs/common.c |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/renesas_usbhs/common.c 
b/drivers/usb/renesas_usbhs/common.c
index b3b6813..3ffd552 100644
--- a/drivers/usb/renesas_usbhs/common.c
+++ b/drivers/usb/renesas_usbhs/common.c
@@ -497,8 +497,9 @@ static int usbhs_probe(struct platform_device *pdev)
 
/* platform data */
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+
irq_res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
-   if (!res || !irq_res) {
+   if (!irq_res) {
dev_err(pdev-dev, Not enough Renesas USB platform 
resources.\n);
return -ENODEV;
}
-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH usb v2 26/29] renesas_usbhs: common: remove duplicate check on resource

2014-10-30 Thread Sergei Shtylyov 

On 10/30/2014 06:53 PM, varkabhad...@gmail.com wrote:


From: Varka Bhadram varkabhad...@gmail.com



Sanity check on resource happening with devm_ioremap_resource().



Signed-off-by: Varka Bhadram var...@cdac.in
---
  drivers/usb/renesas_usbhs/common.c |3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)



diff --git a/drivers/usb/renesas_usbhs/common.c 
b/drivers/usb/renesas_usbhs/common.c
index b3b6813..3ffd552 100644
--- a/drivers/usb/renesas_usbhs/common.c
+++ b/drivers/usb/renesas_usbhs/common.c
@@ -497,8 +497,9 @@ static int usbhs_probe(struct platform_device *pdev)

/* platform data */
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+
irq_res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
-   if (!res || !irq_res) {
+   if (!irq_res) {
dev_err(pdev-dev, Not enough Renesas USB platform 
resources.\n);
return -ENODEV;
}


   You promised to change this patch but haven't. Why?

WBR, Sergei

--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH usb v2 26/29] renesas_usbhs: common: remove duplicate check on resource

2014-10-30 Thread Varka Bhadram 

On 10/30/2014 10:46 PM, Sergei Shtylyov wrote:

On 10/30/2014 06:53 PM, varkabhad...@gmail.com wrote:


From: Varka Bhadram varkabhad...@gmail.com



Sanity check on resource happening with devm_ioremap_resource().



Signed-off-by: Varka Bhadram var...@cdac.in
---
  drivers/usb/renesas_usbhs/common.c |3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)


diff --git a/drivers/usb/renesas_usbhs/common.c 
b/drivers/usb/renesas_usbhs/common.c

index b3b6813..3ffd552 100644
--- a/drivers/usb/renesas_usbhs/common.c
+++ b/drivers/usb/renesas_usbhs/common.c
@@ -497,8 +497,9 @@ static int usbhs_probe(struct platform_device *pdev)

  /* platform data */
  res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+
  irq_res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
-if (!res || !irq_res) {
+if (!irq_res) {
  dev_err(pdev-dev, Not enough Renesas USB platform 
resources.\n);

  return -ENODEV;
  }


   You promised to change this patch but haven't. Why?

WBR, Sergei


I addressed your comments in v3. Please review it.

--
Thanks and Regards,
Varka Bhadram.

--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html