RE: [PATCH v2] USB: Gadget: fsl driver pullup fix
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Thursday, March 20, 2014 9:33 PM > To: Gupta Suresh-B42813 > Cc: ba...@ti.com; linux-usb@vger.kernel.org; linux-ker...@vger.kernel.org > Subject: Re: [PATCH v2] USB: Gadget: fsl driver pullup fix > > On Fri, Mar 21, 2014 at 01:57:18AM +0530, Suresh Gupta wrote: > > This fix the fsl usb gadget driver in a way that the usb device will > > be only "pulled up" on requests only when vbus is powered > > > > Signed-off-by: Suresh Gupta > > --- > > Changes from previous version: > > * Removed re-factored code, Will send another patch for re-factoring > > duplicated code > > * Changed Description > > > > drivers/usb/gadget/fsl_udc_core.c | 4 > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/usb/gadget/fsl_udc_core.c > > b/drivers/usb/gadget/fsl_udc_core.c > > index 35cb972..49d66779 100644 > > --- a/drivers/usb/gadget/fsl_udc_core.c > > +++ b/drivers/usb/gadget/fsl_udc_core.c > > @@ -1219,6 +1219,10 @@ static int fsl_pullup(struct usb_gadget *gadget, > int is_on) > > struct fsl_udc *udc; > > > > udc = container_of(gadget, struct fsl_udc, gadget); > > + > > + if(!udc->vbus_active) > > + return -EOPNOTSUPP; > > Always run your patches through scripts/checkpatch.pl so they don't get > rejected for silly things like the wrong coding style... > Accepted, Sorry for such a inane mistake -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2] USB: Gadget: fsl driver pullup fix
On Fri, Mar 21, 2014 at 01:57:18AM +0530, Suresh Gupta wrote: > This fix the fsl usb gadget driver in a way that the usb device > will be only "pulled up" on requests only when vbus is powered > > Signed-off-by: Suresh Gupta > --- > Changes from previous version: > * Removed re-factored code, Will send another patch for re-factoring > duplicated code > * Changed Description > > drivers/usb/gadget/fsl_udc_core.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/drivers/usb/gadget/fsl_udc_core.c > b/drivers/usb/gadget/fsl_udc_core.c > index 35cb972..49d66779 100644 > --- a/drivers/usb/gadget/fsl_udc_core.c > +++ b/drivers/usb/gadget/fsl_udc_core.c > @@ -1219,6 +1219,10 @@ static int fsl_pullup(struct usb_gadget *gadget, int > is_on) > struct fsl_udc *udc; > > udc = container_of(gadget, struct fsl_udc, gadget); > + > + if(!udc->vbus_active) > + return -EOPNOTSUPP; Always run your patches through scripts/checkpatch.pl so they don't get rejected for silly things like the wrong coding style... -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v2] USB: Gadget: fsl driver pullup fix
This fix the fsl usb gadget driver in a way that the usb device will be only "pulled up" on requests only when vbus is powered Signed-off-by: Suresh Gupta --- Changes from previous version: * Removed re-factored code, Will send another patch for re-factoring duplicated code * Changed Description drivers/usb/gadget/fsl_udc_core.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/usb/gadget/fsl_udc_core.c b/drivers/usb/gadget/fsl_udc_core.c index 35cb972..49d66779 100644 --- a/drivers/usb/gadget/fsl_udc_core.c +++ b/drivers/usb/gadget/fsl_udc_core.c @@ -1219,6 +1219,10 @@ static int fsl_pullup(struct usb_gadget *gadget, int is_on) struct fsl_udc *udc; udc = container_of(gadget, struct fsl_udc, gadget); + + if(!udc->vbus_active) + return -EOPNOTSUPP; + udc->softconnect = (is_on != 0); if (can_pullup(udc)) fsl_writel((fsl_readl(&dr_regs->usbcmd) | USB_CMD_RUN_STOP), -- 1.8.4.1 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
