Re: [PATCH v2 0/6] usb: host: Cleanup for ioremap'ing hcd memory

2014-05-12 Thread Alan Stern
On Sat, 10 May 2014, Vivek Gautam wrote:

 Based on 'usb-next' branch of Greg's usb tree.
 
 devm_ioremap_resource() API is advantageous over devm_ioremap()
 and should therefore be preferred to request any ioremap'ed address
 for hcd.
 
 Changes from v1:
  - Changed the way returned pointer is checked for error value
as pointed out in the review comment in the mailing list.
 
 Vivek Gautam (6):
   usb: host: ehci-exynos: Use devm_ioremap_resource instead of
 devm_ioremap
   usb: host: ehci-msm: Use devm_ioremap_resource instead of
 devm_ioremap
   usb: host: ehci-mv: Use devm_ioremap_resource instead of devm_ioremap
   usb: host: ehci-spear: Use devm_ioremap_resource instead of
 devm_ioremap
   usb: host: ehci-tegra: Use devm_ioremap_resource instead of
 devm_ioremap
   usb: host: ohci-exynos: Use devm_ioremap_resource instead of
 devm_ioremap
 
  drivers/usb/host/ehci-exynos.c |7 +++
  drivers/usb/host/ehci-msm.c|7 +++
  drivers/usb/host/ehci-mv.c |   16 ++--
  drivers/usb/host/ehci-spear.c  |   13 +++--
  drivers/usb/host/ehci-tegra.c  |7 +++
  drivers/usb/host/ohci-exynos.c |7 +++
  6 files changed, 21 insertions(+), 36 deletions(-)

For all six patches,

Acked-by: Alan Stern st...@rowland.harvard.edu

--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH v2 0/6] usb: host: Cleanup for ioremap'ing hcd memory

2014-05-11 Thread Vivek Gautam
Hi,


On Sat, May 10, 2014 at 7:55 PM, Alexander Shiyan shc_w...@mail.ru wrote:
 Sat, 10 May 2014 17:30:04 +0530 от Vivek Gautam gautam.vi...@samsung.com:
 Based on 'usb-next' branch of Greg's usb tree.

 devm_ioremap_resource() API is advantageous over devm_ioremap()
 and should therefore be preferred to request any ioremap'ed address
 for hcd.

 Changes from v1:
  - Changed the way returned pointer is checked for error value
as pointed out in the review comment in the mailing list.

 hcd-rsrc_len field can be removed entirely, since I cannot find any reason
 how this filed can be used in the drivers now.
 This is of course should be in an another series. This one looks good.

True, even i noticed the same, since after grep'ing for rsrc_len. i
could not find any mention in the
USB layer.
Will send that as a separate patch-series.



-- 
Best Regards
Vivek Gautam
Samsung RD Institute, Bangalore
India
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH v2 0/6] usb: host: Cleanup for ioremap'ing hcd memory

2014-05-10 Thread Vivek Gautam
Based on 'usb-next' branch of Greg's usb tree.

devm_ioremap_resource() API is advantageous over devm_ioremap()
and should therefore be preferred to request any ioremap'ed address
for hcd.

Changes from v1:
 - Changed the way returned pointer is checked for error value
   as pointed out in the review comment in the mailing list.

Vivek Gautam (6):
  usb: host: ehci-exynos: Use devm_ioremap_resource instead of
devm_ioremap
  usb: host: ehci-msm: Use devm_ioremap_resource instead of
devm_ioremap
  usb: host: ehci-mv: Use devm_ioremap_resource instead of devm_ioremap
  usb: host: ehci-spear: Use devm_ioremap_resource instead of
devm_ioremap
  usb: host: ehci-tegra: Use devm_ioremap_resource instead of
devm_ioremap
  usb: host: ohci-exynos: Use devm_ioremap_resource instead of
devm_ioremap

 drivers/usb/host/ehci-exynos.c |7 +++
 drivers/usb/host/ehci-msm.c|7 +++
 drivers/usb/host/ehci-mv.c |   16 ++--
 drivers/usb/host/ehci-spear.c  |   13 +++--
 drivers/usb/host/ehci-tegra.c  |7 +++
 drivers/usb/host/ohci-exynos.c |7 +++
 6 files changed, 21 insertions(+), 36 deletions(-)

-- 
1.7.10.4

--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH v2 0/6] usb: host: Cleanup for ioremap'ing hcd memory

2014-05-10 Thread Alexander Shiyan
Sat, 10 May 2014 17:30:04 +0530 от Vivek Gautam gautam.vi...@samsung.com:
 Based on 'usb-next' branch of Greg's usb tree.
 
 devm_ioremap_resource() API is advantageous over devm_ioremap()
 and should therefore be preferred to request any ioremap'ed address
 for hcd.
 
 Changes from v1:
  - Changed the way returned pointer is checked for error value
as pointed out in the review comment in the mailing list.

hcd-rsrc_len field can be removed entirely, since I cannot find any reason
how this filed can be used in the drivers now.
This is of course should be in an another series. This one looks good.

---