Re: [PATCH v2 1/2] cdc_acm: Ignore Infineon Flash Loader utility

2015-11-20 Thread Jonas Jonsson 
On Thu, Nov 19, 2015 at 11:46:20AM +0100, Johan Hovold wrote:
> On Mon, Nov 16, 2015 at 01:34:14PM +0100, Jonas Jonsson wrote:
> > Some modems, such as the Telit UE910, are using an Infineon Flash Loader
> > utility. It has two interfaces, 2/2/0 (Abstract Modem) and 10/0/0 (CDC
> > Data). The latter can be used as a serial interface to upgrade the
> > firmware of the modem. However, that isn't possible when the cdc-acm
> > driver takes control of the device.
> 
> Could you expand the commit message with some more information from the
> thread were Daniele explained how the flash loader works here?
> Specifically, that the device looks like a CDC-ACM device but really is
> not until after the flash loader has timed out.
Sure, I'll include parts of the mail from Daniele since it was a very good
explanation.

/Jonas
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 1/2] cdc_acm: Ignore Infineon Flash Loader utility

2015-11-20 Thread Johan Hovold 
On Fri, Nov 20, 2015 at 02:40:55PM +0100, Jonas Jonsson wrote:
> On Thu, Nov 19, 2015 at 11:46:20AM +0100, Johan Hovold wrote:
> > On Mon, Nov 16, 2015 at 01:34:14PM +0100, Jonas Jonsson wrote:
> > > Some modems, such as the Telit UE910, are using an Infineon Flash Loader
> > > utility. It has two interfaces, 2/2/0 (Abstract Modem) and 10/0/0 (CDC
> > > Data). The latter can be used as a serial interface to upgrade the
> > > firmware of the modem. However, that isn't possible when the cdc-acm
> > > driver takes control of the device.
> > 
> > Could you expand the commit message with some more information from the
> > thread were Daniele explained how the flash loader works here?
> > Specifically, that the device looks like a CDC-ACM device but really is
> > not until after the flash loader has timed out.
> Sure, I'll include parts of the mail from Daniele since it was a very good
> explanation.

Just remember to give credits in case you end up quoting someone.

Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 1/2] cdc_acm: Ignore Infineon Flash Loader utility

2015-11-19 Thread Johan Hovold 
On Mon, Nov 16, 2015 at 01:34:14PM +0100, Jonas Jonsson wrote:
> Some modems, such as the Telit UE910, are using an Infineon Flash Loader
> utility. It has two interfaces, 2/2/0 (Abstract Modem) and 10/0/0 (CDC
> Data). The latter can be used as a serial interface to upgrade the
> firmware of the modem. However, that isn't possible when the cdc-acm
> driver takes control of the device.

Could you expand the commit message with some more information from the
thread were Daniele explained how the flash loader works here?
Specifically, that the device looks like a CDC-ACM device but really is
not until after the flash loader has timed out.

Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2 1/2] cdc_acm: Ignore Infineon Flash Loader utility

2015-11-16 Thread Jonas Jonsson 
Some modems, such as the Telit UE910, are using an Infineon Flash Loader
utility. It has two interfaces, 2/2/0 (Abstract Modem) and 10/0/0 (CDC
Data). The latter can be used as a serial interface to upgrade the
firmware of the modem. However, that isn't possible when the cdc-acm
driver takes control of the device.

Signed-off-by: Jonas Jonsson 
Tested-by: Daniele Palmas 
---
 drivers/usb/class/cdc-acm.c | 5 +
 1 file changed, 5 insertions(+)

diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
index b30e742..26ca4f9 100644
--- a/drivers/usb/class/cdc-acm.c
+++ b/drivers/usb/class/cdc-acm.c
@@ -1838,6 +1838,11 @@ static const struct usb_device_id acm_ids[] = {
},
 #endif
 
+   /* Exclude Infineon Flash Loader utility */
+   { USB_DEVICE(0x058b, 0x0041),
+   .driver_info = IGNORE_DEVICE,
+   },
+
/* control interfaces without any protocol set */
{ USB_INTERFACE_INFO(USB_CLASS_COMM, USB_CDC_SUBCLASS_ACM,
USB_CDC_PROTO_NONE) },
-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html