Re: [PATCH v2 2/2] USB: serial: Another Infineon flash loader USB ID

[Jonas Jonsson]

On Thu, Nov 19, 2015 at 11:54:06AM +0100, Johan Hovold wrote:
> On Mon, Nov 16, 2015 at 01:34:15PM +0100, Jonas Jonsson wrote:
> > This has been seen on a Telit UE910 modem.
> 
> Please expand this message as well and mention why this is not a CDC
> device so we do not forget.
Sure.


> > +   { USB_DEVICE_INTERFACE_CLASS(0x058b, 0x0041, 0x0a) }
> 
> Please use USB_CLASS_CDC_DATA here.
Indeed. Thanks

/Jonas
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 2/2] USB: serial: Another Infineon flash loader USB ID

[Johan Hovold]

On Mon, Nov 16, 2015 at 01:34:15PM +0100, Jonas Jonsson wrote:
> This has been seen on a Telit UE910 modem.

Please expand this message as well and mention why this is not a CDC
device so we do not forget.

> Signed-off-by: Jonas Jonsson 
> Tested-by: Daniele Palmas 
> ---
>  drivers/usb/serial/usb-serial-simple.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/serial/usb-serial-simple.c 
> b/drivers/usb/serial/usb-serial-simple.c
> index 3658662..93ab784 100644
> --- a/drivers/usb/serial/usb-serial-simple.c
> +++ b/drivers/usb/serial/usb-serial-simple.c
> @@ -53,7 +53,9 @@ DEVICE(funsoft, FUNSOFT_IDS);
>  
>  /* Infineon Flashloader driver */
>  #define FLASHLOADER_IDS()\
> - { USB_DEVICE(0x8087, 0x0716) }
> + { USB_DEVICE(0x8087, 0x0716) }, \
> + { USB_DEVICE_INTERFACE_CLASS(0x058b, 0x0041, 0x0a) }

Please use USB_CLASS_CDC_DATA here.

Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2 2/2] USB: serial: Another Infineon flash loader USB ID

[Jonas Jonsson]

This has been seen on a Telit UE910 modem.

Signed-off-by: Jonas Jonsson 
Tested-by: Daniele Palmas 
---
 drivers/usb/serial/usb-serial-simple.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/serial/usb-serial-simple.c 
b/drivers/usb/serial/usb-serial-simple.c
index 3658662..93ab784 100644
--- a/drivers/usb/serial/usb-serial-simple.c
+++ b/drivers/usb/serial/usb-serial-simple.c
@@ -53,7 +53,9 @@ DEVICE(funsoft, FUNSOFT_IDS);
 
 /* Infineon Flashloader driver */
 #define FLASHLOADER_IDS()  \
-   { USB_DEVICE(0x8087, 0x0716) }
+   { USB_DEVICE(0x8087, 0x0716) }, \
+   { USB_DEVICE_INTERFACE_CLASS(0x058b, 0x0041, 0x0a) }
+
 DEVICE(flashloader, FLASHLOADER_IDS);
 
 /* Google Serial USB SubClass */
-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html