Re: [PATCH v2 2/2] usb: chipidea: usbmisc: Add support for i.MX51 CPU

2013-12-04 Thread Peter Chen 
On Tue, Nov 26, 2013 at 07:36:50PM +0400, Alexander Shiyan wrote:
 This adds i.MX51 as the next user of the usbmisc driver.
 Functionality is similar to i.MX53, so at this stage simply
 reuse existing i.MX53 calls.
 
 Signed-off-by: Alexander Shiyan shc_w...@mail.ru
 ---
  drivers/usb/chipidea/usbmisc_imx.c | 4 
  1 file changed, 4 insertions(+)
 
 diff --git a/drivers/usb/chipidea/usbmisc_imx.c 
 b/drivers/usb/chipidea/usbmisc_imx.c
 index 4381c5a6..cd061ab 100644
 --- a/drivers/usb/chipidea/usbmisc_imx.c
 +++ b/drivers/usb/chipidea/usbmisc_imx.c
 @@ -204,6 +204,10 @@ static const struct of_device_id usbmisc_imx_dt_ids[] = {
   .data = imx27_usbmisc_ops,
   },
   {
 + .compatible = fsl,imx51-usbmisc,
 + .data = imx53_usbmisc_ops,
 + },
 + {
   .compatible = fsl,imx53-usbmisc,
   .data = imx53_usbmisc_ops,
   },
 -- 
 1.8.3.2
 
 

Applied, thanks.

-- 

Best Regards,
Peter Chen

--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH v2 2/2] usb: chipidea: usbmisc: Add support for i.MX51 CPU

2013-11-29 Thread Peter Chen 

 
 This adds i.MX51 as the next user of the usbmisc driver.
 Functionality is similar to i.MX53, so at this stage simply
 reuse existing i.MX53 calls.
 
 Signed-off-by: Alexander Shiyan shc_w...@mail.ru
 ---
  drivers/usb/chipidea/usbmisc_imx.c | 4 
  1 file changed, 4 insertions(+)
 
 diff --git a/drivers/usb/chipidea/usbmisc_imx.c
 b/drivers/usb/chipidea/usbmisc_imx.c
 index 4381c5a6..cd061ab 100644
 --- a/drivers/usb/chipidea/usbmisc_imx.c
 +++ b/drivers/usb/chipidea/usbmisc_imx.c
 @@ -204,6 +204,10 @@ static const struct of_device_id usbmisc_imx_dt_ids[]
 = {
   .data = imx27_usbmisc_ops,
   },
   {
 + .compatible = fsl,imx51-usbmisc,
 + .data = imx53_usbmisc_ops,
 + },
 + {
   .compatible = fsl,imx53-usbmisc,
   .data = imx53_usbmisc_ops,
   },
 --

Acked-by: Peter Chen peter.c...@freescale.com

Peter

--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 2/2] usb: chipidea: usbmisc: Add support for i.MX51 CPU

2013-11-27 Thread Shawn Guo 
On Tue, Nov 26, 2013 at 07:36:50PM +0400, Alexander Shiyan wrote:
 This adds i.MX51 as the next user of the usbmisc driver.
 Functionality is similar to i.MX53, so at this stage simply
 reuse existing i.MX53 calls.
 
 Signed-off-by: Alexander Shiyan shc_w...@mail.ru
 ---
  drivers/usb/chipidea/usbmisc_imx.c | 4 
  1 file changed, 4 insertions(+)
 
 diff --git a/drivers/usb/chipidea/usbmisc_imx.c 
 b/drivers/usb/chipidea/usbmisc_imx.c
 index 4381c5a6..cd061ab 100644
 --- a/drivers/usb/chipidea/usbmisc_imx.c
 +++ b/drivers/usb/chipidea/usbmisc_imx.c
 @@ -204,6 +204,10 @@ static const struct of_device_id usbmisc_imx_dt_ids[] = {
   .data = imx27_usbmisc_ops,
   },
   {
 + .compatible = fsl,imx51-usbmisc,
 + .data = imx53_usbmisc_ops,

If it simply uses imx53 ops, why do we need to introduce a new
compatible?

Shawn

 + },
 + {
   .compatible = fsl,imx53-usbmisc,
   .data = imx53_usbmisc_ops,
   },
 -- 
 1.8.3.2
 

--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 2/2] usb: chipidea: usbmisc: Add support for i.MX51 CPU

2013-11-27 Thread Alexander Shiyan 
Hello.

 On Tue, Nov 26, 2013 at 07:36:50PM +0400, Alexander Shiyan wrote:
  This adds i.MX51 as the next user of the usbmisc driver.
  Functionality is similar to i.MX53, so at this stage simply
  reuse existing i.MX53 calls.
  
  Signed-off-by: Alexander Shiyan shc_w...@mail.ru
  ---
   drivers/usb/chipidea/usbmisc_imx.c | 4 
   1 file changed, 4 insertions(+)
  
  diff --git a/drivers/usb/chipidea/usbmisc_imx.c 
  b/drivers/usb/chipidea/usbmisc_imx.c
  index 4381c5a6..cd061ab 100644
  --- a/drivers/usb/chipidea/usbmisc_imx.c
  +++ b/drivers/usb/chipidea/usbmisc_imx.c
  @@ -204,6 +204,10 @@ static const struct of_device_id usbmisc_imx_dt_ids[] 
  = {
  .data = imx27_usbmisc_ops,
  },
  {
  +   .compatible = fsl,imx51-usbmisc,
  +   .data = imx53_usbmisc_ops,
 
 If it simply uses imx53 ops, why do we need to introduce a new
 compatible?

This has been discussed here:
http://www.spinics.net/lists/linux-usb/msg97502.html

Additionally, fsl,imx51-usbmisc string already present in imx51.dtsi.
Thanks.

---
N�r��yb�X��ǧv�^�)޺{.n�+{��^n�r���z���h����G���h�(�階�ݢj���m��z�ޖ���f���h���~�m�

[PATCH v2 2/2] usb: chipidea: usbmisc: Add support for i.MX51 CPU

2013-11-26 Thread Alexander Shiyan 
This adds i.MX51 as the next user of the usbmisc driver.
Functionality is similar to i.MX53, so at this stage simply
reuse existing i.MX53 calls.

Signed-off-by: Alexander Shiyan shc_w...@mail.ru
---
 drivers/usb/chipidea/usbmisc_imx.c | 4 
 1 file changed, 4 insertions(+)

diff --git a/drivers/usb/chipidea/usbmisc_imx.c 
b/drivers/usb/chipidea/usbmisc_imx.c
index 4381c5a6..cd061ab 100644
--- a/drivers/usb/chipidea/usbmisc_imx.c
+++ b/drivers/usb/chipidea/usbmisc_imx.c
@@ -204,6 +204,10 @@ static const struct of_device_id usbmisc_imx_dt_ids[] = {
.data = imx27_usbmisc_ops,
},
{
+   .compatible = fsl,imx51-usbmisc,
+   .data = imx53_usbmisc_ops,
+   },
+   {
.compatible = fsl,imx53-usbmisc,
.data = imx53_usbmisc_ops,
},
-- 
1.8.3.2

--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html