Re: [PATCH v2 2/4] Documentation: usb: gadget-testing: add description for depth of queue

[Felipe Balbi]

Hi,

Peter Chen  writes:
> On Thu, Nov 19, 2015 at 12:24:28PM -0600, Felipe Balbi wrote:
>> 
>> Hi,
>> 
>> Peter Chen  writes:
>> > Add both bulk and iso depth of queue for sourcesink.
>> >
>> > Signed-off-by: Peter Chen 
>> > ---
>> >  Documentation/usb/gadget-testing.txt | 2 ++
>> >  1 file changed, 2 insertions(+)
>> >
>> > diff --git a/Documentation/usb/gadget-testing.txt 
>> > b/Documentation/usb/gadget-testing.txt
>> > index b24d3ef..84b3d10 100644
>> > --- a/Documentation/usb/gadget-testing.txt
>> > +++ b/Documentation/usb/gadget-testing.txt
>> > @@ -579,6 +579,8 @@ The SOURCESINK function provides these attributes in 
>> > its function directory:
>> >isoc_mult   - 0..2 (hs/ss only)
>> >isoc_maxburst   - 0..15 (ss only)
>> >bulk_buflen - buffer length
>> > +  bulk_qlen   - depth of queue for bulk
>> > +  iso_qlen- depth of queue for iso
>> 
>> doesn't apply for me:
>> 
>> Applying: Documentation: usb: gadget-testing: add description for depth of 
>> queue
>> error: patch failed: Documentation/usb/gadget-testing.txt:579
>> error: Documentation/usb/gadget-testing.txt: patch does not apply
>> Patch failed at 0001 Documentation: usb: gadget-testing: add description for 
>> depth of queue
>> The copy of the patch that failed is found in: 
>> workspace/linux/.git/rebase-apply/patch
>> When you have resolved this problem, run "git am --continue".
>> If you prefer to skip this patch, run "git am --skip" instead.
>> To restore the original branch and stop patching, run "git am --abort".
>> 
>> Care to rebase on my testing/next ?
>> 
>> Note that patch 1 is already applied. When rebasing, please collect
>> Krzysztof's Reviewed-by ;-)
>> 
>
> I find the first three has already been applied, thanks for doing that.
> But the patch 4/4 has not applied, do you need me to re-send it after
> adding Krzysztof's Reviewed-by?

just applied. Turns out it was emacs acting up.

-- 
balbi


signature.asc
Description: PGP signature

Re: [PATCH v2 2/4] Documentation: usb: gadget-testing: add description for depth of queue

[Krzysztof Opasiak]

On 11/19/2015 08:02 AM, Peter Chen wrote:

Add both bulk and iso depth of queue for sourcesink.

Signed-off-by: Peter Chen 


Reviewed-by: Krzysztof Opasiak 


---
  Documentation/usb/gadget-testing.txt | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/Documentation/usb/gadget-testing.txt 
b/Documentation/usb/gadget-testing.txt
index b24d3ef..84b3d10 100644
--- a/Documentation/usb/gadget-testing.txt
+++ b/Documentation/usb/gadget-testing.txt
@@ -579,6 +579,8 @@ The SOURCESINK function provides these attributes in its 
function directory:
isoc_mult   - 0..2 (hs/ss only)
isoc_maxburst   - 0..15 (ss only)
bulk_buflen - buffer length
+   bulk_qlen   - depth of queue for bulk
+   iso_qlen- depth of queue for iso



I'd prefer "queue length for bulk/iso requests" but I'm not native 
speaker or even English expert. For me, your form is also understandable 
so you may leave this as is, change or wait for another opinion, as you 
wish;)


Best regards,
--
Krzysztof Opasiak
Samsung R Institute Poland
Samsung Electronics
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 2/4] Documentation: usb: gadget-testing: add description for depth of queue

[Felipe Balbi]

Hi,

Peter Chen  writes:
> Add both bulk and iso depth of queue for sourcesink.
>
> Signed-off-by: Peter Chen 
> ---
>  Documentation/usb/gadget-testing.txt | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/usb/gadget-testing.txt 
> b/Documentation/usb/gadget-testing.txt
> index b24d3ef..84b3d10 100644
> --- a/Documentation/usb/gadget-testing.txt
> +++ b/Documentation/usb/gadget-testing.txt
> @@ -579,6 +579,8 @@ The SOURCESINK function provides these attributes in its 
> function directory:
>   isoc_mult   - 0..2 (hs/ss only)
>   isoc_maxburst   - 0..15 (ss only)
>   bulk_buflen - buffer length
> + bulk_qlen   - depth of queue for bulk
> + iso_qlen- depth of queue for iso

doesn't apply for me:

Applying: Documentation: usb: gadget-testing: add description for depth of queue
error: patch failed: Documentation/usb/gadget-testing.txt:579
error: Documentation/usb/gadget-testing.txt: patch does not apply
Patch failed at 0001 Documentation: usb: gadget-testing: add description for 
depth of queue
The copy of the patch that failed is found in: 
workspace/linux/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Care to rebase on my testing/next ?

Note that patch 1 is already applied. When rebasing, please collect
Krzysztof's Reviewed-by ;-)

cheers

-- 
balbi


signature.asc
Description: PGP signature

Re: [PATCH v2 2/4] Documentation: usb: gadget-testing: add description for depth of queue

[Peter Chen]

On Thu, Nov 19, 2015 at 12:24:28PM -0600, Felipe Balbi wrote:
> 
> Hi,
> 
> Peter Chen  writes:
> > Add both bulk and iso depth of queue for sourcesink.
> >
> > Signed-off-by: Peter Chen 
> > ---
> >  Documentation/usb/gadget-testing.txt | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/usb/gadget-testing.txt 
> > b/Documentation/usb/gadget-testing.txt
> > index b24d3ef..84b3d10 100644
> > --- a/Documentation/usb/gadget-testing.txt
> > +++ b/Documentation/usb/gadget-testing.txt
> > @@ -579,6 +579,8 @@ The SOURCESINK function provides these attributes in 
> > its function directory:
> > isoc_mult   - 0..2 (hs/ss only)
> > isoc_maxburst   - 0..15 (ss only)
> > bulk_buflen - buffer length
> > +   bulk_qlen   - depth of queue for bulk
> > +   iso_qlen- depth of queue for iso
> 
> doesn't apply for me:
> 
> Applying: Documentation: usb: gadget-testing: add description for depth of 
> queue
> error: patch failed: Documentation/usb/gadget-testing.txt:579
> error: Documentation/usb/gadget-testing.txt: patch does not apply
> Patch failed at 0001 Documentation: usb: gadget-testing: add description for 
> depth of queue
> The copy of the patch that failed is found in: 
> workspace/linux/.git/rebase-apply/patch
> When you have resolved this problem, run "git am --continue".
> If you prefer to skip this patch, run "git am --skip" instead.
> To restore the original branch and stop patching, run "git am --abort".
> 
> Care to rebase on my testing/next ?
> 
> Note that patch 1 is already applied. When rebasing, please collect
> Krzysztof's Reviewed-by ;-)
> 

I find the first three has already been applied, thanks for doing that.
But the patch 4/4 has not applied, do you need me to re-send it after
adding Krzysztof's Reviewed-by?

-- 

Best Regards,
Peter Chen
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2 2/4] Documentation: usb: gadget-testing: add description for depth of queue

[Peter Chen]

Add both bulk and iso depth of queue for sourcesink.

Signed-off-by: Peter Chen 
---
 Documentation/usb/gadget-testing.txt | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/usb/gadget-testing.txt 
b/Documentation/usb/gadget-testing.txt
index b24d3ef..84b3d10 100644
--- a/Documentation/usb/gadget-testing.txt
+++ b/Documentation/usb/gadget-testing.txt
@@ -579,6 +579,8 @@ The SOURCESINK function provides these attributes in its 
function directory:
isoc_mult   - 0..2 (hs/ss only)
isoc_maxburst   - 0..15 (ss only)
bulk_buflen - buffer length
+   bulk_qlen   - depth of queue for bulk
+   iso_qlen- depth of queue for iso
 
 Testing the SOURCESINK function
 ---
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html